Skip to contentSkip to conversation

mtd: spi-nor: Add support for BoHong bh25q128as

PATCH Superseded Christian Marangi 2 participants 3 messages Feb 17, 2024 – Feb 19, 2024

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mtd: spi-nor: Add support for BoHong bh25q128as

From: David Bauer <[email protected]>

Add MTD support for the BoHong bh25q128as SPI NOR chip. The chip has 16MB of total capacity, divided into a total of 256 sectors, each 64KB sized. The chip also supports 4KB sectors. Additionally, it supports dual and quad read modes.

Datasheet is public and can be found here [1].

Functionality was verified on an Tenbay WR1800K / MTK MT7621 board.

[1] https://www.e-interlink.com.tw/userUpload/files/BH25Q128AS_v1_0.pdf

[ reworked to new flash_info format ]
---
 drivers/mtd/spi-nor/Makefile |  1 +
 drivers/mtd/spi-nor/bohong.c | 24 ++++++++++++++++++++++++
 drivers/mtd/spi-nor/core.c   |  1 +
 drivers/mtd/spi-nor/core.h   |  1 +
 4 files changed, 27 insertions(+)
 create mode 100644 drivers/mtd/spi-nor/bohong.c
drivers/mtd/spi-nor/Makefile +1 -0
index 5e68468b72fc..c8849cf5124f 100644
@@ -2,6 +2,7 @@
 
 spi-nor-objs			:= core.o sfdp.o swp.o otp.o sysfs.o
 spi-nor-objs			+= atmel.o
+spi-nor-objs			+= bohong.o
 spi-nor-objs			+= eon.o
 spi-nor-objs			+= esmt.o
 spi-nor-objs			+= everspin.o
drivers/mtd/spi-nor/bohong.c new file +24 -0
new file mode 100644
index 000000000000..26988c139262
@@ -0,0 +1,24 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (C) 2005, Intec Automation Inc.
+ * Copyright (C) 2014, Freescale Semiconductor, Inc.
+ */
+
+#include <linux/mtd/spi-nor.h>
+
+#include "core.h"
+
+static const struct flash_info bohong_parts[] = {
+	{
+		.id = SNOR_ID(0x68, 0x40, 0x18),
+		.name = "bh25q128as",
+		.size = SZ_16M,
+		.no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,
+	},
+};
+
+const struct spi_nor_manufacturer spi_nor_bohong = {
+	.name = "bohong",
+	.parts = bohong_parts,
+	.nparts = ARRAY_SIZE(bohong_parts),
+};
drivers/mtd/spi-nor/core.c +1 -0
index 4129764fad8c..29c28ee683a1 100644
@@ -2037,6 +2037,7 @@ int spi_nor_sr2_bit7_quad_enable(struct spi_nor *nor)
 
 static const struct spi_nor_manufacturer *manufacturers[] = {
 	&spi_nor_atmel,
+	&spi_nor_bohong,
 	&spi_nor_eon,
 	&spi_nor_esmt,
 	&spi_nor_everspin,
drivers/mtd/spi-nor/core.h +1 -0
index d36c0e072954..c293568ae827 100644
@@ -601,6 +601,7 @@ struct sfdp {
 
 /* Manufacturer drivers. */
 extern const struct spi_nor_manufacturer spi_nor_atmel;
+extern const struct spi_nor_manufacturer spi_nor_bohong;
 extern const struct spi_nor_manufacturer spi_nor_eon;
 extern const struct spi_nor_manufacturer spi_nor_esmt;
 extern const struct spi_nor_manufacturer spi_nor_everspin;
Signature · 1 line
2.43.0
maintainer
#1 lore raw

Hi,

Quoted 8 lines · Christian Marangi

From: David Bauer <[email protected]>

Add MTD support for the BoHong bh25q128as SPI NOR chip. The chip has 16MB of total capacity, divided into a total of 256 sectors, each 64KB sized. The chip also supports 4KB sectors. Additionally, it supports dual and quad read modes.

Datasheet is public and can be found here [1].

Last time it wasn't clear if this flash will support SFDP or not. Could you please try to dump the SFDP again, see [1].

Quoted 1 line

Functionality was verified on an Tenbay WR1800K / MTK MT7621 board.

Also per [1], you'd need to provide your test results.

Quoted 1 line

[1] https://www.e-interlink.com.tw/userUpload/files/BH25Q128AS_v1_0.pdf

Link right above your SoB please.
Quoted 29 lines
[ reworked to new flash_info format ]
---
 drivers/mtd/spi-nor/Makefile |  1 +
 drivers/mtd/spi-nor/bohong.c | 24 ++++++++++++++++++++++++
 drivers/mtd/spi-nor/core.c   |  1 +
 drivers/mtd/spi-nor/core.h   |  1 +
 4 files changed, 27 insertions(+)
 create mode 100644 drivers/mtd/spi-nor/bohong.c
drivers/mtd/spi-nor/Makefile +1 -0
index 5e68468b72fc..c8849cf5124f 100644
@@ -2,6 +2,7 @@
 
 spi-nor-objs			:= core.o sfdp.o swp.o otp.o sysfs.o
 spi-nor-objs			+= atmel.o
+spi-nor-objs			+= bohong.o
 spi-nor-objs			+= eon.o
 spi-nor-objs			+= esmt.o
 spi-nor-objs			+= everspin.o
drivers/mtd/spi-nor/bohong.c new file +0 -0
new file mode 100644
index 000000000000..26988c139262

drivers/mtd/spi-nor/bohong.c line 4

Quoted 4 lines
drivers/mtd/spi-nor/bohong.c new file +4 -0
@@ -0,0 +1,24 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (C) 2005, Intec Automation Inc.
+ * Copyright (C) 2014, Freescale Semiconductor, Inc.

Please remove, there is nothing from the old code left here.

drivers/mtd/spi-nor/bohong.c line 14

Quoted 10 lines
drivers/mtd/spi-nor/bohong.c new file +10 -0
+ */
+
+#include <linux/mtd/spi-nor.h>
+
+#include "core.h"
+
+static const struct flash_info bohong_parts[] = {
+	{
+		.id = SNOR_ID(0x68, 0x40, 0x18),
+		.name = "bh25q128as",

No names anymore, please.

drivers/mtd/spi-nor/bohong.c line 21

Quoted 7 lines
drivers/mtd/spi-nor/bohong.c new file +7 -0
+		.size = SZ_16M,
+		.no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,
+	},
+};
+
+const struct spi_nor_manufacturer spi_nor_bohong = {
+	.name = "bohong",

This should be dropped, too. Otherwise looks good, if SFDP is not supported.

-michael

[1] https://docs.kernel.org/driver-api/mtd/spi-nor.html

Quoted 27 lines
drivers/mtd/spi-nor/bohong.c new file +3 -0
+	.parts = bohong_parts,
+	.nparts = ARRAY_SIZE(bohong_parts),
+};
drivers/mtd/spi-nor/core.c +1 -0
index 4129764fad8c..29c28ee683a1 100644
@@ -2037,6 +2037,7 @@ int spi_nor_sr2_bit7_quad_enable(struct spi_nor *nor)
 
 static const struct spi_nor_manufacturer *manufacturers[] = {
 	&spi_nor_atmel,
+	&spi_nor_bohong,
 	&spi_nor_eon,
 	&spi_nor_esmt,
 	&spi_nor_everspin,
drivers/mtd/spi-nor/core.h +1 -0
index d36c0e072954..c293568ae827 100644
@@ -601,6 +601,7 @@ struct sfdp {
 
 /* Manufacturer drivers. */
 extern const struct spi_nor_manufacturer spi_nor_atmel;
+extern const struct spi_nor_manufacturer spi_nor_bohong;
 extern const struct spi_nor_manufacturer spi_nor_eon;
 extern const struct spi_nor_manufacturer spi_nor_esmt;
 extern const struct spi_nor_manufacturer spi_nor_everspin;
#2 lore raw
Quoted 10 lines · Michael Walle

Hi,

Quoted 7 lines · Christian Marangi

From: David Bauer <[email protected]>

Add MTD support for the BoHong bh25q128as SPI NOR chip. The chip has 16MB of total capacity, divided into a total of 256 sectors, each 64KB sized. The chip also supports 4KB sectors. Additionally, it supports dual and quad read modes.

Quoted 5 lines
Quoted 1 line

Datasheet is public and can be found here [1].

Last time it wasn't clear if this flash will support SFDP or not. Could you please try to dump the SFDP again, see [1].

Ok will include in v2.

Quoted 45 lines
Quoted 2 lines

Functionality was verified on an Tenbay WR1800K / MTK MT7621 board.

Also per [1], you'd need to provide your test results.

Quoted 1 line

[1] https://www.e-interlink.com.tw/userUpload/files/BH25Q128AS_v1_0.pdf

Link right above your SoB please.
Quoted 29 lines
[ reworked to new flash_info format ]
---
 drivers/mtd/spi-nor/Makefile |  1 +
 drivers/mtd/spi-nor/bohong.c | 24 ++++++++++++++++++++++++
 drivers/mtd/spi-nor/core.c   |  1 +
 drivers/mtd/spi-nor/core.h   |  1 +
 4 files changed, 27 insertions(+)
 create mode 100644 drivers/mtd/spi-nor/bohong.c
drivers/mtd/spi-nor/Makefile +1 -0
index 5e68468b72fc..c8849cf5124f 100644
@@ -2,6 +2,7 @@
 
 spi-nor-objs			:= core.o sfdp.o swp.o otp.o sysfs.o
 spi-nor-objs			+= atmel.o
+spi-nor-objs			+= bohong.o
 spi-nor-objs			+= eon.o
 spi-nor-objs			+= esmt.o
 spi-nor-objs			+= everspin.o
drivers/mtd/spi-nor/bohong.c new file +0 -0
new file mode 100644
index 000000000000..26988c139262

drivers/mtd/spi-nor/bohong.c line 4

Quoted 4 lines
drivers/mtd/spi-nor/bohong.c new file +4 -0
@@ -0,0 +1,24 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (C) 2005, Intec Automation Inc.
+ * Copyright (C) 2014, Freescale Semiconductor, Inc.

Please remove, there is nothing from the old code left here.

Quoted 12 lines

drivers/mtd/spi-nor/bohong.c line 14

Quoted 10 lines
drivers/mtd/spi-nor/bohong.c new file +10 -0
+ */
+
+#include <linux/mtd/spi-nor.h>
+
+#include "core.h"
+
+static const struct flash_info bohong_parts[] = {
+	{
+		.id = SNOR_ID(0x68, 0x40, 0x18),
+		.name = "bh25q128as",

No names anymore, please.

Mhhh why this change? Doesn't this makes the thing problematic to identify?

Quoted 11 lines

drivers/mtd/spi-nor/bohong.c line 21

Quoted 7 lines
drivers/mtd/spi-nor/bohong.c new file +7 -0
+		.size = SZ_16M,
+		.no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,
+	},
+};
+
+const struct spi_nor_manufacturer spi_nor_bohong = {
+	.name = "bohong",

This should be dropped, too. Otherwise looks good, if SFDP is not supported.

Ok, thanks a lot for the review!

Quoted 31 lines

[1] https://docs.kernel.org/driver-api/mtd/spi-nor.html

Quoted 27 lines
drivers/mtd/spi-nor/bohong.c new file +3 -0
+	.parts = bohong_parts,
+	.nparts = ARRAY_SIZE(bohong_parts),
+};
drivers/mtd/spi-nor/core.c +1 -0
index 4129764fad8c..29c28ee683a1 100644
@@ -2037,6 +2037,7 @@ int spi_nor_sr2_bit7_quad_enable(struct spi_nor *nor)
 
 static const struct spi_nor_manufacturer *manufacturers[] = {
 	&spi_nor_atmel,
+	&spi_nor_bohong,
 	&spi_nor_eon,
 	&spi_nor_esmt,
 	&spi_nor_everspin,
drivers/mtd/spi-nor/core.h +1 -0
index d36c0e072954..c293568ae827 100644
@@ -601,6 +601,7 @@ struct sfdp {
 
 /* Manufacturer drivers. */
 extern const struct spi_nor_manufacturer spi_nor_atmel;
+extern const struct spi_nor_manufacturer spi_nor_bohong;
 extern const struct spi_nor_manufacturer spi_nor_eon;
 extern const struct spi_nor_manufacturer spi_nor_esmt;
 extern const struct spi_nor_manufacturer spi_nor_everspin;
Signature · 1 line
	Ansuel