dt-bindings: mtd: spi-nor: add optional interrupts property
Subsystems (3)
PATCH v7 1/1 dt-bindings: mtd: spi-nor: add optional interrupts property
Some spi flash memories have an interrupt signal which can be used for signalling on-chip events such as busy status or ecc errors to the host.
Add binding for "interrupts" property so that boards wiring this signal may describe the connection.
---
Changes in v7:
- split out of original patchset because it should go via mtd tree
- collected acked-by Rob Herring from v6
- Link to v6: https://lore.kernel.org/r/[email protected]
--- Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml | 3 +++ 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml +3 -0
@@ -52,6 +52,9 @@ properties: minItems: 1 maxItems: 2 + interrupts: + maxItems: 1 + m25p,fast-read: type: boolean description:
---
base-commit: 6613476e225e090cc9aad49be7fa504e290dd33d
change-id: 20240219-mtd-flash-interrupt-binding-647f78d123cb
Best regards,
Signature · 1 line
Josua Mayer <[email protected]>
Quoted 8 lines · Josua Mayer
Some spi flash memories have an interrupt signal which can be used for signalling on-chip events such as busy status or ecc errors to the host.
Add binding for "interrupts" property so that boards wiring this signal may describe the connection.
Signed-off-by Josua Mayer <[email protected]>Acked-by Rob Herring <[email protected]>
BTW, I don't see any support in SPI NOR for handling these interrupts. Do you plan to add them in a later patchset? If not, what do you get by describing them?
Quoted 24 lines
---
Changes in v7:
- split out of original patchset because it should go via mtd tree
- collected acked-by Rob Herring from v6
- Link to v6: https://lore.kernel.org/r/[email protected]--- Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml | 3 +++ 1 file changed, 3 insertions(+)Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml +3
-0@@ -52,6 +52,9 @@ properties: minItems: 1 maxItems: 2 + interrupts: + maxItems: 1 + m25p,fast-read: type: boolean description:
Signature · 2 lines
Regards, Pratyush Yadav
Am 20.02.24 um 13:19 schrieb Pratyush Yadav:
Quoted 8 lines · Josua Mayer
Quoted 7 lines
Some spi flash memories have an interrupt signal which can be used for signalling on-chip events such as busy status or ecc errors to the host.
Add binding for "interrupts" property so that boards wiring this signal may describe the connection.
Quoted 6 lines
Quoted 2 lines
Signed-off-by Josua Mayer <[email protected]>Acked-by Rob Herring <[email protected]>Acked-by Pratyush Yadav <[email protected]>BTW, I don't see any support in SPI NOR for handling these interrupts. Do you plan to add them in a later patchset?
No current plans, I have little knowledge how spi-nor works in the kernel.
Quoted 2 lines
If not, what do you get by
describing them?
Foremost I get to submit a correct device-tree (describes hardware) to the kernel, without maintainers getting all over me for introducing new dtbs_check errors.
And I really do prefer submitting a complete device-tree so that all knowledge I have gained reading private schematics is readily available the next time someone works on it.
Quoted 25 lines
Quoted 25 lines
---
Changes in v7:
- split out of original patchset because it should go via mtd tree
- collected acked-by Rob Herring from v6
- Link to v6: https://lore.kernel.org/r/[email protected]--- Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml | 3 +++ 1 file changed, 3 insertions(+)Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml +3
-0@@ -52,6 +52,9 @@ properties: minItems: 1 maxItems: 2 + interrupts: + maxItems: 1 + m25p,fast-read: type: boolean description:
Pratyush Yadav
maintainerQuoted 18 lines · Josua Mayer
Am 20.02.24 um 13:19 schrieb Pratyush Yadav:
Quoted 8 lines · Josua Mayer
Quoted 7 lines
Some spi flash memories have an interrupt signal which can be used for signalling on-chip events such as busy status or ecc errors to the host.
Add binding for "interrupts" property so that boards wiring this signal may describe the connection.
Quoted 6 lines
Quoted 2 lines
Signed-off-by Josua Mayer <[email protected]>Acked-by Rob Herring <[email protected]>Acked-by Pratyush Yadav <[email protected]>BTW, I don't see any support in SPI NOR for handling these interrupts. Do you plan to add them in a later patchset?
No current plans, I have little knowledge how spi-nor works in the kernel.
Quoted 2 lines
If not, what do you get by
describing them?
Quoted 7 lines
Foremost I get to submit a correct device-tree (describes hardware) to the kernel, without maintainers getting all over me for introducing new
dtbs_checkerrors.And I really do prefer submitting a complete device-tree so that all knowledge I have gained reading private schematics is readily available the next time someone works on it.
Fair enough. I guessed as much but thanks for the confirmation!
[...]
Signature · 2 lines
Regards, Pratyush Yadav
Michael Walle
maintainerHi,
Quoted 2 lines · Josua Mayer
Some spi flash memories have an interrupt signal which can be used for signalling on-chip events such as busy status or ecc errors to the host.
Do you have an example? Maybe one with a public datasheet?
-michael
Hi,
Am 21.02.24 um 09:27 schrieb Michael Walle:
Quoted 6 lines
Hi,
Quoted 2 lines · Josua Mayer
Some spi flash memories have an interrupt signal which can be used for signalling on-chip events such as busy status or ecc errors to the host.
Do you have an example? Maybe one with a public datasheet?
My example is Infineon S28HS512T, however datasheet download requires user account.
S26HS512T has interrupt line, too, and datasheet is downloadable without registration:
https://www.infineon.com/cms/en/product/memories/nor-flash/semper-nor-flash-family/semper-nor-flash/#!documents
Quoted 2 lines
-michael
Michael Walle
maintainer[+ Takahiro]
Hi,
Quoted 8 lines · Josua Mayer
Hi,
Am 21.02.24 um 09:27 schrieb Michael Walle:
Quoted 5 lines
Hi,
Quoted 2 lines · Josua Mayer
Some spi flash memories have an interrupt signal which can be used for signalling on-chip events such as busy status or ecc errors to the host.
Quoted 8 lines
Quoted 1 line
Do you have an example? Maybe one with a public datasheet?
My example is Infineon S28HS512T, however datasheet download requires user account.
S26HS512T has interrupt line, too, and datasheet is downloadable without registration:
https://www.infineon.com/cms/en/product/memories/nor-flash/semper-nor-flash-family/semper-nor-flash/#!documents
Thanks, as far as I can see, both are hyperbus flashes. I'm asking because I'm not aware of any SPI NOR flash with an interrupt line.
-michael
Pratyush Yadav
maintainerQuoted 18 lines · Michael Walle
[+ Takahiro]
Hi,
Quoted 13 lines · Josua Mayer
Hi,
Am 21.02.24 um 09:27 schrieb Michael Walle:
Quoted 6 lines
Hi,
Quoted 2 lines · Josua Mayer
Some spi flash memories have an interrupt signal which can be used for signalling on-chip events such as busy status or ecc errors to the host.
Do you have an example? Maybe one with a public datasheet?
My example is Infineon S28HS512T, however datasheet download requires user account.
Quoted 6 lines
Quoted 3 lines
S26HS512T has interrupt line, too, and datasheet is downloadable without registration:
https://www.infineon.com/cms/en/product/memories/nor-flash/semper-nor-flash-family/semper-nor-flash/#!documentsThanks, as far as I can see, both are hyperbus flashes. I'm asking because I'm not aware of any SPI NOR flash with an interrupt line.
I found this datasheet [0] for S28H flash family from Infineon on Google. These are SPI NOR flashes. In pinout you can see there is an INT# signal. The signal description says: "System Interrupt (INT#). When LOW, the device is indicating that an internal event has occurred." Further in section 4.1.1.5 "INT# Output" it says:
HL-T/HS-T supports INT# output pin to indicate to the host system that an event has occurred within the flash device. The user can configure the INT# output pin to transition to the active (LOW) state when:
- 2-bit ECC error is detected
- 1-bit ECC error is detected
- Transitioning from the Busy to the Ready state
Signature · 2 lines
Regards, Pratyush Yadav
Quoted 38 lines · Pratyush Yadav
Quoted 18 lines · Michael Walle
[+ Takahiro]
Hi,
Quoted 13 lines · Josua Mayer
Hi,
Am 21.02.24 um 09:27 schrieb Michael Walle:
Quoted 6 lines
Hi,
Quoted 2 lines · Josua Mayer
Some spi flash memories have an interrupt signal which can be used for signalling on-chip events such as busy status or ecc errors to the host.
Do you have an example? Maybe one with a public datasheet?
My example is Infineon S28HS512T, however datasheet download requires user account.
Quoted 6 lines
Quoted 3 lines
S26HS512T has interrupt line, too, and datasheet is downloadable without registration:
https://www.infineon.com/cms/en/product/memories/nor-flash/semper-nor-flash-family/semper-nor-flash/#!documentsThanks, as far as I can see, both are hyperbus flashes. I'm asking because I'm not aware of any SPI NOR flash with an interrupt line.
I found this datasheet [0] for S28H flash family from Infineon on Google. These are SPI NOR flashes. In pinout you can see there is an INT# signal. The signal description says: "System Interrupt (INT#). When LOW, the device is indicating that an internal event has occurred." Further in section 4.1.1.5 "INT# Output" it says:
HL-T/HS-T supports INT# output pin to indicate to the host system that an event has occurred within the flash device. The user can configure the INT# output pin to transition to the active (LOW) state when:
Quoted 5 lines
- 2-bit ECC error is detected
- 1-bit ECC error is detected
- Transitioning from the Busy to the Ready state
Okay then,
-michael
Tudor Ambarus
AppliedQuoted 8 lines · Josua Mayer
Some spi flash memories have an interrupt signal which can be used for signalling on-chip events such as busy status or ecc errors to the host.
Add binding for "interrupts" property so that boards wiring this signal may describe the connection.
[...]
Applied to git://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git,
spi-nor/next branch. Thanks!
[1/1] dt-bindings: mtd: spi-nor: add optional interrupts property
(no commit info)
Cheers,
Signature · 1 line
Tudor Ambarus <[email protected]>