Skip to contentSkip to conversation

device property: Move enum dev_dma_attr to fwnode.h

PATCH In review Andy Shevchenko 2 participants 3 messages Feb 20, 2024 – Feb 23, 2024

Subsystems (3)
lore
Share & tools
lore

Andy Shevchenko

author reviewer
#0 lore raw

PATCH 1/1 device property: Move enum dev_dma_attr to fwnode.h

The struct fwnode_operations defines one of the callback to return enum dev_dma_attr. But this currently is defined in property.h. Move it to the correct location.

Fixes 8c756a0a2de1 ("device property: Convert device_{dma_supported,get_dma_attr} to fwnode")
---
 include/linux/fwnode.h   | 6 ++++++
 include/linux/property.h | 6 ------
 2 files changed, 6 insertions(+), 6 deletions(-)
include/linux/fwnode.h +6 -0
index c1379f2d4a44..fabcd5ce084d 100644
@@ -15,6 +15,12 @@
 #include <linux/list.h>
 #include <linux/types.h>
 
+enum dev_dma_attr {
+	DEV_DMA_NOT_SUPPORTED,
+	DEV_DMA_NON_COHERENT,
+	DEV_DMA_COHERENT,
+};
+
 struct fwnode_operations;
 
 /*
include/linux/property.h +0 -6
index e6516d0b7d52..07fbebc73243 100644
@@ -27,12 +27,6 @@ enum dev_prop_type {
 	DEV_PROP_REF,
 };
 
-enum dev_dma_attr {
-	DEV_DMA_NOT_SUPPORTED,
-	DEV_DMA_NON_COHERENT,
-	DEV_DMA_COHERENT,
-};
-
 const struct fwnode_handle *__dev_fwnode_const(const struct device *dev);
 struct fwnode_handle *__dev_fwnode(struct device *dev);
 #define dev_fwnode(dev)							\
Signature · 1 line
2.43.0.rc1.1.gbec44491f096
reviewer Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Andy Shevchenko

The struct fwnode_operations defines one of the callback to return enum dev_dma_attr. But this currently is defined in property.h. Move it to the correct location.

Fixes 8c756a0a2de1 ("device property: Convert device_{dma_supported,get_dma_attr} to fwnode")
Signature · 1 line
Sakari Ailus
author reviewer
#2 lore raw
Quoted 9 lines · Sakari Ailus
Quoted 6 lines · Andy Shevchenko

The struct fwnode_operations defines one of the callback to return enum dev_dma_attr. But this currently is defined in property.h. Move it to the correct location.

Fixes 8c756a0a2de1 ("device property: Convert device_{dma_supported,get_dma_attr} to fwnode")

Thank you, I will send it as a part of the series (v2).

Signature · 2 lines
With Best Regards,
Andy Shevchenko