Skip to contentSkip to conversation

device property: Don't use "proxy" headers

PATCH In review Andy Shevchenko 2 participants 3 messages Feb 20, 2024 – Feb 23, 2024

Subsystems (3)
lore
Share & tools
lore

Andy Shevchenko

author reviewer
#0 lore raw

PATCH 1/1 device property: Don't use "proxy" headers

Update header inclusions to follow IWYU (Include What You Use) principle.

---

This one heavily depends on the
https://lore.kernel.org/r/[email protected]

 drivers/base/property.c  | 11 ++++++-----
 drivers/base/swnode.c    | 13 ++++++++++++-
 include/linux/fwnode.h   |  4 ++--
 include/linux/property.h |  1 +
 4 files changed, 21 insertions(+), 8 deletions(-)
drivers/base/property.c +6 -5
index afa1bf2b3c5a..7324a704a9a1 100644
@@ -7,15 +7,16 @@
  *          Mika Westerberg <[email protected]>
  */
 
-#include <linux/acpi.h>
+#include <linux/device.h>
+#include <linux/err.h>
 #include <linux/export.h>
-#include <linux/kernel.h>
+#include <linux/kconfig.h>
 #include <linux/of.h>
-#include <linux/of_address.h>
-#include <linux/of_graph.h>
-#include <linux/of_irq.h>
 #include <linux/property.h>
 #include <linux/phy.h>
+#include <linux/slab.h>
+#include <linux/string.h>
+#include <linux/types.h>
 
 struct fwnode_handle *__dev_fwnode(struct device *dev)
 {
drivers/base/swnode.c +12 -1
index 36512fb75a20..eb6eb25b343b 100644
@@ -6,10 +6,21 @@
  * Author: Heikki Krogerus <[email protected]>
  */
 
+#include <linux/container_of.h>
 #include <linux/device.h>
-#include <linux/kernel.h>
+#include <linux/err.h>
+#include <linux/export.h>
+#include <linux/idr.h>
+#include <linux/init.h>
+#include <linux/kobject.h>
+#include <linux/kstrtox.h>
+#include <linux/list.h>
 #include <linux/property.h>
 #include <linux/slab.h>
+#include <linux/spinlock.h>
+#include <linux/string.h>
+#include <linux/sysfs.h>
+#include <linux/types.h>
 
 #include "base.h"
 
include/linux/fwnode.h +2 -2
index 4228c45d5ccc..80f3cd91b471 100644
@@ -9,10 +9,10 @@
 #ifndef _LINUX_FWNODE_H_
 #define _LINUX_FWNODE_H_
 
-#include <linux/types.h>
-#include <linux/list.h>
 #include <linux/bits.h>
 #include <linux/err.h>
+#include <linux/list.h>
+#include <linux/types.h>
 
 enum dev_dma_attr {
 	DEV_DMA_NOT_SUPPORTED,
include/linux/property.h +1 -0
index 1f0135e24d00..3a1045eb786c 100644
@@ -11,6 +11,7 @@
 #define _LINUX_PROPERTY_H_
 
 #include <linux/args.h>
+#include <linux/array_size.h>
 #include <linux/bits.h>
 #include <linux/fwnode.h>
 #include <linux/stddef.h>
Signature · 1 line
2.43.0.rc1.1.gbec44491f096
author reviewer
#2 lore raw
Quoted 5 lines · Sakari Ailus
Quoted 2 lines · Andy Shevchenko

Update header inclusions to follow IWYU (Include What You Use) principle.

Thank you, I will send it as a part of the series (v2).

Signature · 2 lines
With Best Regards,
Andy Shevchenko