Skip to contentSkip to conversation

driver core: Drop unneeded 'extern' keyword in fwnode.h

PATCH Superseded Andy Shevchenko 3 participants 4 messages Feb 20, 2024 – Feb 23, 2024

Subsystems (3)

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Andy Shevchenko

author reviewer
#0 lore raw

PATCH v2 1/1 driver core: Drop unneeded 'extern' keyword in fwnode.h

We do not use 'extern' keyword with functions. Remove the last one mistakenly added to fwnode.h.

Fixes 19d0f5f6bff8 ("driver core: Add fw_devlink.strict kernel param")

---
v2: fixed a couple of typos in the Subject

 include/linux/fwnode.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/fwnode.h +1 -1
index 2a72f55d26eb..2d23a14857c7 100644
@@ -209,9 +209,9 @@ static inline void fwnode_dev_initialized(struct fwnode_handle *fwnode,
 		fwnode->flags &= ~FWNODE_FLAG_INITIALIZED;
 }
 
-extern bool fw_devlink_is_strict(void);
 int fwnode_link_add(struct fwnode_handle *con, struct fwnode_handle *sup);
 void fwnode_links_purge(struct fwnode_handle *fwnode);
 void fw_devlink_purge_absent_suppliers(struct fwnode_handle *fwnode);
+bool fw_devlink_is_strict(void);
 
 #endif
Signature · 1 line
2.43.0.rc1.1.gbec44491f096
Acked-by on v2 1/1
#1 lore raw
Quoted 6 lines · Andy Shevchenko

We do not use 'extern' keyword with functions. Remove the last one mistakenly added to fwnode.h.

Fixes 19d0f5f6bff8 ("driver core: Add fw_devlink.strict kernel param")
Quoted 23 lines

---
v2: fixed a couple of typos in the Subject

 include/linux/fwnode.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/fwnode.h +1 -2
index 2a72f55d26eb..2d23a14857c7 100644
@@ -209,9 +209,9 @@ static inline void fwnode_dev_initialized(struct fwnode_handle *fwnode,
                fwnode->flags &= ~FWNODE_FLAG_INITIALIZED;
 }
 
-extern bool fw_devlink_is_strict(void);
 int fwnode_link_add(struct fwnode_handle *con, struct fwnode_handle *sup);
 void fwnode_links_purge(struct fwnode_handle *fwnode);
 void fw_devlink_purge_absent_suppliers(struct fwnode_handle *fwnode);
+bool fw_devlink_is_strict(void);
 
 #endif
--

2.43.0.rc1.1.gbec44491f096

author reviewer
#2 lore raw
In reply to Saravana Kannan
Quoted 10 lines · Saravana Kannan
Quoted 6 lines · Andy Shevchenko

We do not use 'extern' keyword with functions. Remove the last one mistakenly added to fwnode.h.

Fixes 19d0f5f6bff8 ("driver core: Add fw_devlink.strict kernel param")

Thank you!

I will send as a part of a series due to dependencies.

Signature · 2 lines
With Best Regards,
Andy Shevchenko