Skip to contentSkip to conversation

maple_tree-avoid-duplicate-variable-init-in-mast_spanning_rebalance.patch removed from -mm tree

merged mm-stable Andrew Morton 1 participant 1 message Feb 22, 2024

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: maple_tree: avoid duplicate variable init in mast_spanning_rebalance()
has been removed from the -mm tree. Its filename was
maple_tree-avoid-duplicate-variable-init-in-mast_spanning_rebalance.patch

This patch was dropped because it was merged into the mm-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

------------------------------------------------------
From: Lukas Bulwahn <[email protected]>
Subject: maple_tree: avoid duplicate variable init in mast_spanning_rebalance()
Date: Mon, 22 Jan 2024 11:20:00 +0100

The local variables r_tmp and l_tmp in mast_spanning_rebalance() are already initialized at its declaration; there is no need to assign the value again.

Remove the duplicate initialization of {r,l}_tmp. No functional change. Due to common compiler optimizations, also no change to object code.

This issue was identified with clang-analyzer's dead stores analysis.

---

 lib/maple_tree.c |    2 --
 1 file changed, 2 deletions(-)
lib/maple_tree.c renamed from lib/maple_tree.c~maple_tree-avoid-duplicate-variable-init-in-mast_spanning_rebalance +0 -2
@@ -2271,8 +2271,6 @@ bool mast_spanning_rebalance(struct mapl
 	struct ma_state l_tmp = *mast->orig_l;
 	unsigned char depth = 0;
 
-	r_tmp = *mast->orig_r;
-	l_tmp = *mast->orig_l;
 	do {
 		mas_ascend(mast->orig_r);
 		mas_ascend(mast->orig_l);

_

Patches currently in -mm which might be from [email protected] are