Skip to contentSkip to conversation

arm64: tegra: Add AXI configuration for Tegra234 MGBE

PATCH In review Thierry Reding 2 participants 2 messages Feb 22, 2024 – Feb 23, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: tegra: Add AXI configuration for Tegra234 MGBE

From: Thierry Reding <[email protected]>

The MGBE devices found on Tegra234 need their AXI interface configured to operate at peak performance. Ideally we would do this in the driver based off the compatible string, but the DT bindings already specify a separate mechanism, so reuse that.

---
 arch/arm64/boot/dts/nvidia/tegra234.dtsi | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
arch/arm64/boot/dts/nvidia/tegra234.dtsi +24 -0
index 3f16595d099c..84c74155a5ca 100644
@@ -1461,6 +1461,14 @@ ethernet@6800000 {
 			iommus = <&smmu_niso0 TEGRA234_SID_MGBE>;
 			power-domains = <&bpmp TEGRA234_POWER_DOMAIN_MGBEA>;
 			status = "disabled";
+
+			snps,axi-config = <&mgbe0_axi_setup>;
+
+			mgbe0_axi_setup: stmmac-axi-config {
+				snps,blen = <256 128 64 32>;
+				snps,rd_osr_lmt = <63>;
+				snps,wr_osr_lmt = <63>;
+			};
 		};
 
 		ethernet@6900000 {
@@ -1495,6 +1503,14 @@ ethernet@6900000 {
 			iommus = <&smmu_niso0 TEGRA234_SID_MGBE_VF1>;
 			power-domains = <&bpmp TEGRA234_POWER_DOMAIN_MGBEB>;
 			status = "disabled";
+
+			snps,axi-config = <&mgbe1_axi_setup>;
+
+			mgbe1_axi_setup: stmmac-axi-config {
+				snps,blen = <256 128 64 32>;
+				snps,rd_osr_lmt = <63>;
+				snps,wr_osr_lmt = <63>;
+			};
 		};
 
 		ethernet@6a00000 {
@@ -1529,6 +1545,14 @@ ethernet@6a00000 {
 			iommus = <&smmu_niso0 TEGRA234_SID_MGBE_VF2>;
 			power-domains = <&bpmp TEGRA234_POWER_DOMAIN_MGBEC>;
 			status = "disabled";
+
+			snps,axi-config = <&mgbe2_axi_setup>;
+
+			mgbe2_axi_setup: stmmac-axi-config {
+				snps,blen = <256 128 64 32>;
+				snps,rd_osr_lmt = <63>;
+				snps,wr_osr_lmt = <63>;
+			};
 		};
 
 		ethernet@6b00000 {
Signature · 1 line
2.43.2
maintainer Reviewed-by Tested-by on v1 1/1
#1 lore raw
Quoted 51 lines · Thierry Reding

From: Thierry Reding <[email protected]>

The MGBE devices found on Tegra234 need their AXI interface configured to operate at peak performance. Ideally we would do this in the driver based off the compatible string, but the DT bindings already specify a separate mechanism, so reuse that.

---
  arch/arm64/boot/dts/nvidia/tegra234.dtsi | 24 ++++++++++++++++++++++++
  1 file changed, 24 insertions(+)
arch/arm64/boot/dts/nvidia/tegra234.dtsi +17 -0
index 3f16595d099c..84c74155a5ca 100644
@@ -1461,6 +1461,14 @@ ethernet@6800000 {
  			iommus = <&smmu_niso0 TEGRA234_SID_MGBE>;
  			power-domains = <&bpmp TEGRA234_POWER_DOMAIN_MGBEA>;
  			status = "disabled";
+
+			snps,axi-config = <&mgbe0_axi_setup>;
+
+			mgbe0_axi_setup: stmmac-axi-config {
+				snps,blen = <256 128 64 32>;
+				snps,rd_osr_lmt = <63>;
+				snps,wr_osr_lmt = <63>;
+			};
  		};
 
  		ethernet@6900000 {
@@ -1495,6 +1503,14 @@ ethernet@6900000 {
  			iommus = <&smmu_niso0 TEGRA234_SID_MGBE_VF1>;
  			power-domains = <&bpmp TEGRA234_POWER_DOMAIN_MGBEB>;
  			status = "disabled";
+
+			snps,axi-config = <&mgbe1_axi_setup>;
+
+			mgbe1_axi_setup: stmmac-axi-config {
+				snps,blen = <256 128 64 32>;
+				snps,rd_osr_lmt = <63>;
+				snps,wr_osr_lmt = <63>;
+			};
  		};
 
  		ethernet@6a00000 {
@@ -1529,6 +1545,14 @@ ethernet@6a00000 {
  			iommus = <&smmu_niso0 TEGRA234_SID_MGBE_VF2>;
  			power-domains = <&bpmp TEGRA234_POWER_DOMAIN_MGBEC>;
  			status = "disabled";
+

arch/arm64/boot/dts/nvidia/tegra234.dtsi ethernet@6a00000 { · line 1558

Quoted 10 lines
arch/arm64/boot/dts/nvidia/tegra234.dtsi +7 -0
+			snps,axi-config = <&mgbe2_axi_setup>;
+
+			mgbe2_axi_setup: stmmac-axi-config {
+				snps,blen = <256 128 64 32>;
+				snps,rd_osr_lmt = <63>;
+				snps,wr_osr_lmt = <63>;
+			};
  		};
 
  		ethernet@6b00000 {

Fixes the speed for me! Thanks!

Jon

Signature · 1 line
nvpublic