Skip to contentSkip to conversation

i2c: i801: Add lis3lv02d for Dell Precision M6800 v2 Bios: A26

PATCH Superseded Patrick Höhn 2 participants 3 messages Feb 22, 2024 – Feb 28, 2024

Subsystems (2)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 i2c: i801: Add lis3lv02d for Dell Precision M6800 v2 Bios: A26

---
 drivers/i2c/busses/i2c-i801.c | 1 +
 1 file changed, 1 insertion(+)
drivers/i2c/busses/i2c-i801.c +1 -0
index 2c36b36d7d51..c1fee2c61da1 100644
@@ -1231,6 +1231,7 @@ static const struct {
 	 */
 	{ "Latitude 5480",      0x29 },
 	{ "Precision 3540",     0x29 },
+	{ "Precision M6800",    0x29 },
 	{ "Vostro V131",        0x1d },
 	{ "Vostro 5568",        0x29 },
 	{ "XPS 15 7590",        0x29 },

--
2.43.0

maintainer
#1 lore raw

Hi Patrick,

Quoted 1 line · Patrick Höhn

I see that you've fixed almost everything that Paul has suggested, but please elaborate a bit more in the git commit.

Spend some time adding a description. If you want, you can reply to this email with the commit log you have in mind, and I can add it for you, or you can send a v3.

Thank you, Paul, for your excellent review.

Andi

PS: A small nitpick: there's no need to add 'v2' in the title.
'[PATCH v2]' is sufficient.

Quoted 19 lines
---
 drivers/i2c/busses/i2c-i801.c | 1 +
 1 file changed, 1 insertion(+)
drivers/i2c/busses/i2c-i801.c +1 -1
index 2c36b36d7d51..c1fee2c61da1 100644
@@ -1231,6 +1231,7 @@ static const struct {
 	 */
 	{ "Latitude 5480",      0x29 },
 	{ "Precision 3540",     0x29 },
+	{ "Precision M6800",    0x29 },
 	{ "Vostro V131",        0x1d },
 	{ "Vostro 5568",        0x29 },
 	{ "XPS 15 7590",        0x29 },
--

2.43.0

#2 lore raw

Hi Andi,

sorry for the late response. Since it is the first time I am contributing, please excuse me, if my description still needs improvement. I can simply describe what I did:

similiarly to what Paul did before, I identified that the M6800 has the accelerometer installed and verified its address using my running Gentoo System. Then I was applying the patch to latest kernel and confirmed that it was booting successfully and the message about a successful detection was present.

Is this along the lines you expect?

Best Regards,
Patrick
Den 2024-02-22 kl. 23:24, skrev Andi Shyti:

Quoted 38 lines

Hi Patrick,

Quoted 1 line · Patrick Höhn

I see that you've fixed almost everything that Paul has suggested, but please elaborate a bit more in the git commit.

Spend some time adding a description. If you want, you can reply to this email with the commit log you have in mind, and I can add it for you, or you can send a v3.

Thank you, Paul, for your excellent review.

Andi

PS: A small nitpick: there's no need to add 'v2' in the title.
'[PATCH v2]' is sufficient.

Quoted 19 lines
---
  drivers/i2c/busses/i2c-i801.c | 1 +
  1 file changed, 1 insertion(+)
drivers/i2c/busses/i2c-i801.c +1 -1
index 2c36b36d7d51..c1fee2c61da1 100644
@@ -1231,6 +1231,7 @@ static const struct {
  	 */
  	{ "Latitude 5480",      0x29 },
  	{ "Precision 3540",     0x29 },
+	{ "Precision M6800",    0x29 },
  	{ "Vostro V131",        0x1d },
  	{ "Vostro 5568",        0x29 },
  	{ "XPS 15 7590",        0x29 },
--

2.43.0