9p: remove SLAB_MEM_SPREAD flag usage
Subsystems (2)
PATCH 1/1 9p: remove SLAB_MEM_SPREAD flag usage
From: Chengming Zhou <[email protected]>
The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove its usage so we can delete it from slab. No functional change.
--- fs/9p/v9fs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/9p/v9fs.c +1 -1
@@ -637,7 +637,7 @@ static int v9fs_init_inode_cache(void) v9fs_inode_cache =kmem_cache_create ("v9fs_inode_cache" ,sizeof (struct v9fs_inode ),0 , (SLAB_RECLAIM_ACCOUNT | -SLAB_MEM_SPREAD |SLAB_ACCOUNT ), +SLAB_ACCOUNT ), v9fs_inode_init_once);if (!v9fs_inode_cache)return -ENOMEM ;
Signature · 1 line
2.40.1
Quoted 4 lines · On 2024/2/24 21:46, [email protected] wrote:
From: Chengming Zhou <[email protected]>
The
SLAB_MEM_SPREADflag is already a no-op as of 6.8-rc1, remove its usage so we can delete it from slab. No functional change.
Update changelog to make it clearer:
The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was removed as of v6.8-rc1, so it became a dead flag since the commit 16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h"). And the series[1] went on to mark it obsolete to avoid confusion for users. Here we can just remove all its users, which has no functional change.
[1] https://lore.kernel.org/all/[email protected]/
Thanks!
Quoted 19 lines
Signed-off-by Chengming Zhou <[email protected]>--- fs/9p/v9fs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)fs/9p/v9fs.c +1
-1@@ -637,7 +637,7 @@ static int v9fs_init_inode_cache(void) v9fs_inode_cache =kmem_cache_create ("v9fs_inode_cache" ,sizeof (struct v9fs_inode ),0 , (SLAB_RECLAIM_ACCOUNT | -SLAB_MEM_SPREAD |SLAB_ACCOUNT ), +SLAB_ACCOUNT ), v9fs_inode_init_once);if (!v9fs_inode_cache)return -ENOMEM ;
[email protected]
maintainerChengming Zhou wrote on Mon, Feb 26, 2024 at 10:51:00AM +0800:
Quoted 8 lines · On 2024/2/24 21:46, [email protected] wrote:
Quoted 4 lines
From: Chengming Zhou <[email protected]>
The
SLAB_MEM_SPREADflag is already a no-op as of 6.8-rc1, remove its usage so we can delete it from slab. No functional change.Update changelog to make it clearer:
Quoted 7 lines
The
SLAB_MEM_SPREADflag used to be implemented in SLAB, which was removed as of v6.8-rc1, so it became a dead flag since the commit16a1d968358a("mm/slab: removemm/slab.candslab_def.h"). And the series[1] went on to mark it obsolete to avoid confusion for users. Here we can just remove all its users, which has no functional change.
Thanks for the updated text, this is a bit better.
I've updated your commit message with this and will push to Linus next merge window in a couple of weeks, as you said there's no change so no reason to submit a patch this late in the cycle.
Signature · 1 line
Dominique Martinet | Asmadeus