Skip to contentSkip to conversation

freevxfs: remove SLAB_MEM_SPREAD flag usage

PATCH In review [email protected] 3 participants 5 messages Feb 24, 2024 – Feb 26, 2024 Memory management

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 freevxfs: remove SLAB_MEM_SPREAD flag usage

From: Chengming Zhou <[email protected]>

The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove its usage so we can delete it from slab. No functional change.

---
 fs/freevxfs/vxfs_super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/freevxfs/vxfs_super.c +1 -1
index e6e2a2185e7c..42e03b6b1cc7 100644
@@ -307,7 +307,7 @@ vxfs_init(void)
 
 	vxfs_inode_cachep = kmem_cache_create_usercopy("vxfs_inode",
 			sizeof(struct vxfs_inode_info), 0,
-			SLAB_RECLAIM_ACCOUNT|SLAB_MEM_SPREAD,
+			SLAB_RECLAIM_ACCOUNT,
 			offsetof(struct vxfs_inode_info, vii_immed.vi_immed),
 			sizeof_field(struct vxfs_inode_info,
 				vii_immed.vi_immed),
Signature · 1 line
2.40.1
#1 lore raw

Please just do a scripted removal after next -rc1 instead of spamming everyone..

#2 lore raw
Quoted 3 lines · Christoph Hellwig

Please just do a scripted removal after next -rc1 instead of spamming everyone..

Do you mean put all diffs into a single patch, send it to all people? That is also a choice if it's preferable. Should it will go through the slab tree then?

Thanks.

#3 lore raw
Quoted 7 lines · Chengming Zhou
Quoted 3 lines · Christoph Hellwig

Please just do a scripted removal after next -rc1 instead of spamming everyone..

Do you mean put all diffs into a single patch, send it to all people? That is also a choice if it's preferable. Should it will go through the slab tree then?

In case that's what Christoph means, we should exclude from that those subsystems that already took your patches.

Quoted 1 line

Thanks.

#4 lore raw
In reply to Chengming Zhou
Quoted 7 lines · Chengming Zhou
Quoted 3 lines · Christoph Hellwig

Please just do a scripted removal after next -rc1 instead of spamming everyone..

Do you mean put all diffs into a single patch, send it to all people? That is also a choice if it's preferable. Should it will go through the slab tree then?

Yes, send a scripted removal of what is left after6.9 -rc1 either to the slab maintainers or directly to Linus with the slab maintainers ACK.