Skip to contentSkip to conversation

jffs2: remove SLAB_MEM_SPREAD flag usage

PATCH In review [email protected] 2 participants 3 messages Feb 24, 2024 – Feb 26, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 jffs2: remove SLAB_MEM_SPREAD flag usage

From: Chengming Zhou <[email protected]>

The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove its usage so we can delete it from slab. No functional change.

---
 fs/jffs2/super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/jffs2/super.c +1 -1
index f99591a634b4..aede1be4dc0c 100644
@@ -387,7 +387,7 @@ static int __init init_jffs2_fs(void)
 	jffs2_inode_cachep = kmem_cache_create("jffs2_i",
 					     sizeof(struct jffs2_inode_info),
 					     0, (SLAB_RECLAIM_ACCOUNT|
-						SLAB_MEM_SPREAD|SLAB_ACCOUNT),
+						SLAB_ACCOUNT),
 					     jffs2_i_init_once);
 	if (!jffs2_inode_cachep) {
 		pr_err("error: Failed to initialise inode cache\n");
Signature · 1 line
2.40.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · 在 2024/2/24 21:49, [email protected] 写道:

From: Chengming Zhou <[email protected]>

The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove its usage so we can delete it from slab. No functional change.

---
  fs/jffs2/super.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 15 lines
fs/jffs2/super.c +1 -1
index f99591a634b4..aede1be4dc0c 100644
@@ -387,7 +387,7 @@ static int __init init_jffs2_fs(void)
  	jffs2_inode_cachep = kmem_cache_create("jffs2_i",
  					     sizeof(struct jffs2_inode_info),
  					     0, (SLAB_RECLAIM_ACCOUNT|
-						SLAB_MEM_SPREAD|SLAB_ACCOUNT),
+						SLAB_ACCOUNT),
  					     jffs2_i_init_once);
  	if (!jffs2_inode_cachep) {
  		pr_err("error: Failed to initialise inode cache\n");
#2 lore raw
In reply to [email protected]
Quoted 4 lines · On 2024/2/24 21:49, [email protected] wrote:

From: Chengming Zhou <[email protected]>

The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove its usage so we can delete it from slab. No functional change.

Update changelog to make it clearer:

The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was removed as of v6.8-rc1, so it became a dead flag. And the series[1] went on to mark it obsolete to avoid confusion for users. Here we can just remove all its users, which has no functional change.

[1] https://lore.kernel.org/all/[email protected]/

Thanks!

Quoted 19 lines
---
 fs/jffs2/super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/jffs2/super.c +1 -1
index f99591a634b4..aede1be4dc0c 100644
@@ -387,7 +387,7 @@ static int __init init_jffs2_fs(void)
 	jffs2_inode_cachep = kmem_cache_create("jffs2_i",
 					     sizeof(struct jffs2_inode_info),
 					     0, (SLAB_RECLAIM_ACCOUNT|
-						SLAB_MEM_SPREAD|SLAB_ACCOUNT),
+						SLAB_ACCOUNT),
 					     jffs2_i_init_once);
 	if (!jffs2_inode_cachep) {
 		pr_err("error: Failed to initialise inode cache\n");