MAINTAINERS: Update W's for KEYS/KEYRINGS_INTEGRITY and TPM DEVICE RIVER

PATCH Superseded Jarkko Sakkinen 3 participants 8 messages Feb 26, 2024 – Mar 19, 2024 Keys-trusted

lore

Share & tools

lore

Jarkko Sakkinen

author maintainer

2024-02-26 06:22 UTC #0 lore raw

PATCH 1/1 MAINTAINERS: Update W's for KEYS/KEYRINGS_INTEGRITY and TPM DEVICE RIVER

Add TPM driver test suite URL to the MAINTAINERS files and move the wiki URL to more appropriate location.

Link https://gitlab.com/jarkkojs/linux-tpmdd-test

Link https://kernsec.org/wiki/index.php/Linux_Kernel_Integrity

Cc Jason Gunthorpe <[email protected]>

Cc Mimi Zohar <[email protected]>

Cc Peter Huewe <[email protected]>

Cc [email protected]

Signed-off-by Jarkko Sakkinen <[email protected]>

---
 MAINTAINERS | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

MAINTAINERS +2 -1

index bf77be03fb2b..6380c1109b86 100644
@@ -11947,6 +11947,7 @@ M:	Mimi Zohar <[email protected]>
 L:	[email protected]
 L:	[email protected]
 S:	Supported
+W:	https://kernsec.org/wiki/index.php/inux_Kernel_Integrity
 F:	security/integrity/platform_certs
 
 KFENCE

@@ -22278,7 +22279,7 @@ M:	Jarkko Sakkinen <[email protected]>
 R:	Jason Gunthorpe <[email protected]>
 L:	[email protected]
 S:	Maintained
-W:	https://kernsec.org/wiki/index.php/Linux_Kernel_Integrity
+W:	https://gitlab.com/jarkkojs/linux-tpmdd-test
 Q:	https://patchwork.kernel.org/project/linux-integrity/list/
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git
 F:	drivers/char/tpm/

Signature · 1 line

2.40.1

Paul Menzel

Acked-by on v1 1/1

2024-02-26 06:36 UTC #1 lore raw

Dear Jarkko,

Thank you for your patch. Two nits:

s/RIVER/DRIVER/

Am 26.02.24 um 07:22 schrieb Jarkko Sakkinen:

Quoted 1 line

Add TPM driver test suite URL to the MAINTAINERS files and move the wiki

s/files/file/

Quoted 1 line

URL to more appropriate location.

(Two commits would make the commit message shorter.)

Quoted 24 lines

Link https://gitlab.com/jarkkojs/linux-tpmdd-test
Link https://kernsec.org/wiki/index.php/Linux_Kernel_Integrity
Cc Jason Gunthorpe <[email protected]>
Cc Mimi Zohar <[email protected]>
Cc Peter Huewe <[email protected]>
Cc [email protected]
Signed-off-by Jarkko Sakkinen <[email protected]>
---
  MAINTAINERS | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
MAINTAINERS +1 -0
index bf77be03fb2b..6380c1109b86 100644
@@ -11947,6 +11947,7 @@ M:	Mimi Zohar <[email protected]>
  L:	[email protected]
  L:	[email protected]
  S:	Supported
+W:	https://kernsec.org/wiki/index.php/inux_Kernel_Integrity
  F:	security/integrity/platform_certs
 
  KFENCE

MAINTAINERS M: Jarkko Sakkinen <[email protected]> · line 22285

Quoted 8 lines

MAINTAINERS +1 -1

@@ -22278,7 +22279,7 @@ M:	Jarkko Sakkinen <[email protected]>
  R:	Jason Gunthorpe <[email protected]>
  L:	[email protected]
  S:	Maintained
-W:	https://kernsec.org/wiki/index.php/Linux_Kernel_Integrity
+W:	https://gitlab.com/jarkkojs/linux-tpmdd-test
  Q:	https://patchwork.kernel.org/project/linux-integrity/list/
  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git
  F:	drivers/char/tpm/

Acked-by Paul Menzel <[email protected]>

Kind regards,

Paul

Jarkko Sakkinen

author maintainer

2024-02-26 09:20 UTC #2 lore raw

Quoted 6 lines · Paul Menzel

Dear Jarkko,
Thank you for your patch. Two nits:
s/RIVER/DRIVER/

lol, thanks for picking up this ;-)

Quoted 9 lines

Am 26.02.24 um 07:22 schrieb Jarkko Sakkinen:
Quoted 1 line
Add TPM driver test suite URL to the MAINTAINERS files and move the wiki
s/files/file/
Quoted 1 line
URL to more appropriate location.
(Two commits would make the commit message shorter.)

I think I just remove link-tags as there is not much else than the links in the actual change (trivial to pick them up from there).

BR, Jarkko

Jarkko Sakkinen

author maintainer

2024-02-26 09:26 UTC #4 lore raw

Quoted 28 lines · James Bottomley

Quoted 20 lines · Jarkko Sakkinen
Add TPM driver test suite URL to the MAINTAINERS files and move the wiki
URL to more appropriate location.
Link https://gitlab.com/jarkkojs/linux-tpmdd-test
Link https://kernsec.org/wiki/index.php/Linux_Kernel_Integrity
Cc Jason Gunthorpe <[email protected]>
Cc Mimi Zohar <[email protected]>
Cc Peter Huewe <[email protected]>
Cc [email protected]
Signed-off-by Jarkko Sakkinen <[email protected]>
---
MAINTAINERS | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
MAINTAINERS +0 -0
index bf77be03fb2b..6380c1109b86 100644
@@ -11947,6 +11947,7 @@ M:      Mimi Zohar <[email protected]>
Quoted 4 lines
L:     [email protected]
L:     [email protected]
S:     Supported
+W:     https://kernsec.org/wiki/index.php/inux_Kernel_Integrity
                                             ^
                                         Missing L

Quoted 1 line

James

Thanks! I'll fixup that.

"linux-tpmdd-test" is the suite that I'm using to test your patch set. It has swtpm integrated. I wonder if there was easy to way to tweak swtpm to emulate "interposer", i.e. reset its state while it is running (preferably not by restarting it).

BR, Jarkko

James Bottomley

maintainer

2024-02-26 10:11 UTC #5 lore raw

Quoted 30 lines · Jarkko Sakkinen

Quoted 29 lines · James Bottomley
Quoted 21 lines · Jarkko Sakkinen
Add TPM driver test suite URL to the MAINTAINERS files and move the
wiki
URL to more appropriate location.
Link https://gitlab.com/jarkkojs/linux-tpmdd-test
Link https://kernsec.org/wiki/index.php/Linux_Kernel_Integrity
Cc Jason Gunthorpe <[email protected]>
Cc Mimi Zohar <[email protected]>
Cc Peter Huewe <[email protected]>
Cc [email protected]
Signed-off-by Jarkko Sakkinen <[email protected]>
---
MAINTAINERS | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
MAINTAINERS +0 -0
index bf77be03fb2b..6380c1109b86 100644
@@ -11947,6 +11947,7 @@ M:      Mimi Zohar <[email protected]>
Quoted 4 lines
L:     [email protected]
L:     [email protected]
S:     Supported
+W:     https://kernsec.org/wiki/index.php/inux_Kernel_Integrity
                                             ^ Missing L

Quoted 8 lines

Quoted 1 line
James
Thanks! I'll fixup that.
"linux-tpmdd-test" is the suite that I'm using to test your patch set. It has swtpm integrated. I wonder if there was easy to way to tweak swtpm to emulate "interposer", i.e. reset its state while it is running (preferably not by restarting it).

The way I do it is to use a qemu patch

https://lore.kernel.org/qemu-devel/[email protected]/

which allows qemu to connect to the mssim (or ibmswtpm2) TPM over an inet socket which means I can execute TPM commands from the host (like resetting the TPM) as well as the guest and snoop the TPM traffic.

James

Jarkko Sakkinen

author maintainer

2024-02-27 18:22 UTC #6 lore raw

Quoted 40 lines · James Bottomley

Quoted 30 lines · Jarkko Sakkinen
Quoted 29 lines · James Bottomley
Quoted 21 lines · Jarkko Sakkinen
Add TPM driver test suite URL to the MAINTAINERS files and move the
wiki
URL to more appropriate location.
Link https://gitlab.com/jarkkojs/linux-tpmdd-test
Link https://kernsec.org/wiki/index.php/Linux_Kernel_Integrity
Cc Jason Gunthorpe <[email protected]>
Cc Mimi Zohar <[email protected]>
Cc Peter Huewe <[email protected]>
Cc [email protected]
Signed-off-by Jarkko Sakkinen <[email protected]>
---
MAINTAINERS | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
MAINTAINERS +0 -0
index bf77be03fb2b..6380c1109b86 100644
@@ -11947,6 +11947,7 @@ M:      Mimi Zohar <[email protected]>
Quoted 4 lines
L:     [email protected]
L:     [email protected]
S:     Supported
+W:     https://kernsec.org/wiki/index.php/inux_Kernel_Integrity
                                             ^ Missing L
Quoted 8 lines
Quoted 1 line
James
Thanks! I'll fixup that.
"linux-tpmdd-test" is the suite that I'm using to test your patch set. It has swtpm integrated. I wonder if there was easy to way to tweak swtpm to emulate "interposer", i.e. reset its state while it is running (preferably not by restarting it).

Quoted 7 lines

The way I do it is to use a qemu patch
https://lore.kernel.org/qemu-devel/[email protected]/
which allows qemu to connect to the mssim (or ibmswtpm2) TPM over an inet socket which means I can execute TPM commands from the host (like resetting the TPM) as well as the guest and snoop the TPM traffic.

To which exact and most recent possible QEMU version I can apply that cleanly?

My build configuration builds both QEMU and swtpm [1] for every build so I could pick that patch, copy it to board/qemu/patches/qemu, and set the version in the BuildRoot configuration appropriately.

[1]
https://gitlab.com/jarkkojs/linux-tpmdd-test/-/tree/main/package/libtpms
https://gitlab.com/jarkkojs/linux-tpmdd-test/-/tree/main/package/swtpm

BR, Jarkko

Jarkko Sakkinen

author maintainer

2024-03-19 20:43 UTC #7 lore raw

Quoted 52 lines · Jarkko Sakkinen

Quoted 40 lines · James Bottomley
Quoted 30 lines · Jarkko Sakkinen
Quoted 29 lines · James Bottomley
Quoted 21 lines · Jarkko Sakkinen
Add TPM driver test suite URL to the MAINTAINERS files and move the
wiki
URL to more appropriate location.
Link https://gitlab.com/jarkkojs/linux-tpmdd-test
Link https://kernsec.org/wiki/index.php/Linux_Kernel_Integrity
Cc Jason Gunthorpe <[email protected]>
Cc Mimi Zohar <[email protected]>
Cc Peter Huewe <[email protected]>
Cc [email protected]
Signed-off-by Jarkko Sakkinen <[email protected]>
---
MAINTAINERS | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
MAINTAINERS +0 -0
index bf77be03fb2b..6380c1109b86 100644
@@ -11947,6 +11947,7 @@ M:      Mimi Zohar <[email protected]>
Quoted 4 lines
L:     [email protected]
L:     [email protected]
S:     Supported
+W:     https://kernsec.org/wiki/index.php/inux_Kernel_Integrity
                                             ^ Missing L
Quoted 8 lines
Quoted 1 line
James
Thanks! I'll fixup that.
"linux-tpmdd-test" is the suite that I'm using to test your patch set. It has swtpm integrated. I wonder if there was easy to way to tweak swtpm to emulate "interposer", i.e. reset its state while it is running (preferably not by restarting it).
Quoted 7 lines
The way I do it is to use a qemu patch
https://lore.kernel.org/qemu-devel/[email protected]/
which allows qemu to connect to the mssim (or ibmswtpm2) TPM over an inet socket which means I can execute TPM commands from the host (like resetting the TPM) as well as the guest and snoop the TPM traffic.
To which exact and most recent possible QEMU version I can apply that cleanly?

Quoted 7 lines

My build configuration builds both QEMU and swtpm [1] for every build so I could pick that patch, copy it to board/qemu/patches/qemu, and set the version in the BuildRoot configuration appropriately.
[1]
https://gitlab.com/jarkkojs/linux-tpmdd-test/-/tree/main/package/libtpms
https://gitlab.com/jarkkojs/linux-tpmdd-test/-/tree/main/package/swtpm

Friendly ping. Still looking forward to test.

I cannot recall exact review comments for v7 but what I can recall is that they were cosmetic.

BR, Jarkko