mtd: spi-nor: Add Puya Semiconductor chips driver
Subsystems (2)
PATCH 1/1 mtd: spi-nor: Add Puya Semiconductor chips driver
Add a SPI NOR manufacturer driver for Puya Semiconductor chips
--- drivers/mtd/spi-nor/Makefile | 1 + drivers/mtd/spi-nor/puya.c | 64 ++++++++++++++++++++++++++++++++++++ 2 files changed, 65 insertions(+) create mode 100644 drivers/mtd/spi-nor/puya.c
drivers/mtd/spi-nor/Makefile +1 -0
@@ -10,6 +10,7 @@ spi-nor-objs += intel.o spi-nor-objs += issi.o spi-nor-objs += macronix.o spi-nor-objs += micron-st.o +spi-nor-objs += puya.o spi-nor-objs += spansion.o spi-nor-objs += sst.o spi-nor-objs += winbond.o
drivers/mtd/spi-nor/puya.c new file +64 -0
64 lines not on this page · raw message
Signature · 6 lines
2.34.1 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
Hi,
Please read the review feedback from
https://lore.kernel.org/linux-mtd/[email protected]/T/#mbcfaac90f123410a35db7dbeb0464dcb0816e7c7,
it applies to this patch as well.
PATCH v2 1/1 mtd: spi-nor: Add Puya Semiconductor chips driver
Add a SPI NOR manufacturer driver for Puya Semiconductor chips
--- drivers/mtd/spi-nor/Makefile | 1 + drivers/mtd/spi-nor/core.c | 1 + drivers/mtd/spi-nor/core.h | 1 + drivers/mtd/spi-nor/puya.c | 64 ++++++++++++++++++++++++++++++++++++ 4 files changed, 67 insertions(+) create mode 100644 drivers/mtd/spi-nor/puya.c
drivers/mtd/spi-nor/Makefile +1 -0
@@ -10,6 +10,7 @@ spi-nor-objs += intel.o spi-nor-objs += issi.o spi-nor-objs += macronix.o spi-nor-objs += micron-st.o +spi-nor-objs += puya.o spi-nor-objs += spansion.o spi-nor-objs += sst.o spi-nor-objs += winbond.o
drivers/mtd/spi-nor/core.c +1 -0
@@ -2045,6 +2045,7 @@ static const struct spi_nor_manufacturer *manufacturers[] = { &spi_nor_issi, &spi_nor_macronix, &spi_nor_micron, + &spi_nor_puya, &spi_nor_st, &spi_nor_spansion, &spi_nor_sst,
drivers/mtd/spi-nor/core.h +1 -0
@@ -609,6 +609,7 @@ extern const struct spi_nor_manufacturer spi_nor_intel;extern const struct spi_nor_manufacturer spi_nor_issi;extern const struct spi_nor_manufacturer spi_nor_macronix;extern const struct spi_nor_manufacturer spi_nor_micron; +extern const struct spi_nor_manufacturer spi_nor_puya;extern const struct spi_nor_manufacturer spi_nor_st;extern const struct spi_nor_manufacturer spi_nor_spansion;extern const struct spi_nor_manufacturer spi_nor_sst;
drivers/mtd/spi-nor/puya.c new file +64 -0
64 lines not on this page · raw message
Signature · 1 line
2.34.1
Quoted 10 lines · Dmitry Dunaev
Add a SPI NOR manufacturer driver for Puya Semiconductor chips
Signed-off-by Dmitry Dunaev <[email protected]>--- drivers/mtd/spi-nor/Makefile | 1 + drivers/mtd/spi-nor/core.c | 1 + drivers/mtd/spi-nor/core.h | 1 + drivers/mtd/spi-nor/puya.c | 64 ++++++++++++++++++++++++++++++++++++ 4 files changed, 67 insertions(+) create mode 100644 drivers/mtd/spi-nor/puya.c
what changed in v2? why do you need these entries? Can you rely instead on SFDP to initialize these flashes?
Please read: https://docs.kernel.org/driver-api/mtd/spi-nor.html
A message that is not in the archive (sent off-list or not yet received): ZdxxZb+fbzXv7ZNk@tm38l
+ linux-mtd
Please do not send private emails on matters that are not private.
Quoted 15 lines · Dmitry Dunaev
Quoted 14 lines · Tudor Ambarus
Quoted 10 lines · Dmitry Dunaev
Add a SPI NOR manufacturer driver for Puya Semiconductor chips
Signed-off-by Dmitry Dunaev <[email protected]>--- drivers/mtd/spi-nor/Makefile | 1 + drivers/mtd/spi-nor/core.c | 1 + drivers/mtd/spi-nor/core.h | 1 + drivers/mtd/spi-nor/puya.c | 64 ++++++++++++++++++++++++++++++++++++ 4 files changed, 67 insertions(+) create mode 100644 drivers/mtd/spi-nor/puya.c
Quoted 6 lines
Quoted 2 lines
what changed in v2? why do you need these entries? Can you rely instead on SFDP to initialize these flashes?
In first patch I missed core.{c,h} with Puya flashes structures.
And about SFDP on Puya flashes. We try to call DP command on p25q16uc
what's DP command? SFDP read?
Quoted 4 lines
flash and got no answer. It may be a bad chip pack or other matter but now we need a manual description for this chips.
If this issue occured only in my case we can skip this patch.
It's first time I hear about puya semiconductor. Please follow the documentation that I've sent in the previous email and dump all the required data.
Cheers,
ta
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Quoted 20 lines · Tudor Ambarus
+ linux-mtd
Please do not send private emails on matters that are not private.
Quoted 15 lines · Dmitry Dunaev
Quoted 14 lines · Tudor Ambarus
Quoted 10 lines · Dmitry Dunaev
Add a SPI NOR manufacturer driver for Puya Semiconductor chips
Signed-off-by Dmitry Dunaev <[email protected]>--- drivers/mtd/spi-nor/Makefile | 1 + drivers/mtd/spi-nor/core.c | 1 + drivers/mtd/spi-nor/core.h | 1 + drivers/mtd/spi-nor/puya.c | 64 ++++++++++++++++++++++++++++++++++++ 4 files changed, 67 insertions(+) create mode 100644 drivers/mtd/spi-nor/puya.c
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines
what changed in v2? why do you need these entries? Can you rely instead on SFDP to initialize these flashes?
In first patch I missed core.{c,h} with Puya flashes structures.
And about SFDP on Puya flashes. We try to call DP command on p25q16uc
what's DP command? SFDP read?
Yes, SFDP (0x5A)
Quoted 9 lines
Quoted 5 lines
flash and got no answer. It may be a bad chip pack or other matter but now we need a manual description for this chips.
If this issue occured only in my case we can skip this patch.
It's first time I hear about puya semiconductor. Please follow the documentation that I've sent in the previous email and dump all the required data.
I can't send sfdp data block because I can't get it from my Puya chips.
The datasheets for Puya chips can be found at it's original site https://www.puyasemi.com/h_xilie715.html
but at now there is an error to access to any pdf files on this site. The saved datasheets can be downloaded from sellers, for example https://datasheet.lcsc.com/lcsc/2304140030_PUYA--P25Q16H-SUH-IR_C559219.pdf
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/