Skip to contentSkip to conversation

xfs: Remove duplicate include

PATCH Superseded Jiapeng Chong 2 participants 4 messages Feb 28, 2024 XFS filesystem

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 xfs: Remove duplicate include

./fs/xfs/xfs_qm_bhv.c: xfs_mount.h is included more than once.

---
 fs/xfs/xfs_qm_bhv.c | 1 -
 1 file changed, 1 deletion(-)
fs/xfs/xfs_qm_bhv.c +0 -1
index 271c1021c733..a11436579877 100644
@@ -11,7 +11,6 @@
 #include "xfs_trans_resv.h"
 #include "xfs_mount.h"
 #include "xfs_quota.h"
-#include "xfs_mount.h"
 #include "xfs_inode.h"
 #include "xfs_trans.h"
 #include "xfs_qm.h"
Signature · 1 line
2.20.1.7.g153144c
#1 lore raw

PATCH 2/2 xfs: Remove duplicate include

./fs/xfs/xfs_trace.c: xfs_bmap.h is included more than once.

---
 fs/xfs/xfs_trace.c | 1 -
 1 file changed, 1 deletion(-)
fs/xfs/xfs_trace.c +0 -1
index 1a963382e5e9..23e906b60f21 100644
@@ -17,7 +17,6 @@
 #include "xfs_btree.h"
 #include "xfs_da_btree.h"
 #include "xfs_alloc.h"
-#include "xfs_bmap.h"
 #include "xfs_attr.h"
 #include "xfs_trans.h"
 #include "xfs_log.h"
Signature · 1 line
2.20.1.7.g153144c
#2 lore raw
Quoted 14 lines · Jiapeng Chong

./fs/xfs/xfs_trace.c: xfs_bmap.h is included more than once.

---
 fs/xfs/xfs_trace.c | 1 -
 1 file changed, 1 deletion(-)
fs/xfs/xfs_trace.c +0 -0
index 1a963382e5e9..23e906b60f21 100644

fs/xfs/xfs_trace.c line 20

Quoted 4 lines
fs/xfs/xfs_trace.c +0 -1
@@ -17,7 +17,6 @@
 #include "xfs_btree.h"
 #include "xfs_da_btree.h"
 #include "xfs_alloc.h"
-#include "xfs_bmap.h"

Shouldn't this remove the second #include?

--D

Quoted 7 lines
fs/xfs/xfs_trace.c +0 -0
 #include "xfs_attr.h"
 #include "xfs_trans.h"
 #include "xfs_log.h"
Signature · 1 line
2.20.1.7.g153144c
Reviewed-by on v1 1/2
#3 lore raw
In reply to Jiapeng Chong
Quoted 5 lines · Jiapeng Chong

./fs/xfs/xfs_qm_bhv.c: xfs_mount.h is included more than once.

Looks good,

--D

Quoted 20 lines
---
 fs/xfs/xfs_qm_bhv.c | 1 -
 1 file changed, 1 deletion(-)
fs/xfs/xfs_qm_bhv.c +0 -1
index 271c1021c733..a11436579877 100644
@@ -11,7 +11,6 @@
 #include "xfs_trans_resv.h"
 #include "xfs_mount.h"
 #include "xfs_quota.h"
-#include "xfs_mount.h"
 #include "xfs_inode.h"
 #include "xfs_trans.h"
 #include "xfs_qm.h"
Signature · 1 line
2.20.1.7.g153144c