Staging: rtl8192e: Sparse warning regarding variable declaration
PATCH 1/1 Staging: rtl8192e: Sparse warning regarding variable declaration
Fixed sparse warning: "'dm_rx_path_sel_table' was not declared. Should it be static?" As dm_rx_path_sel_table is used only in rtl_dm.c it should be static.
--- drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8192e/rtl8192e/rtl_dm.c +1 -1
@@ -144,7 +144,7 @@ const u8 dm_cck_tx_bb_gain_ch14[CCK_TX_BB_GAIN_TABLE_LEN][8] = {/*------------------------Define global variable-----------------------------*/ struct dig_t dm_digtable; -struct drx_path_sel dm_rx_path_sel_table; +static struct drx_path_sel dm_rx_path_sel_table;/*------------------------Define global variable-----------------------------*/
Signature · 1 line
2.25.1
Quoted 3 lines · Ariel Silver
Fixed sparse warning: "'
dm_rx_path_sel_table' was not declared. Should it be static?" Asdm_rx_path_sel_tableis used only inrtl_dm.cit should be static.
Hi Ariel,
please use checkpatch to check your patch:
File Nr: 0 Patch: ../../../Downloads/20240228-[PATCH] Staging_ rtl8192e_ Sparse warning regarding variable declaration-14757.txt
WARNING: A patch subject line should describe the change not the tool that found it #1:
Subject: [PATCH] Staging: rtl8192e: Sparse warning regarding variable declaration
WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?) #7:
Fixed sparse warning: "'dm_rx_path_sel_table' was not declared. Should it be static?"
total: 0 errors, 2 warnings, 0 checks, 8 lines checked
Please make a v2 with change description under the "---"
Thanks for your support.
Bye Philipp