mm/zsmalloc: move get_zspage_lockless into #ifdef
Subsystems (2)
PATCH 1/1 mm/zsmalloc: move get_zspage_lockless into #ifdef
From: Arnd Bergmann <[email protected]>
It's only used from inside of an #ifdef section, causing a warning otherwise:
mm/zsmalloc.c:735:23: error: unused function 'get_zspage_lockless' [-Werror,-Wunused-function]
735 | static struct zspage *get_zspage_lockless(struct page *page)
| ^~~~~~~~~~~~~~~~~~~
Move it down into that block to avoid adding another #ifdef.
--- mm/zsmalloc.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-)
mm/zsmalloc.c +7 -8
@@ -731,14 +731,6 @@ static struct zspage *get_zspage(struct page *page)return zspage; } -/* Only used in zs_page_migrate() to get zspage locklessly. */ -static struct zspage *get_zspage_lockless (struct page *page) -{ -struct zspage __rcu **private = (struct zspage __rcu **)&page->private; - -return rcu_dereference (*private); -} -static struct page *get_next_page (struct page *page) {struct zspage *zspage =get_zspage (page);
@@ -1651,6 +1643,13 @@ static void migrate_write_unlock(struct zspage *zspage) }#ifdef CONFIG_COMPACTION +/* Only used in zs_page_migrate() to get zspage locklessly. */ +static struct zspage *get_zspage_lockless (struct page *page) +{ +struct zspage __rcu **private = (struct zspage __rcu **)&page->private; + +return rcu_dereference (*private); +}static const struct movable_operations zsmalloc_mops;
Signature · 1 line
2.39.2
Quoted 4 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
It's only used from inside of an #ifdef section, causing a warning otherwise:
Quoted 8 lines
mm/zsmalloc.c:735:23: error: unused function 'get_zspage_lockless' [-Werror,-Wunused-function]
735 | static struct zspage *get_zspage_lockless(struct page *page)| ^~~~~~~~~~~~~~~~~~~Move it down into that block to avoid adding another #ifdef.
Fixes 2258bdebb55e ("mm/zsmalloc: don't hold locks of all pages when free_zspage()")Signed-off-by Arnd Bergmann <[email protected]>
Hello Arnd,
Thanks for your fix! But this series has problem and should be removed by Andrew later[1][2].
[1] https://lore.kernel.org/all/[email protected]/
[2] https://lore.kernel.org/all/[email protected]/
Thanks!