vboxsf: remove redundant variable out_len
Subsystems (3)
PATCH 1/1 vboxsf: remove redundant variable out_len
The variable out_len is being used to accumulate the number of bytes but it is not being used for any other purpose. The variable is redundant and can be removed.
Cleans up clang scan build warning:fs/vboxsf/utils.c:443:9: warning: variable 'out_len' set but not used [-Wunused-but-set-variable]
--- fs/vboxsf/utils.c | 3 --- 1 file changed, 3 deletions(-)
fs/vboxsf/utils.c +0 -3
@@ -440,7 +440,6 @@ int vboxsf_nlscpy(struct vboxsf_sbi *sbi, char *name, size_t name_bound_len, {const char *in;char *out; -size_t out_len;size_t out_bound_len;size_t in_bound_len;
@@ -448,7 +447,6 @@ int vboxsf_nlscpy(struct vboxsf_sbi *sbi, char *name, size_t name_bound_len, in_bound_len = utf8_len; out = name; - out_len =0 ;/* Reserve space for terminating 0 */ out_bound_len = name_bound_len -1 ;
@@ -469,7 +467,6 @@ int vboxsf_nlscpy(struct vboxsf_sbi *sbi, char *name, size_t name_bound_len, out += nb; out_bound_len -= nb; - out_len += nb; } *out =0 ;
Signature · 1 line
2.39.2
Hi,
Quoted 9 lines · Colin Ian King
The variable
out_lenis being used to accumulate the number of bytes but it is not being used for any other purpose. The variable is redundant and can be removed.Cleans up clang scan build warning:
fs/vboxsf/utils.c:443:9: warning: variable 'out_len' set but not used [-Wunused-but-set-variable]Signed-off-by Colin Ian King <[email protected]>
Thanks, patch looks good to me:
I have added this to my local vboxsf branch now and I'll send out a pull-request with this and a couple of other vboxsf fixes soon.
Regards,
Hans
Quoted 32 lines
--- fs/vboxsf/utils.c | 3 --- 1 file changed, 3 deletions(-)fs/vboxsf/utils.c +0
-3@@ -440,7 +440,6 @@ int vboxsf_nlscpy(struct vboxsf_sbi *sbi, char *name, size_t name_bound_len, {const char *in;char *out; -size_t out_len;size_t out_bound_len;size_t in_bound_len;@@ -448,7 +447,6 @@ int vboxsf_nlscpy(struct vboxsf_sbi *sbi, char *name, size_t name_bound_len, in_bound_len = utf8_len; out = name; - out_len =0 ;/* Reserve space for terminating 0 */ out_bound_len = name_bound_len -1 ;@@ -469,7 +467,6 @@ int vboxsf_nlscpy(struct vboxsf_sbi *sbi, char *name, size_t name_bound_len, out += nb; out_bound_len -= nb; - out_len += nb; } *out =0 ;