Skip to contentSkip to conversation

Staging: rtl8192e: Declare variable with static

PATCH Superseded Ariel Silver 2 participants 2 messages Mar 1, 2024 – Mar 3, 2024 Staging

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: rtl8192e: Declare variable with static

Fixed sparse warning:
"'dm_rx_path_sel_table' was not declared. Should it be static?" As dm_rx_path_sel_table is used only in rtl_dm.c it should be static.

---
 drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8192e/rtl8192e/rtl_dm.c +1 -1
index 92143c50c149..850ee6ae1f02 100644
@@ -144,7 +144,7 @@ const u8 dm_cck_tx_bb_gain_ch14[CCK_TX_BB_GAIN_TABLE_LEN][8] = {
 /*------------------------Define global variable-----------------------------*/
 struct dig_t dm_digtable;
 
-struct drx_path_sel dm_rx_path_sel_table;
+static struct drx_path_sel dm_rx_path_sel_table;
 /*------------------------Define global variable-----------------------------*/
 
 
Signature · 1 line
2.25.1
#1 lore raw
Quoted 14 lines · Ariel Silver

Fixed sparse warning:
"'dm_rx_path_sel_table' was not declared. Should it be static?" As dm_rx_path_sel_table is used only in rtl_dm.c it should be static.

---
  drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8192e/rtl8192e/rtl_dm.c +0 -0
index 92143c50c149..850ee6ae1f02 100644

drivers/staging/rtl8192e/rtl8192e/rtl_dm.c const u8 dm_cck_tx_bb_gain_ch14[CCK_TX_BB_GAIN_TABLE_LEN][8] = { · line 150

Quoted 8 lines
drivers/staging/rtl8192e/rtl8192e/rtl_dm.c +1 -1
@@ -144,7 +144,7 @@ const u8 dm_cck_tx_bb_gain_ch14[CCK_TX_BB_GAIN_TABLE_LEN][8] = {
  /*------------------------Define global variable-----------------------------*/
  struct dig_t dm_digtable;
 
-struct drx_path_sel dm_rx_path_sel_table;
+static struct drx_path_sel dm_rx_path_sel_table;
  /*------------------------Define global variable-----------------------------*/
 
 

Hi Ariel,

I need to tell you that you need a change history. There is also the v2 missing in the subject. Please make a v3 with change history.

Thanks

Bye Philipp