Skip to contentSkip to conversation

mm, slab: remove memcg_from_slab_obj()

PATCH In review Vlastimil Babka 4 participants 4 messages Mar 1, 2024 – Mar 3, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mm, slab: remove memcg_from_slab_obj()

This empty wrapped exists only for !CONFIG_MEMCG_KMEM and seems it was never used. Probably a leftover from development of a series.

---
 mm/slub.c | 5 -----
 1 file changed, 5 deletions(-)
mm/slub.c +0 -5
index 12066e69688d..186a8ec28228 100644
@@ -2028,11 +2028,6 @@ void memcg_slab_alloc_error_hook(struct kmem_cache *s, int objects,
 		obj_cgroup_uncharge(objcg, objects * obj_full_size(s));
 }
 #else /* CONFIG_MEMCG_KMEM */
-static inline struct mem_cgroup *memcg_from_slab_obj(void *ptr)
-{
-	return NULL;
-}
-
 static inline void memcg_free_slab_cgroups(struct slab *slab)
 {
 }
Signature · 1 line
2.44.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Vlastimil Babka

This empty wrapped exists only for !CONFIG_MEMCG_KMEM and seems it was never used. Probably a leftover from development of a series.

LGTM, thanks!

Quoted 20 lines
---
 mm/slub.c | 5 -----
 1 file changed, 5 deletions(-)
mm/slub.c +0 -5
index 12066e69688d..186a8ec28228 100644
@@ -2028,11 +2028,6 @@ void memcg_slab_alloc_error_hook(struct kmem_cache *s, int objects,
 		obj_cgroup_uncharge(objcg, objects * obj_full_size(s));
 }
 #else /* CONFIG_MEMCG_KMEM */
-static inline struct mem_cgroup *memcg_from_slab_obj(void *ptr)
-{
-	return NULL;
-}
-
 static inline void memcg_free_slab_cgroups(struct slab *slab)
 {
 }