Skip to contentSkip to conversation

pps: use cflags-y instead of EXTRA_CFLAGS

PATCH In review Lukas Bulwahn 2 participants 2 messages Mar 6, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pps: use cflags-y instead of EXTRA_CFLAGS

Commit f77bf01425b1 ("kbuild: introduce ccflags-y, asflags-y and ldflags-y") deprecates use of EXTRA_CFLAGS in the kernel build.

This has been cleaned up in the whole kernel tree long ago, but this one single place must have been missed.

Replace the EXTRA_CFLAGS use by the common pattern for such debug flags. No functional change.

---
Rodolfo, please ack.

Greg, please pick this minor cleanup patch.

 drivers/pps/generators/Makefile | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/pps/generators/Makefile +1 -3
index 2d56dd0495d5..2589fd0f2481 100644
@@ -5,6 +5,4 @@
 
 obj-$(CONFIG_PPS_GENERATOR_PARPORT) += pps_gen_parport.o
 
-ifeq ($(CONFIG_PPS_DEBUG),y)
-EXTRA_CFLAGS += -DDEBUG
-endif
+ccflags-$(CONFIG_PPS_DEBUG) := -DDEBUG
Signature · 1 line
2.43.2
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · Lukas Bulwahn

Commit f77bf01425b1 ("kbuild: introduce ccflags-y, asflags-y and ldflags-y") deprecates use of EXTRA_CFLAGS in the kernel build.

This has been cleaned up in the whole kernel tree long ago, but this one single place must have been missed.

Replace the EXTRA_CFLAGS use by the common pattern for such debug flags. No functional change.

Quoted 20 lines

---
Rodolfo, please ack.

Greg, please pick this minor cleanup patch.

  drivers/pps/generators/Makefile | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)
drivers/pps/generators/Makefile +1 -3
index 2d56dd0495d5..2589fd0f2481 100644
@@ -5,6 +5,4 @@
 
  obj-$(CONFIG_PPS_GENERATOR_PARPORT) += pps_gen_parport.o
 
-ifeq ($(CONFIG_PPS_DEBUG),y)
-EXTRA_CFLAGS += -DDEBUG
-endif
+ccflags-$(CONFIG_PPS_DEBUG) := -DDEBUG
Signature · 4 lines
GNU/Linux Solutions                  e-mail: [email protected]
Linux Device Driver                          [email protected]
Embedded Systems                     phone:  +39 349 2432127
UNIX programming