Skip to contentSkip to conversation

btrfs: clean up some inconsistent indenting

PATCH In review Jiapeng Chong 2 participants 2 messages Mar 7, 2024 Btrfs file system

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 btrfs: clean up some inconsistent indenting

No functional modification involved.

fs/btrfs/volumes.c:770 device_list_add() warn: inconsistent indenting. fs/btrfs/volumes.c:1373 btrfs_scan_one_device() warn: inconsistent indenting.

---
 fs/btrfs/volumes.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
fs/btrfs/volumes.c +4 -3
index a2d07fa3cfdf..caa3e83b0d6c 100644
@@ -767,7 +767,7 @@ static noinline struct btrfs_device *device_list_add(const char *path,
 		if (same_fsid_diff_dev) {
 			generate_random_uuid(fs_devices->fsid);
 			fs_devices->temp_fsid = true;
-		pr_info("BTRFS: device %s (%d:%d) using temp-fsid %pU\n",
+			pr_info("BTRFS: device %s (%d:%d) using temp-fsid %pU\n",
 				path, MAJOR(path_devt), MINOR(path_devt),
 				fs_devices->fsid);
 		}
@@ -1370,8 +1370,9 @@ struct btrfs_device *btrfs_scan_one_device(const char *path, blk_mode_t flags,
 		else
 			btrfs_free_stale_devices(devt, NULL);
 
-	pr_debug("BTRFS: skip registering single non-seed device %s (%d:%d)\n",
-			path, MAJOR(devt), MINOR(devt));
+		pr_debug("BTRFS: skip registering single non-seed device %s (%d:%d)\n",
+			 path, MAJOR(devt), MINOR(devt));
+
 		device = NULL;
 		goto free_disk_super;
 	}
Signature · 1 line
2.20.1.7.g153144c
#1 lore raw
Quoted 8 lines · Jiapeng Chong

No functional modification involved.

fs/btrfs/volumes.c:770 device_list_add() warn: inconsistent indenting. fs/btrfs/volumes.c:1373 btrfs_scan_one_device() warn: inconsistent indenting.

Can the bot be taught to watch the btrfs development branch
(https://github.com/btrfs/linux.git for-next) and send feedback directly to the btrfs mailing list?
So that we can catch the problem immediately before reaching mainline.

I strongly doubt sending out such patches would leave any positive impression on the bot.

Thanks,
Qu

Quoted 29 lines
---
  fs/btrfs/volumes.c | 7 ++++---
  1 file changed, 4 insertions(+), 3 deletions(-)
fs/btrfs/volumes.c +4 -3
index a2d07fa3cfdf..caa3e83b0d6c 100644
@@ -767,7 +767,7 @@ static noinline struct btrfs_device *device_list_add(const char *path,
  		if (same_fsid_diff_dev) {
  			generate_random_uuid(fs_devices->fsid);
  			fs_devices->temp_fsid = true;
-		pr_info("BTRFS: device %s (%d:%d) using temp-fsid %pU\n",
+			pr_info("BTRFS: device %s (%d:%d) using temp-fsid %pU\n",
  				path, MAJOR(path_devt), MINOR(path_devt),
  				fs_devices->fsid);
  		}
@@ -1370,8 +1370,9 @@ struct btrfs_device *btrfs_scan_one_device(const char *path, blk_mode_t flags,
  		else
  			btrfs_free_stale_devices(devt, NULL);
 
-	pr_debug("BTRFS: skip registering single non-seed device %s (%d:%d)\n",
-			path, MAJOR(devt), MINOR(devt));
+		pr_debug("BTRFS: skip registering single non-seed device %s (%d:%d)\n",
+			 path, MAJOR(devt), MINOR(devt));
+
  		device = NULL;
  		goto free_disk_super;
  	}