Skip to contentSkip to conversation

drm/msm: remove unused variable 'out'

PATCH In review Colin Ian King 2 participants 2 messages Mar 7, 2024 – Mar 14, 2024

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/msm: remove unused variable 'out'

The variable out is being initialized and incremented but it is never actually referenced in any other way. The variable is redundant and can be removed.

Cleans up clang scan build warning:
drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:843:6: warning: variable 'out' set but not used [-Wunused-but-set-variable]

---
 drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c +0 -3
index 1f5245fc2cdc..d4e1ebfcb021 100644
@@ -840,7 +840,6 @@ static void a6xx_get_shader_block(struct msm_gpu *gpu,
 		struct a6xx_crashdumper *dumper)
 {
 	u64 *in = dumper->ptr;
-	u64 out = dumper->iova + A6XX_CD_DATA_OFFSET;
 	size_t datasize = block->size * A6XX_NUM_SHADER_BANKS * sizeof(u32);
 	int i;
 
@@ -853,8 +852,6 @@ static void a6xx_get_shader_block(struct msm_gpu *gpu,
 
 		in += CRASHDUMP_READ(in, REG_A6XX_HLSQ_DBG_AHB_READ_APERTURE,
 			block->size, dumper->iova + A6XX_CD_DATA_OFFSET);
-
-		out += block->size * sizeof(u32);
 	}
 
 	CRASHDUMP_FINI(in);
Signature · 1 line
2.39.2
Tested-by on v1 1/1
#1 lore raw

Hi,

Quoted 5 lines · Colin Ian King

The variable out is being initialized and incremented but it is never actually referenced in any other way. The variable is redundant and can be removed.

Quoted 8 lines

Cleans up clang scan build warning:
drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:843:6: warning: variable 'out' set but not used [-Wunused-but-set-variable]

---
 drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c | 3 ---
 1 file changed, 3 deletions(-)