rust: don't select CONSTRUCTORS
Alice Ryhl
reviewerPATCH 1/1 rust: don't select CONSTRUCTORS
This was originally part of commit 4b9a68f2e59a0 ("rust: add support for static synchronisation primitives") from the old Rust branch, which used module constructors to initialize globals containing various synchronisation primitives with pin-init. That commit has never been upstreamed, but the select CONSTRUCTORS statement ended up being included in the patch that initially added Rust support to the Linux Kernel.
We are not using module constructors, so let's remove the select.
--- init/Kconfig | 1 - 1 file changed, 1 deletion(-)
init/Kconfig +0 -1
@@ -1903,21 +1903,20 @@ config RUST config RUST bool "Rust support" depends on HAVE_RUST depends on RUST_IS_AVAILABLE depends on !MODVERSIONS depends on !GCC_PLUGINS depends on !RANDSTRUCT depends on !DEBUG_INFO_BTF || PAHOLE_HAS_LANG_EXCLUDE - select CONSTRUCTORS help Enables Rust support in the kernel. This allows other Rust-related options, like drivers written in Rust, to be selected. It is also required to be able to load external kernel modules written in Rust. See Documentation/rust/ for more information. If unsure, say N.
---
base-commit: 90d35da658da8cff0d4ecbb5113f5fac9d00eb72
change-id: 20240307-constructors-07270b039e2c
Best regards,
Signature · 1 line
Alice Ryhl <[email protected]>
Quoted 11 lines · Alice Ryhl
This was originally part of commit
4b9a68f2e59a0("rust: add support for static synchronisation primitives") from the old Rust branch, which used module constructors to initialize globals containing various synchronisation primitives with pin-init. That commit has never been upstreamed, but theselect CONSTRUCTORSstatement ended up being included in the patch that initially added Rust support to the Linux Kernel.We are not using module constructors, so let's remove the select.
Signed-off-by Alice Ryhl <[email protected]>
Miguel Ojeda
AppliedQuoted 9 lines · Alice Ryhl
This was originally part of commit
4b9a68f2e59a0("rust: add support for static synchronisation primitives") from the old Rust branch, which used module constructors to initialize globals containing various synchronisation primitives with pin-init. That commit has never been upstreamed, but theselect CONSTRUCTORSstatement ended up being included in the patch that initially added Rust support to the Linux Kernel.
Quoted 3 lines
We are not using module constructors, so let's remove the select.
Signed-off-by Alice Ryhl <[email protected]>
Applied to rust-fixes and marked for stable too -- thanks everyone!
Cheers,
Miguel