Skip to contentSkip to conversation

Patch "selftests: mptcp: simult flows: format subtests results in TAP" has been added to the 6.1-stable tree

DISCUSSION Matthieu Baerts 2 participants 2 messages Mar 10, 2024 1 message not in the archive Stable branch

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

Hi Sasha,

Quoted 7 lines · Sasha Levin

This is a note to let you know that I've just added the patch titled

selftests: mptcp: simult flows: format subtests results in TAP

to the 6.1-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

Quoted 6 lines

The filename of the patch is:
selftests-mptcp-simult-flows-format-subtests-results.patch
and it can be found in the queue-6.1 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Thank you for having backported this commit 675d99338e7a ("selftests:
mptcp: simult flows: format subtests results in TAP") -- as well as commit 4d8e0dde0403 ("selftests: mptcp: simult flows: fix some subtest names"), a fix for it -- as a "dependence" for commit 5e2f3c65af47 ("selftests: mptcp: decrease BW in simult flows"), but I think it is better not to include 675d99338e7a (and 4d8e0dde0403): they are not dependences, just modifying the lines around, and they depend on other commits to have this feature to work.

In other words, commit 675d99338e7a ("selftests: mptcp: simult flows:
format subtests results in TAP") -- and 4d8e0dde0403 ("selftests: mptcp:
simult flows: fix some subtest names") -- is now causing the MPTCP simult flows selftest to fail. Could it be possible to remove them from 6.1 and 5.15 queues please?

Quoted 25 lines

commit 4eeef0aaffa567f812390612c30f800de02edd73

Author: Matthieu Baerts <[email protected]>
Date:   Mon Jul 17 15:21:31 2023 +0200

selftests: mptcp: simult flows: format subtests results in TAP

[ Upstream commit 675d99338e7a6cd925d61d7dbf8c26612f7f08a9 ]

The current selftests infrastructure formats the results in TAP 13. This version doesn't support subtests and only the end result of each selftest is taken into account. It means that a single issue in a subtest of a selftest containing multiple subtests forces the whole selftest to be marked as failed. It also means that subtests results are not tracked by CIs executing selftests.

MPTCP selftests run hundreds of various subtests. It is then important to track each of them and not one result per selftest.

It is particularly interesting to do that when validating stable kernels with the last version of the test suite: tests might fail because a feature is not supported but the test didn't skip that part. In this case, if subtests are not tracked, the whole selftest will be marked as failed making the other subtests useless because their results are ignored.

Quoted 7 lines

This patch formats subtests results in TAP in simult_flows.sh selftest.

Stable-dep-of: 5e2f3c65af47 ("selftests: mptcp: decrease BW in simult flows")

If needed, I can help to resolve the conflicts to have commit 5e2f3c65af47 ("selftests: mptcp: decrease BW in simult flows") backported to 6.1 and 5.15.

Cheers,
Matt

Signature · 1 line
Sponsored by the NGI0 Core fund.
maintainer
#2 lore raw
Quoted 26 lines · Matthieu Baerts

Hi Sasha,

Quoted 7 lines · Sasha Levin

This is a note to let you know that I've just added the patch titled

selftests: mptcp: simult flows: format subtests results in TAP

to the 6.1-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

Quoted 6 lines

The filename of the patch is:
selftests-mptcp-simult-flows-format-subtests-results.patch
and it can be found in the queue-6.1 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Thank you for having backported this commit 675d99338e7a ("selftests:
mptcp: simult flows: format subtests results in TAP") -- as well as commit 4d8e0dde0403 ("selftests: mptcp: simult flows: fix some subtest names"), a fix for it -- as a "dependence" for commit 5e2f3c65af47 ("selftests: mptcp: decrease BW in simult flows"), but I think it is better not to include 675d99338e7a (and 4d8e0dde0403): they are not dependences, just modifying the lines around, and they depend on other commits to have this feature to work.

Quoted 5 lines

In other words, commit 675d99338e7a ("selftests: mptcp: simult flows:
format subtests results in TAP") -- and 4d8e0dde0403 ("selftests: mptcp:
simult flows: fix some subtest names") -- is now causing the MPTCP simult flows selftest to fail. Could it be possible to remove them from 6.1 and 5.15 queues please?

I'll drop it, thanks!

Signature · 2 lines
Thanks,
Sasha