statx.2: Document STATX_SUBVOL
PATCH 1/1 statx.2: Document STATX_SUBVOL
Document the new statxt.stx_subvol field.
This would be clearer if we had a proper API for walking subvolumes that we could refer to, but that's still coming.
--- man2/statx.2 | 8 ++++++++ 1 file changed, 8 insertions(+)
man2/statx.2 +8 -0
@@ -68,6 +68,7 @@ struct statx { /* Direct I/O alignment restrictions */ __u32 stx_dio_mem_align; __u32 stx_dio_offset_align; + __u64 stx_subvol; /* Subvolume identifier */ }; .EE .in
@@ -255,6 +256,8 @@ STATX_ALL The same as STATX_BASIC_STATS | STATX_BTIME. STATX_MNT_ID Want stx_mnt_id (since Linux 5.8) STATX_DIOALIGN Want stx_dio_mem_align and stx_dio_offset_align (since Linux 6.1; support varies by filesystem) +STATX_SUBVOL Wants stx_subvol + (since Linux 6.9; support varies by filesystem) .TE .in .P
@@ -439,6 +442,11 @@ or 0 if direct I/O is not supported on this file. This will only be nonzero if .I stx_dio_mem_align is nonzero, and vice versa. +.TP +.I stx_subvolume +Subvolume number of the current file. + +Subvolumes are fancy directories, i.e. they form a tree structure that may be walked recursively. .P For further information on the above fields, see .BR inode (7).
Signature · 1 line
2.43.0
Quoted 27 lines · Kent Overstreet
Document the new statxt.stx_subvol field.
This would be clearer if we had a proper API for walking subvolumes that we could refer to, but that's still coming.
Signed-off-by Kent Overstreet <[email protected]>Cc Alejandro Colomar <[email protected]>--- man2/statx.2 | 8 ++++++++ 1 file changed, 8 insertions(+)man2/statx.2 +1
-0@@ -68,6 +68,7 @@ struct statx { /* Direct I/O alignment restrictions */ __u32 stx_dio_mem_align; __u32 stx_dio_offset_align; + __u64 stx_subvol; /* Subvolume identifier */ }; .EE .in
man2/statx.2 STATX_ALL The same as STATX_BASIC_STATS | STATX_BTIME. · line 260
Quoted 5 lines
man2/statx.2 +2
-0@@ -255,6 +256,8 @@ STATX_ALL The same as STATX_BASIC_STATS | STATX_BTIME. STATX_MNT_ID Want stx_mnt_id (since Linux 5.8) STATX_DIOALIGN Want stx_dio_mem_align and stx_dio_offset_align (since Linux 6.1; support varies by filesystem) +STATX_SUBVOL Wants stx_subvol + (since Linux 6.9; support varies by filesystem)
The other ones say "Want", not "Wants".
man2/statx.2 or 0 if direct I/O is not supported on this file. · line 446
Quoted 2 lines
man2/statx.2 +2
-0+.TP +.I stx_subvolume
It's stx_subvol, not stx_subvolume.
man2/statx.2 or 0 if direct I/O is not supported on this file. · line 449
Quoted 3 lines
man2/statx.2 +3
-0+Subvolume number of the current file. + +Subvolumes are fancy directories, i.e. they form a tree structure that may be walked recursively.
How about documenting which filesystems support it?
- Eric
Alejandro Colomar
maintainerHi!
Quoted 36 lines · Eric Biggers
Quoted 27 lines · Kent Overstreet
Document the new statxt.stx_subvol field.
This would be clearer if we had a proper API for walking subvolumes that we could refer to, but that's still coming.
Signed-off-by Kent Overstreet <[email protected]>Cc Alejandro Colomar <[email protected]>--- man2/statx.2 | 8 ++++++++ 1 file changed, 8 insertions(+)man2/statx.2 +1
-0@@ -68,6 +68,7 @@ struct statx { /* Direct I/O alignment restrictions */ __u32 stx_dio_mem_align; __u32 stx_dio_offset_align; + __u64 stx_subvol; /* Subvolume identifier */ }; .EE .inman2/statx.2 STATX_ALL The same as STATX_BASIC_STATS | STATX_BTIME. · line 260
Quoted 5 lines
man2/statx.2 +2
-0@@ -255,6 +256,8 @@ STATX_ALL The same as STATX_BASIC_STATS | STATX_BTIME. STATX_MNT_ID Want stx_mnt_id (since Linux 5.8) STATX_DIOALIGN Want stx_dio_mem_align and stx_dio_offset_align (since Linux 6.1; support varies by filesystem) +STATX_SUBVOL Wants stx_subvol + (since Linux 6.9; support varies by filesystem)The other ones say "Want", not "Wants".
Quoted 7 lines
man2/statx.2 or 0 if direct I/O is not supported on this file. · line 446
Quoted 2 lines
man2/statx.2 +2
-0+.TP +.I stx_subvolumeIt's
stx_subvol, notstx_subvolume.man2/statx.2 or 0 if direct I/O is not supported on this file. · line 448
Quoted 2 lines
man2/statx.2 +2
-0+Subvolume number of the current file. +
Also, don't use blank lines. We use '.P' for new paragraphs.
Quoted 1 line
Quoted 1 line
+Subvolumes are fancy directories, i.e. they form a tree structure that may be walked recursively.
And please use semantic newlines (see man-pages(7)).
Have a lovely day!
Alex
Quoted 5 lines
How about documenting which filesystems support it?
- Eric
Signature · 1 line
<https://www.alejandro-colomar.es/>
Quoted 1 line · Alejandro Colomar
Hi!
Was there ever an updated version of this patch?
I don't see anything for this in the man pages git yet.
Quoted 61 lines · Eric Biggers
Quoted 36 lines · Kent Overstreet
Quoted 27 lines
Document the new statxt.stx_subvol field.
This would be clearer if we had a proper API for walking subvolumes that we could refer to, but that's still coming.
Signed-off-by Kent Overstreet <[email protected]>Cc Alejandro Colomar <[email protected]>--- man2/statx.2 | 8 ++++++++ 1 file changed, 8 insertions(+)man2/statx.2 +1
-0@@ -68,6 +68,7 @@ struct statx { /* Direct I/O alignment restrictions */ __u32 stx_dio_mem_align; __u32 stx_dio_offset_align; + __u64 stx_subvol; /* Subvolume identifier */ }; .EE .inman2/statx.2 STATX_ALL The same as STATX_BASIC_STATS | STATX_BTIME. · line 260
Quoted 5 lines
man2/statx.2 +2
-0@@ -255,6 +256,8 @@ STATX_ALL The same as STATX_BASIC_STATS | STATX_BTIME. STATX_MNT_ID Want stx_mnt_id (since Linux 5.8) STATX_DIOALIGN Want stx_dio_mem_align and stx_dio_offset_align (since Linux 6.1; support varies by filesystem) +STATX_SUBVOL Wants stx_subvol + (since Linux 6.9; support varies by filesystem)The other ones say "Want", not "Wants".
Quoted 7 lines
man2/statx.2 or 0 if direct I/O is not supported on this file. · line 446
Quoted 2 lines
man2/statx.2 +2
-0+.TP +.I stx_subvolumeIt's
stx_subvol, notstx_subvolume.man2/statx.2 or 0 if direct I/O is not supported on this file. · line 448
Quoted 2 lines
man2/statx.2 +2
-0+Subvolume number of the current file. +Also, don't use blank lines. We use '.P' for new paragraphs.
Quoted 1 line
Quoted 1 line
+Subvolumes are fancy directories, i.e. they form a tree structure that may be walked recursively.
And please use semantic newlines (see man-pages(7)).
Have a lovely day!
AlexQuoted 5 lines
How about documenting which filesystems support it?
- Eric
Alejandro Colomar
maintainerHi John,
Quoted 7 lines · John Garry
Quoted 1 line · Alejandro Colomar
Hi!
Was there ever an updated version of this patch?
I don't see anything for this in the man pages git yet.
When I pick a patch, I explicitly notify the author in a reply in the same thread. I haven't. I commented some issues with the patch so that the author sends some revised patch.
Have a lovely day!
Alex
Hi Alex,
Quoted 12 lines · John Garry
Quoted 6 lines · Alejandro Colomar
Quoted 1 line
Hi!
Was there ever an updated version of this patch?
I don't see anything for this in the man pages git yet.
When I pick a patch, I explicitly notify the author in a reply in the same thread. I haven't. I commented some issues with the patch so that the author sends some revised patch.
I wanted to send a rebased version of my series https://lore.kernel.org/linux-api/[email protected]/
[it was an oversight to not cc you / [email protected] there]
Anyway I would like to use a proper baseline, which includes STATX_SUBVOL info. So I will send an updated patch for STATX_SUBVOL if I don't see it soon.
Thanks,
John
Alejandro Colomar
maintainerHi John,
Quoted 15 lines · John Garry
Hi Alex,
Quoted 12 lines · John Garry
Quoted 6 lines · Alejandro Colomar
Quoted 1 line
Hi!
Was there ever an updated version of this patch?
I don't see anything for this in the man pages git yet.
When I pick a patch, I explicitly notify the author in a reply in the same thread. I haven't. I commented some issues with the patch so that the author sends some revised patch.
Quoted 7 lines
I wanted to send a rebased version of my series https://lore.kernel.org/linux-api/[email protected]/
[it was an oversight to not cc you / [email protected] there]
Anyway I would like to use a proper baseline, which includes
STATX_SUBVOLinfo. So I will send an updated patch forSTATX_SUBVOLif I don't see it soon.
Thanks! no problem.
Have a lovely day!
Alex
Quoted 4 lines
Thanks,
John
Signature · 1 line
<https://www.alejandro-colomar.es/>
Alejandro Colomar
maintainerHi Kent, Eric, John,
Thread: <https://lore.kernel.org/linux-man/[email protected]/T/#u>
I revisited this thread today and checked that there wasn't an updated patch. Would you like to send a revised version of the patch?
Have a lovely day!
Alex
Quoted 38 lines · Alejandro Colomar
Hi John,
Quoted 15 lines · John Garry
Hi Alex,
Quoted 12 lines · John Garry
Quoted 6 lines · Alejandro Colomar
Quoted 1 line
Hi!
Was there ever an updated version of this patch?
I don't see anything for this in the man pages git yet.
When I pick a patch, I explicitly notify the author in a reply in the same thread. I haven't. I commented some issues with the patch so that the author sends some revised patch.
Quoted 7 lines
I wanted to send a rebased version of my series https://lore.kernel.org/linux-api/[email protected]/
[it was an oversight to not cc you / [email protected] there]
Anyway I would like to use a proper baseline, which includes
STATX_SUBVOLinfo. So I will send an updated patch forSTATX_SUBVOLif I don't see it soon.Thanks! no problem.
Have a lovely day!
AlexQuoted 4 lines
Thanks,
JohnSignature · 1 line
<https://www.alejandro-colomar.es/>
Signature · 1 line
<https://www.alejandro-colomar.es/>
Quoted 6 lines · Alejandro Colomar
Hi Kent, Eric, John,
Thread: <https://lore.kernel.org/linux-man/[email protected]/T/#u>
I revisited this thread today and checked that there wasn't an updated patch. Would you like to send a revised version of the patch?
Hi Alex,
Wasn't this done in the following:
commit d0621648b4b5a356e86cea23e842f2591461f0cf
Author: Kent Overstreet <[email protected]> Date: Thu Jun 20 13:00:17 2024 +0000
statx.2: Document STATX_SUBVOL
Document the new statx.stx_subvol field.
This would be clearer if we had a proper API for walking subvolumes that we could refer to, but that's still coming.
Message-ID: <[email protected]>
BTW, on another totally separate topic, there is nothing for this:
https://lore.kernel.org/linux-fsdevel/[email protected]/
right?
Thanks,
John
Quoted 46 lines
Have a lovely day!
AlexQuoted 38 lines · Alejandro Colomar
Hi John,
Quoted 15 lines · John Garry
Hi Alex,
Quoted 12 lines · John Garry
Quoted 6 lines · Alejandro Colomar
Quoted 1 line
Hi!
Was there ever an updated version of this patch?
I don't see anything for this in the man pages git yet.
When I pick a patch, I explicitly notify the author in a reply in the same thread. I haven't. I commented some issues with the patch so that the author sends some revised patch.
Quoted 7 lines
I wanted to send a rebased version of my series https://lore.kernel.org/linux-api/[email protected]/
[it was an oversight to not cc you / [email protected] there]
Anyway I would like to use a proper baseline, which includes
STATX_SUBVOLinfo. So I will send an updated patch forSTATX_SUBVOLif I don't see it soon.Thanks! no problem.
Have a lovely day!
AlexQuoted 4 lines
Thanks,
JohnSignature · 1 line
<https://www.alejandro-colomar.es/>
Alejandro Colomar
maintainerHi John,
Quoted 11 lines · John Garry
Quoted 6 lines · Alejandro Colomar
Hi Kent, Eric, John,
Thread: <https://lore.kernel.org/linux-man/[email protected]/T/#u>
I revisited this thread today and checked that there wasn't an updated patch. Would you like to send a revised version of the patch?
Hi Alex,
Wasn't this done in the following:
Ahh, true. I cound't find it because it was in another thread. That's why I prefer that patch v2 is a reply to the same thread that sent patch v1. :-) I'll have to document this in the CONTRIBUTING.d/* guidelines.
Thanks!
Quoted 19 lines
commit
d0621648b4b5a356e86cea23e842f2591461f0cfAuthor: Kent Overstreet <[email protected]> Date: Thu Jun 20 13:00:17 2024 +0000statx.2: Document
STATX_SUBVOLDocument the new statx.stx_subvol field.
This would be clearer if we had a proper API for walking subvolumes that we could refer to, but that's still coming.
Signed-off-by Kent Overstreet <[email protected]>[jpg: mention supported FSes and formatting improvements]Signed-off-by John Garry <[email protected]>Cc Eric Biggers <[email protected]>Cc <[email protected]>
Quoted 8 lines
Message-ID: <[email protected]>
Signed-off-by Alejandro Colomar <[email protected]>BTW, on another totally separate topic, there is nothing for this:
https://lore.kernel.org/linux-fsdevel/[email protected]/
right?
grep(1) seems to say you're right.
alx@devuan:~/src/linux/man-pages/man-pages/contrib$ grep -rn RWF_NOAPPEND alx@devuan:~/src/linux/man-pages/man-pages/contrib$
I guess we should ping that thread.
Have a lovely day!
Alex
Quoted 3 lines
Thanks,
John
Signature · 1 line
<https://www.alejandro-colomar.es/>