Skip to contentSkip to conversation

RDMA/rxe: Fix the problem "mutex_destroy missing"

PATCH Applied Yanjun.Zhu 3 participants 3 messages Mar 14, 2024 – Apr 1, 2024

Subsystems (2)
InfiniBand Soft-RoCE driver (rxe)
lore
Share & tools
lore

Yanjun.Zhu

author
#0 lore raw

PATCH 1/1 RDMA/rxe: Fix the problem "mutex_destroy missing"

When a mutex lock is not used any more, the function mutex_destroy should be called to mark the mutex lock uninitialized.

Fixes 8700e3e7c485 ("Soft RoCE driver")
Signed-off-by Yanjun.Zhu <[email protected]>
---
 drivers/infiniband/sw/rxe/rxe.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/infiniband/sw/rxe/rxe.c +2 -0
index 54c723a6edda..6f9ec8db014c 100644
@@ -33,6 +33,8 @@ void rxe_dealloc(struct ib_device *ib_dev)
 
 	if (rxe->tfm)
 		crypto_free_shash(rxe->tfm);
+
+	mutex_destroy(&rxe->usdev_lock);
 }
 
 /* initialize rxe device parameters */
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 24 lines · Yanjun.Zhu

When a mutex lock is not used any more, the function mutex_destroy should be called to mark the mutex lock uninitialized.

Fixes 8700e3e7c485 ("Soft RoCE driver")
Signed-off-by Yanjun.Zhu <[email protected]>
---
 drivers/infiniband/sw/rxe/rxe.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/infiniband/sw/rxe/rxe.c +2 -1
index 54c723a6edda..6f9ec8db014c 100644
@@ -33,6 +33,8 @@ void rxe_dealloc(struct ib_device *ib_dev)
 
 	if (rxe->tfm)
 		crypto_free_shash(rxe->tfm);
+
+	mutex_destroy(&rxe->usdev_lock);
 }
 
 /* initialize rxe device parameters */
--
Quoted 2 lines

2.34.1

That's right.

Reviewed-by Daisuke Matsuda <[email protected]>

Daisuke