perf script: Show also errors for --insn-trace option
Adrian Hunter
reviewerPATCH 1/2 perf script: Show also errors for --insn-trace option
The trace could be misleading if trace errors are not taken into account, so display them also by adding the itrace "e" option.
Note --call-trace and --call-ret-trace already add the itrace "e" option.
--- tools/perf/builtin-script.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/builtin-script.c +1 -1
@@ -3806,7 +3806,7 @@ static int parse_insn_trace(const struct option *opt __maybe_unused,if (ret <0 )return ret; -itrace_parse_synth_opts (opt,"i0ns" ,0 ); +itrace_parse_synth_opts (opt,"i0nse" ,0 ); symbol_conf.nanosecs = true;return 0 ; }
Signature · 1 line
2.34.1
Adrian Hunter
reviewerPATCH 2/2 perf auxtrace: Fix multiple use of --itrace option
If the --itrace option is used more than once, the options are combined, but "i" and "y" (sub-)options can be corrupted because itrace_do_parse_synth_opts() incorrectly overwrites the period type and period with default values.
For example, with:
--itrace=i0ns --itrace=e
The processing of "--itrace=e", resets the "i" period from 0 nanoseconds to the default 100 microseconds.
Fix by performing the default setting of period type and period only if "i" or "y" are present in the currently processed --itrace value.
--- tools/perf/util/auxtrace.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
tools/perf/util/auxtrace.c +3 -1
@@ -1466,6 +1466,7 @@ int itrace_do_parse_synth_opts(struct itrace_synth_opts *synth_opts,char *endptr;bool period_type_set = false;bool period_set = false; +bool iy = false; synth_opts->set = true;
@@ -1484,6 +1485,7 @@ int itrace_do_parse_synth_opts(struct itrace_synth_opts *synth_opts,switch (*p++) {case 'i' :case 'y' : + iy = true;if (p[-1 ] =='y' ) synth_opts->cycles = true;else
@@ -1649,7 +1651,7 @@ int itrace_do_parse_synth_opts(struct itrace_synth_opts *synth_opts, } } out: -if (synth_opts->instructions || synth_opts->cycles) { +if (iy) {if (!period_type_set) synth_opts->period_type =PERF_ITRACE_DEFAULT_PERIOD_TYPE ;
Signature · 1 line
2.34.1
Quoted 8 lines · Adrian Hunter
The trace could be misleading if trace errors are not taken into account, so display them also by adding the itrace "e" option.
Note --call-trace and --call-ret-trace already add the itrace "e" option.
Fixes b585ebdb5912 ("perf script: Add --insn-trace for instruction decoding")
Thanks, applied both patches to perf-tools-next.
- Arnaldo