Skip to contentSkip to conversation

ALSA: timer: Fix missing irq-disable at closing

PATCH New Takashi Iwai 1 participant 1 message Mar 15, 2024 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: timer: Fix missing irq-disable at closing

The conversion to guard macro dropped the irq-disablement at closing mistakenly, which may lead to a race. Fix it.

Fixes beb45974dd49 ("ALSA: timer: Use guard() for locking")
Reported-by [email protected]
---
 sound/core/timer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/core/timer.c +1 -1
index 15b07d09c4b7..4d2ee99c12a3 100644
@@ -409,7 +409,7 @@ static void snd_timer_close_locked(struct snd_timer_instance *timeri,
 	struct snd_timer *timer = timeri->timer;
 
 	if (timer) {
-		guard(spinlock)(&timer->lock);
+		guard(spinlock_irq)(&timer->lock);
 		timeri->flags |= SNDRV_TIMER_IFLG_DEAD;
 	}
 
Signature · 1 line
2.43.0