Skip to contentSkip to conversation

drivers/nvme: Add quirks for device 126f:2262

PATCH Applied iBug 4 participants 4 messages Mar 15, 2024 – Mar 18, 2024 NVMe

lore
Share & tools
lore

iBug

author
#0 lore raw

PATCH 1/1 drivers/nvme: Add quirks for device 126f:2262

From: "Jiawei Fu (iBug)" <[email protected]>

This commit adds NVME_QUIRK_NO_DEEPEST_PS and NVME_QUIRK_BOGUS_NID for device [126f:2262], which appears to be a generic VID:PID pair used for many SSDs based on the Silicon Motion SM2262/SM2262EN controller.

Two of my SSDs with this VID:PID pair exhibit the same behavior:

* They frequently have trouble exiting the deepest power state (5), resulting in the entire disk unresponsive.
Verified by setting nvme_core.default_ps_max_latency_us=10000 and observing them behaving normally.
* They produce all-zero nguid and eui64 with nvme id-ns command.

The offending products are:

* HP SSD EX950 1TB
* HIKVISION C2000Pro 2TB

---
 drivers/nvme/host/pci.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/nvme/host/pci.c +3 -0
index e6267a6aa380..8e0bb9692685 100644
@@ -3363,6 +3363,9 @@ static const struct pci_device_id nvme_id_table[] = {
 				NVME_QUIRK_BOGUS_NID, },
 	{ PCI_VDEVICE(REDHAT, 0x0010),	/* Qemu emulated controller */
 		.driver_data = NVME_QUIRK_BOGUS_NID, },
+	{ PCI_DEVICE(0x126f, 0x2262),	/* Silicon Motion generic */
+		.driver_data = NVME_QUIRK_NO_DEEPEST_PS |
+				NVME_QUIRK_BOGUS_NID, },
 	{ PCI_DEVICE(0x126f, 0x2263),	/* Silicon Motion unidentified */
 		.driver_data = NVME_QUIRK_NO_NS_DESC_LIST |
 				NVME_QUIRK_BOGUS_NID, },
Signature · 1 line
2.43.2
maintainer Applied
#3 lore raw
In reply to iBug
Quoted 5 lines · iBug

From: "Jiawei Fu (iBug)" <[email protected]>

This commit adds NVME_QUIRK_NO_DEEPEST_PS and NVME_QUIRK_BOGUS_NID for device [126f:2262], which appears to be a generic VID:PID pair used for many SSDs based on the Silicon Motion SM2262/SM2262EN controller.

Thanks, applied to nvme-6.9.