Skip to contentSkip to conversation

Add additional HyperX IDs to xpad.c on LTS v4.19 to v6.1

PATCH In review Max Nguyen 2 participants 4 messages Mar 15, 2024 – Apr 2, 2024

Subsystems (2)
Stable branch Input drivers
lore
Share & tools
lore

Max Nguyen

author
#0 lore raw

PATCH 1/2 Add additional HyperX IDs to xpad.c on LTS v4.19 to v6.1

Add additional HyperX Ids to xpad_device and xpad_table

Add to LTS versions 4.19, 5.4, 5.10, 5.15, 6.1

Suggested-by Chris Toledanes <[email protected]>
Reviewed-by Carl Ng <[email protected]>
Signed-off-by Max Nguyen <[email protected]>
---
 drivers/input/joystick/xpad.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
drivers/input/joystick/xpad.c +8 -2
index dffdd25b6fc9..842733305fa8 100644
@@ -128,12 +128,17 @@ static const struct xpad_device {
 	{ 0x0079, 0x18d4, "GPD Win 2 X-Box Controller", 0, XTYPE_XBOX360 },
 	{ 0x03eb, 0xff01, "Wooting One (Legacy)", 0, XTYPE_XBOX360 },
 	{ 0x03eb, 0xff02, "Wooting Two (Legacy)", 0, XTYPE_XBOX360 },
+	{ 0x03f0, 0x038D, "HyperX Clutch", 0, XTYPE_XBOX360 },			/* wired */
+	{ 0x03f0, 0x048D, "HyperX Clutch", 0, XTYPE_XBOX360 },			/* wireless */
+	{ 0x03f0, 0x0495, "HyperX Clutch Gladiate", 0, XTYPE_XBOXONE },
+	{ 0x03f0, 0x07A0, "HyperX Clutch Gladiate RGB", 0, XTYPE_XBOXONE },
+	{ 0x03f0, 0x08B6, "HyperX Clutch Gladiate", 0, XTYPE_XBOXONE },		/* v2 */
+	{ 0x03f0, 0x09B4, "HyperX Clutch Tanto", 0, XTYPE_XBOXONE },
 	{ 0x044f, 0x0f00, "Thrustmaster Wheel", 0, XTYPE_XBOX },
 	{ 0x044f, 0x0f03, "Thrustmaster Wheel", 0, XTYPE_XBOX },
 	{ 0x044f, 0x0f07, "Thrustmaster, Inc. Controller", 0, XTYPE_XBOX },
 	{ 0x044f, 0x0f10, "Thrustmaster Modena GT Wheel", 0, XTYPE_XBOX },
 	{ 0x044f, 0xb326, "Thrustmaster Gamepad GP XID", 0, XTYPE_XBOX360 },
-	{ 0x03f0, 0x0495, "HyperX Clutch Gladiate", 0, XTYPE_XBOXONE },
 	{ 0x045e, 0x0202, "Microsoft X-Box pad v1 (US)", 0, XTYPE_XBOX },
 	{ 0x045e, 0x0285, "Microsoft X-Box pad (Japan)", 0, XTYPE_XBOX },
 	{ 0x045e, 0x0287, "Microsoft Xbox Controller S", 0, XTYPE_XBOX },

@@ -446,8 +451,9 @@ static const struct usb_device_id xpad_table[] = {
 	{ USB_INTERFACE_INFO('X', 'B', 0) },	/* X-Box USB-IF not approved class */
 	XPAD_XBOX360_VENDOR(0x0079),		/* GPD Win 2 Controller */
 	XPAD_XBOX360_VENDOR(0x03eb),		/* Wooting Keyboards (Legacy) */
+	XPAD_XBOX360_VENDOR(0x03f0),		/* HP HyperX Xbox 360 controllers */
+	XPAD_XBOXONE_VENDOR(0x03f0),		/* HP HyperX Xbox One controllers */
 	XPAD_XBOX360_VENDOR(0x044f),		/* Thrustmaster X-Box 360 controllers */
-	XPAD_XBOXONE_VENDOR(0x03f0),		/* HP HyperX Xbox One Controllers */
 	XPAD_XBOX360_VENDOR(0x045e),		/* Microsoft X-Box 360 controllers */
 	XPAD_XBOXONE_VENDOR(0x045e),		/* Microsoft X-Box One controllers */
 	XPAD_XBOX360_VENDOR(0x046d),		/* Logitech X-Box 360 style controllers */
Signature · 1 line
2.39.3
maintainer
#1 lore raw
Quoted 10 lines · Max Nguyen

Add additional HyperX Ids to xpad_device and xpad_table

Add to LTS versions 4.19, 5.4, 5.10, 5.15, 6.1

Suggested-by Chris Toledanes <[email protected]>
Reviewed-by Carl Ng <[email protected]>
Signed-off-by Max Nguyen <[email protected]>
---
 drivers/input/joystick/xpad.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

<formletter>

This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>

author
#2 lore raw
Quoted 11 lines · Greg KH
Quoted 10 lines · Max Nguyen

Add additional HyperX Ids to xpad_device and xpad_table

Add to LTS versions 4.19, 5.4, 5.10, 5.15, 6.1

Suggested-by Chris Toledanes <[email protected]>
Reviewed-by Carl Ng <[email protected]>
Signed-off-by Max Nguyen <[email protected]>
---
  drivers/input/joystick/xpad.c | 10 ++++++++--
  1 file changed, 8 insertions(+), 2 deletions(-)
Quoted 8 lines

<formletter>

This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>

Hi Greg,
Thanks for your help so far. I am committed to figuring this out so thank you again your patience. I had a couple questions to confirm before I resubmit.

I had done option 1 to include in stable when I submitted to mainline. I saw that my patch was picked up in the latest stable. Will it be eventually picked up by the older LTS versions?

I need to add the upstream commit ID to my patches. I intended to go with option 3 since there is some deviation in my patch from the upstream. Am I just missing the upstream commit ID and deviation explanation for my patch?

maintainer
#3 lore raw
Quoted 20 lines · Max
Quoted 18 lines · Greg KH
Quoted 10 lines · Max Nguyen

Add additional HyperX Ids to xpad_device and xpad_table

Add to LTS versions 4.19, 5.4, 5.10, 5.15, 6.1

Suggested-by Chris Toledanes <[email protected]>
Reviewed-by Carl Ng <[email protected]>
Signed-off-by Max Nguyen <[email protected]>
---
  drivers/input/joystick/xpad.c | 10 ++++++++--
  1 file changed, 8 insertions(+), 2 deletions(-)

<formletter>

This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

Quoted 6 lines
Quoted 1 line

</formletter>

Hi Greg,
Thanks for your help so far. I am committed to figuring this out so thank you again your patience. I had a couple questions to confirm before I resubmit.

I had done option 1 to include in stable when I submitted to mainline. I saw that my patch was picked up in the latest stable. Will it be eventually picked up by the older LTS versions?

Depends, did it apply to older LTS versions? If not, then no.

Quoted 1 line

I need to add the upstream commit ID to my patches. I intended to go with option 3 since there is some deviation in my patch from the upstream. Am I just missing the upstream commit ID and deviation explanation for my patch?

That is a start, yes. Try it and see!

thanks,

greg k-h