selftests/mm: Fix build with _FORTIFY_SOURCE
Subsystems (4)
PATCH 1/1 selftests/mm: Fix build with _FORTIFY_SOURCE
Add missing flags argument to open(2) call with O_CREAT.
Some tests fail to compile if _FORTIFY_SOURCE is defined (to any valid value) (together with -O), resulting in similar error messages such as:
In file included from /usr/include/fcntl.h:342,
from gup_test.c:1:
In function 'open',
inlined from 'main' at gup_test.c:206:10:
/usr/include/bits/fcntl2.h:50:11: error: call to '__open_missing_mode' declared with attribute error: open with O_CREAT or O_TMPFILE in second argument needs 3 arguments
50 | __open_missing_mode ();
| ^~~~~~~~~~~~~~~~~~~~~~_FORTIFY_SOURCE is enabled by default in some distributions, so the tests are not built by default and are skipped.
open(2) man-page warns about missing flags argument: "if it is not supplied, some arbitrary bytes from the stack will be applied as the file mode."
--- tools/testing/selftests/mm/gup_test.c | 2 +- tools/testing/selftests/mm/soft-dirty.c | 2 +- tools/testing/selftests/mm/split_huge_page_test.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
tools/testing/selftests/mm/gup_test.c +1 -1
@@ -203,7 +203,7 @@ int main(int argc, char **argv)ksft_print_header ();ksft_set_plan (nthreads); - filed =open (file,O_RDWR |O_CREAT ); + filed =open (file,O_RDWR |O_CREAT ,0664 );if (filed <0 )ksft_exit_fail_msg ("Unable to open %s: %s\n" , file,strerror (errno));
tools/testing/selftests/mm/soft-dirty.c +1 -1
@@ -137,7 +137,7 @@ static void test_mprotect(int pagemap_fd, int pagesize, bool anon)if (!map)ksft_exit_fail_msg ("anon mmap failed\n" ); }else { - test_fd =open (fname,O_RDWR |O_CREAT ); + test_fd =open (fname,O_RDWR |O_CREAT ,0664 );if (test_fd <0 ) {ksft_test_result_skip ("Test %s open() file failed\n" , __func__);return ;
tools/testing/selftests/mm/split_huge_page_test.c +1 -1
@@ -223,7 +223,7 @@ void split_file_backed_thp(void)ksft_exit_fail_msg ("Fail to create file-backed THP split testing file\n" ); } - fd =open (testfile,O_CREAT |O_WRONLY ); + fd =open (testfile,O_CREAT |O_WRONLY ,0664 );if (fd ==-1 ) {ksft_perror ("Cannot open testing file" ); goto cleanup;
Signature · 1 line
2.42.1
Zi Yan
reviewerQuoted 32 lines · Vitaly Chikunov
Add missing flags argument to open(2) call with
O_CREAT.Some tests fail to compile if
_FORTIFY_SOURCEis defined (to any valid value) (together with -O), resulting in similar error messages such as:In file included from
/usr/include/fcntl.h:342,from gup_test.c:1: In function 'open', inlined from 'main' at gup_test.c:206:10: /usr/include/bits/fcntl2.h:50:11: error: call to '__open_missing_mode' declared with attribute error: open with O_CREAT or O_TMPFILE in second argument needs 3 arguments 50 | __open_missing_mode (); | ^~~~~~~~~~~~~~~~~~~~~~
_FORTIFY_SOURCEis enabled by default in some distributions, so the tests are not built by default and are skipped.open(2) man-page warns about missing flags argument: "if it is not supplied, some arbitrary bytes from the stack will be applied as the file mode."
Fixes aeb85ed4f41a ("tools/testing/selftests/vm/gup_benchmark.c: allow user specified file")Fixes fbe37501b252 ("mm: huge_memory: debugfs for file-backed THP split")Fixes c942f5bd17b3 ("selftests: soft-dirty: add test for mprotect")Cc Keith Busch <[email protected]>Cc Zi Yan <[email protected]>Cc Peter Xu <[email protected]>Cc Yang Shi <[email protected]>Cc Andrea Arcangeli <[email protected]>Cc Nadav Amit <[email protected]>Cc David Hildenbrand <[email protected]>Cc Andrew Morton <[email protected]>Signed-off-by Vitaly Chikunov <[email protected]>
Quoted 5 lines
--- tools/testing/selftests/mm/gup_test.c | 2 +- tools/testing/selftests/mm/soft-dirty.c | 2 +- tools/testing/selftests/mm/split_huge_page_test.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
LGTM. Thanks. Reviewed-by: Zi Yan <[email protected]>
--
Best Regards,
Yan, Zi
Quoted 32 lines · Vitaly Chikunov
Add missing flags argument to open(2) call with
O_CREAT.Some tests fail to compile if
_FORTIFY_SOURCEis defined (to any valid value) (together with -O), resulting in similar error messages such as:In file included from /usr/include/fcntl.h:342, from gup_test.c:1: In function 'open', inlined from 'main' at gup_test.c:206:10: /usr/include/bits/fcntl2.h:50:11: error: call to '__open_missing_mode' declared with attribute error: open with O_CREAT or O_TMPFILE in second argument needs 3 arguments 50 | __open_missing_mode (); | ^~~~~~~~~~~~~~~~~~~~~~
_FORTIFY_SOURCEis enabled by default in some distributions, so the tests are not built by default and are skipped.open(2) man-page warns about missing flags argument: "if it is not supplied, some arbitrary bytes from the stack will be applied as the file mode."
Fixes aeb85ed4f41a ("tools/testing/selftests/vm/gup_benchmark.c: allow user specified file")Fixes fbe37501b252 ("mm: huge_memory: debugfs for file-backed THP split")Fixes c942f5bd17b3 ("selftests: soft-dirty: add test for mprotect")Cc Keith Busch <[email protected]>Cc Zi Yan <[email protected]>Cc Peter Xu <[email protected]>Cc Yang Shi <[email protected]>Cc Andrea Arcangeli <[email protected]>Cc Nadav Amit <[email protected]>Cc David Hildenbrand <[email protected]>Cc Andrew Morton <[email protected]>Signed-off-by Vitaly Chikunov <[email protected]>
Quoted 1 line
---
Signature · 3 lines
Cheers, David / dhildenb