media: rcar-vin: work around -Wenum-compare-conditional warning
PATCH 1/1 media: rcar-vin: work around -Wenum-compare-conditional warning
From: Arnd Bergmann <[email protected]>
clang-19 warns about mixing two enum types here:
drivers/media/platform/renesas/rcar-vin/rcar-vin.h:296:12: error: conditional expression between different enumeration types ('enum rvin_csi_id' and 'enum rvin_isp_id') [-Werror,-Wenum-compare-conditional] drivers/media/platform/renesas/rcar-vin/rcar-core.c:216:18: error: conditional expression between different enumeration types ('enum rvin_csi_id' and 'enum rvin_isp_id') [-Werror,-Wenum-compare-conditional] drivers/media/platform/renesas/rcar-vin/rcar-vin.h:296:12: error: conditional expression between different enumeration types ('enum rvin_csi_id' and 'enum rvin_isp_id') [-Werror,-Wenum-compare-conditional] drivers/media/platform/renesas/rcar-vin/rcar-vin.h:296:12: error: conditional expression between different enumeration types ('enum rvin_csi_id' and 'enum rvin_isp_id') [-Werror,-Wenum-compare-conditional]
This one is intentional, and there is already a cast to work around another warning, so address this by adding another cast.
---
There are only a couple of -Wenum-compare-conditional warnings in the tree, so it seems best to just address them all instead of turning off the warning globally.
--- drivers/media/platform/renesas/rcar-vin/rcar-vin.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/platform/renesas/rcar-vin/rcar-vin.h +1 -1
@@ -59,7 +59,7 @@ enum rvin_isp_id {#define RVIN_REMOTES_MAX \ (((unsigned int)RVIN_CSI_MAX) > ((unsigned int)RVIN_ISP_MAX) ? \ - RVIN_CSI_MAX : RVIN_ISP_MAX) + (unsigned int)RVIN_CSI_MAX : (unsigned int)RVIN_ISP_MAX)/** * enum rvin_dma_state - DMA states
Signature · 1 line
2.39.2
Hi Arnd,
Thanks for your work.
Quoted 9 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
clang-19 warns about mixing two enum types here:
drivers/media/platform/renesas/rcar-vin/rcar-vin.h:296:12: error: conditional expression between different enumeration types ('enumrvin_csi_id' and 'enumrvin_isp_id') [-Werror,-Wenum-compare-conditional]drivers/media/platform/renesas/rcar-vin/rcar-core.c:216:18: error: conditional expression between different enumeration types ('enumrvin_csi_id' and 'enumrvin_isp_id') [-Werror,-Wenum-compare-conditional]drivers/media/platform/renesas/rcar-vin/rcar-vin.h:296:12: error: conditional expression between different enumeration types ('enumrvin_csi_id' and 'enumrvin_isp_id') [-Werror,-Wenum-compare-conditional]drivers/media/platform/renesas/rcar-vin/rcar-vin.h:296:12: error: conditional expression between different enumeration types ('enumrvin_csi_id' and 'enumrvin_isp_id') [-Werror,-Wenum-compare-conditional]
Quoted 5 lines
This one is intentional, and there is already a cast to work around another warning, so address this by adding another cast.
Fixes 406bb586dec0 ("media: rcar-vin: Add r8a779a0 support")Signed-off-by Arnd Bergmann <[email protected]>
Quoted 24 lines
---
There are only a couple of -Wenum-compare-conditional warnings in the tree, so it seems best to just address them all instead of turning off the warning globally.--- drivers/media/platform/renesas/rcar-vin/rcar-vin.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/media/platform/renesas/rcar-vin/rcar-vin.h +1
-1@@ -59,7 +59,7 @@ enum rvin_isp_id {#define RVIN_REMOTES_MAX \ (((unsigned int)RVIN_CSI_MAX) > ((unsigned int)RVIN_ISP_MAX) ? \ - RVIN_CSI_MAX : RVIN_ISP_MAX) + (unsigned int)RVIN_CSI_MAX : (unsigned int)RVIN_ISP_MAX)/** * enum rvin_dma_state - DMA states Signature · 1 line
2.39.2
Signature · 2 lines
Kind Regards, Niklas Söderlund