Skip to contentSkip to conversation

wic: bootimg-partition allow to set var to get boot files

PATCH In review Anibal Limon 4 participants 15 messages Mar 23, 2024 – May 30, 2025 3 messages not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 wic: bootimg-partition allow to set var to get boot files

This is a generic functionality that takes a set of files and create a boot parition based on IMAGE_BOOT_FILES var, allow to sepcify the variable name so a BSP plugin can extend this and re-use the functionality.

---
 scripts/lib/wic/plugins/source/bootimg-partition.py | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
scripts/lib/wic/plugins/source/bootimg-partition.py +3 -2
index 58f6da72c3..1071d1af3f 100644
@@ -32,6 +32,7 @@ class BootimgPartitionPlugin(SourcePlugin):
     """
 
     name = 'bootimg-partition'
+    image_boot_files_var_name = 'IMAGE_BOOT_FILES'
 
     @classmethod
     def do_configure_partition(cls, part, source_params, cr, cr_workdir,
@@ -56,12 +57,12 @@ class BootimgPartitionPlugin(SourcePlugin):
             else:
                 var = ""
 
-            boot_files = get_bitbake_var("IMAGE_BOOT_FILES" + var)
+            boot_files = get_bitbake_var(cls.image_boot_files_var_name + var)
             if boot_files is not None:
                 break
 
         if boot_files is None:
-            raise WicError('No boot files defined, IMAGE_BOOT_FILES unset for entry #%d' % part.lineno)
+            raise WicError('No boot files defined, %s unset for entry #%d' % (cls.image_boot_files_var_name, part.lineno))
 
         logger.debug('Boot files: %s', boot_files)
 
Signature · 1 line
2.43.0
#1 lore raw

PATCH 2/2 wic: plugins source bootimage/isoimage rename to allow be imported

Python not support importing modules with - so change to _.

---
 .../source/{bootimg-biosplusefi.py => bootimg_biosplusefi.py}     | 0
 scripts/lib/wic/plugins/source/{bootimg-efi.py => bootimg_efi.py} | 0
 .../plugins/source/{bootimg-partition.py => bootimg_partition.py} | 0
 .../wic/plugins/source/{bootimg-pcbios.py => bootimg_pcbios.py}   | 0
 .../source/{isoimage-isohybrid.py => isoimage_isohybrid.py}       | 0
 5 files changed, 0 insertions(+), 0 deletions(-)
 rename scripts/lib/wic/plugins/source/{bootimg-biosplusefi.py => bootimg_biosplusefi.py} (100%)
 rename scripts/lib/wic/plugins/source/{bootimg-efi.py => bootimg_efi.py} (100%)
 rename scripts/lib/wic/plugins/source/{bootimg-partition.py => bootimg_partition.py} (100%)
 rename scripts/lib/wic/plugins/source/{bootimg-pcbios.py => bootimg_pcbios.py} (100%)
 rename scripts/lib/wic/plugins/source/{isoimage-isohybrid.py => isoimage_isohybrid.py} (100%)
scripts/lib/wic/plugins/source/bootimg_biosplusefi.py renamed from scripts/lib/wic/plugins/source/bootimg-biosplusefi.py +0 -0
similarity index 100%
rename from scripts/lib/wic/plugins/source/bootimg-biosplusefi.py
rename to scripts/lib/wic/plugins/source/bootimg_biosplusefi.py
scripts/lib/wic/plugins/source/bootimg_efi.py renamed from scripts/lib/wic/plugins/source/bootimg-efi.py +0 -0
similarity index 100%
rename from scripts/lib/wic/plugins/source/bootimg-efi.py
rename to scripts/lib/wic/plugins/source/bootimg_efi.py
scripts/lib/wic/plugins/source/bootimg_partition.py renamed from scripts/lib/wic/plugins/source/bootimg-partition.py +0 -0
similarity index 100%
rename from scripts/lib/wic/plugins/source/bootimg-partition.py
rename to scripts/lib/wic/plugins/source/bootimg_partition.py
scripts/lib/wic/plugins/source/bootimg_pcbios.py renamed from scripts/lib/wic/plugins/source/bootimg-pcbios.py +0 -0
similarity index 100%
rename from scripts/lib/wic/plugins/source/bootimg-pcbios.py
rename to scripts/lib/wic/plugins/source/bootimg_pcbios.py
scripts/lib/wic/plugins/source/isoimage_isohybrid.py renamed from scripts/lib/wic/plugins/source/isoimage-isohybrid.py +0 -0
similarity index 100%
rename from scripts/lib/wic/plugins/source/isoimage-isohybrid.py
rename to scripts/lib/wic/plugins/source/isoimage_isohybrid.py
Signature · 1 line
2.43.0
#2 lore raw

Re: [OE-core] [PATCH 2/2] wic: plugins source bootimage/isoimage rename to allow be imported

This breaks some selftests and meta-virtualization:

https://autobuilder.yoctoproject.org/typhoon/#/builders/87/builds/6573/steps/14/logs/stdio

https://autobuilder.yoctoproject.org/typhoon/#/builders/128/builds/3005/steps/12/logs/stdio

Quoted 49 lines · Anibal Limon

Python not support importing modules with - so change to _.

---
 .../source/{bootimg-biosplusefi.py => bootimg_biosplusefi.py}     | 0
 scripts/lib/wic/plugins/source/{bootimg-efi.py => bootimg_efi.py} | 0
 .../plugins/source/{bootimg-partition.py => bootimg_partition.py} | 0
 .../wic/plugins/source/{bootimg-pcbios.py => bootimg_pcbios.py}   | 0
 .../source/{isoimage-isohybrid.py => isoimage_isohybrid.py}       | 0
 5 files changed, 0 insertions(+), 0 deletions(-)
 rename scripts/lib/wic/plugins/source/{bootimg-biosplusefi.py => bootimg_biosplusefi.py} (100%)
 rename scripts/lib/wic/plugins/source/{bootimg-efi.py => bootimg_efi.py} (100%)
 rename scripts/lib/wic/plugins/source/{bootimg-partition.py => bootimg_partition.py} (100%)
 rename scripts/lib/wic/plugins/source/{bootimg-pcbios.py => bootimg_pcbios.py} (100%)
 rename scripts/lib/wic/plugins/source/{isoimage-isohybrid.py => isoimage_isohybrid.py} (100%)
scripts/lib/wic/plugins/source/bootimg_biosplusefi.py renamed from scripts/lib/wic/plugins/source/bootimg-biosplusefi.py +0 -0
similarity index 100%
rename from scripts/lib/wic/plugins/source/bootimg-biosplusefi.py
rename to scripts/lib/wic/plugins/source/bootimg_biosplusefi.py
scripts/lib/wic/plugins/source/bootimg_efi.py renamed from scripts/lib/wic/plugins/source/bootimg-efi.py +0 -0
similarity index 100%
rename from scripts/lib/wic/plugins/source/bootimg-efi.py
rename to scripts/lib/wic/plugins/source/bootimg_efi.py
scripts/lib/wic/plugins/source/bootimg_partition.py renamed from scripts/lib/wic/plugins/source/bootimg-partition.py +0 -0
similarity index 100%
rename from scripts/lib/wic/plugins/source/bootimg-partition.py
rename to scripts/lib/wic/plugins/source/bootimg_partition.py
scripts/lib/wic/plugins/source/bootimg_pcbios.py renamed from scripts/lib/wic/plugins/source/bootimg-pcbios.py +0 -0
similarity index 100%
rename from scripts/lib/wic/plugins/source/bootimg-pcbios.py
rename to scripts/lib/wic/plugins/source/bootimg_pcbios.py
scripts/lib/wic/plugins/source/isoimage_isohybrid.py renamed from scripts/lib/wic/plugins/source/isoimage-isohybrid.py +0 -0
similarity index 100%
rename from scripts/lib/wic/plugins/source/isoimage-isohybrid.py
rename to scripts/lib/wic/plugins/source/isoimage_isohybrid.py
Signature · 11 lines
2.43.0



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#197471): https://lists.openembedded.org/g/openembedded-core/message/197471
Mute This Topic: https://lists.openembedded.org/mt/105108998/3617179
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
Signature · 3 lines
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw

Re: [OE-core] [PATCH 2/2] wic: plugins source bootimage/isoimage rename to allow be imported

Hi,

Thanks for reporting, I will adapt the tests.

Regards,
Anibal

Quoted 78 lines · On Mon, Mar 25, 2024, 04:18 Alexandre Belloni <[email protected]>…

This breaks some selftests and meta-virtualization:

https://autobuilder.yoctoproject.org/typhoon/#/builders/87/builds/6573/steps/14/logs/stdio

https://autobuilder.yoctoproject.org/typhoon/#/builders/128/builds/3005/steps/12/logs/stdio

Quoted 11 lines · Anibal Limon

Python not support importing modules with - so change to _.

---
 .../source/{bootimg-biosplusefi.py => bootimg_biosplusefi.py}     | 0
 scripts/lib/wic/plugins/source/{bootimg-efi.py => bootimg_efi.py} | 0
 .../plugins/source/{bootimg-partition.py => bootimg_partition.py} | 0
 .../wic/plugins/source/{bootimg-pcbios.py => bootimg_pcbios.py}   | 0
 .../source/{isoimage-isohybrid.py => isoimage_isohybrid.py}       | 0
 5 files changed, 0 insertions(+), 0 deletions(-)
 rename scripts/lib/wic/plugins/source/{bootimg-biosplusefi.py =>

bootimg_biosplusefi.py} (100%)

Quoted 1 line
 rename scripts/lib/wic/plugins/source/{bootimg-efi.py =>

bootimg_efi.py} (100%)

Quoted 1 line
 rename scripts/lib/wic/plugins/source/{bootimg-partition.py =>

bootimg_partition.py} (100%)

Quoted 1 line
 rename scripts/lib/wic/plugins/source/{bootimg-pcbios.py =>

bootimg_pcbios.py} (100%)

Quoted 1 line
 rename scripts/lib/wic/plugins/source/{isoimage-isohybrid.py =>

isoimage_isohybrid.py} (100%)

Review

Quoted 2 lines
(quoted diff) +0 -0

b/scripts/lib/wic/plugins/source/bootimg_biosplusefi.py

Review

Quoted 4 lines

similarity index 100%
rename from scripts/lib/wic/plugins/source/bootimg-biosplusefi.py rename to scripts/lib/wic/plugins/source/bootimg_biosplusefi.py

(quoted diff) +0 -0

b/scripts/lib/wic/plugins/source/bootimg_efi.py

Review

Quoted 4 lines

similarity index 100%
rename from scripts/lib/wic/plugins/source/bootimg-efi.py rename to scripts/lib/wic/plugins/source/bootimg_efi.py

(quoted diff) +0 -0

b/scripts/lib/wic/plugins/source/bootimg_partition.py

Review

Quoted 4 lines

similarity index 100%
rename from scripts/lib/wic/plugins/source/bootimg-partition.py rename to scripts/lib/wic/plugins/source/bootimg_partition.py

(quoted diff) +0 -0

b/scripts/lib/wic/plugins/source/bootimg_pcbios.py

Review

Quoted 4 lines

similarity index 100%
rename from scripts/lib/wic/plugins/source/bootimg-pcbios.py rename to scripts/lib/wic/plugins/source/bootimg_pcbios.py

(quoted diff) +0 -0

b/scripts/lib/wic/plugins/source/isoimage_isohybrid.py

Quoted 11 lines

similarity index 100%
rename from scripts/lib/wic/plugins/source/isoimage-isohybrid.py rename to scripts/lib/wic/plugins/source/isoimage_isohybrid.py --
2.43.0

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#197471):

https://lists.openembedded.org/g/openembedded-core/message/197471

Quoted 3 lines

Mute This Topic: https://lists.openembedded.org/mt/105108998/3617179
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [

[email protected]]

Quoted 2 lines

-=-=-=-=-=-=-=-=-=-=-=-

--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

#4 lore raw

Re: [OE-core] [PATCH 2/2] wic: plugins source bootimage/isoimage rename to allow be imported

Quoted 1 line · Anibal Limon via lists.openembedded.org

Thanks for reporting, I will adapt the tests.

Without having to rewrite all of the documentation and existing files, why doesn’t wic just normalise the plugin name that it reads to replace all - with _?

This means you can still import the module names, but doesn’t change existing behaviour at all.

Ross

#5 lore raw

Re: [OE-core] [PATCH 2/2] wic: plugins source bootimage/isoimage rename to allow be imported

Quoted 11 lines · Ross Burton
Quoted 1 line · Anibal Limon via lists.openembedded.org

Thanks for reporting, I will adapt the tests.

Without having to rewrite all of the documentation and existing files, why doesn’t wic just normalise the plugin name that it reads to replace all - with _?

This means you can still import the module names, but doesn’t change existing behaviour at all.

Hi Ross,

So to normalize you mean change python module name from _ to - at runtime?. The plugins already had a name attr with '-', the issue is when trying to import from an external module.

Regards!,
Anibal

Quoted 2 lines

Ross

#6 lore raw

Re: [OE-core] [PATCH 2/2] wic: plugins source bootimage/isoimage rename to allow be imported

Quoted 12 lines · Anibal Limon
Quoted 8 lines · Ross Burton
Quoted 1 line · Anibal Limon via lists.openembedded.org

Thanks for reporting, I will adapt the tests.

Without having to rewrite all of the documentation and existing files, why doesn’t wic just normalise the plugin name that it reads to replace all - with _?

Quoted 7 lines
Quoted 2 lines

This means you can still import the module names, but doesn’t change existing behaviour at all.

So to normalize you mean change python module name from _ to - at runtime?.
The plugins already had a name attr with '-', the issue is when trying to import from an external module.

What Ross is suggesting is that in the code in wic which parses the commandline parameters, we could add a line of code to change "-" in plugin names to "_". We'd need to tweak what gets parsed from the wks files too.

This would make the migration easier. We may or may not want to issue a warning at the same time so the user can know to update their wks file or command.

Cheers,

Richard

#7 lore raw

Re: [OE-core] [PATCH 2/2] wic: plugins source bootimage/isoimage rename to allow be imported

Quoted 21 lines · Richard Purdie
Quoted 12 lines · Anibal Limon
Quoted 8 lines · Ross Burton
Quoted 1 line · Anibal Limon via lists.openembedded.org

Thanks for reporting, I will adapt the tests.

Without having to rewrite all of the documentation and existing files, why doesn’t wic just normalise the plugin name that it reads to replace all - with _?

Quoted 7 lines
Quoted 2 lines

This means you can still import the module names, but doesn’t change existing behaviour at all.

So to normalize you mean change python module name from _ to - at runtime?.
The plugins already had a name attr with '-', the issue is when trying to import from an external module.

Quoted 5 lines

What Ross is suggesting is that in the code in wic which parses the commandline parameters, we could add a line of code to change "-" in plugin names to "_". We'd need to tweak what gets parsed from the wks files too.

Yeah, I find the plugin manager when plugins are loaded.

Quoted 5 lines

This would make the migration easier. We may or may not want to issue a warning at the same time so the user can know to update their wks file or command.

Sure, I think it starts with a warning and then makes the switch at some point or not.

Regards!,
Anibal

Quoted 5 lines

Cheers,

Richard

A message that is not in the archive (sent off-list or not yet received): [email protected]

#9 lore raw

Re: [OE-core] [PATCH 2/2] wic: plugins source bootimage/isoimage rename to allow be imported

Hi,

Finally sent a patch to meta-virtualization, to fix the problem when rename the wic source plugins to allow re-use.

https://lists.yoctoproject.org/g/meta-virtualization/message/9240

Cheers!,
Anibal

Quoted 92 lines · Anibal Limon via lists.openembedded.org

Hi,

Thanks for reporting, I will adapt the tests.

Regards,
Anibal

Quoted 65 lines · On Mon, Mar 25, 2024, 04:18 Alexandre Belloni < [email protected]>…

This breaks some selftests and meta-virtualization:

https://autobuilder.yoctoproject.org/typhoon/#/builders/87/builds/6573/steps/14/logs/stdio

https://autobuilder.yoctoproject.org/typhoon/#/builders/128/builds/3005/steps/12/logs/stdio

Quoted 11 lines · Anibal Limon

Python not support importing modules with - so change to _.

---
 .../source/{bootimg-biosplusefi.py => bootimg_biosplusefi.py}     | 0
 scripts/lib/wic/plugins/source/{bootimg-efi.py => bootimg_efi.py} | 0
 .../plugins/source/{bootimg-partition.py => bootimg_partition.py} | 0
 .../wic/plugins/source/{bootimg-pcbios.py => bootimg_pcbios.py}   | 0
 .../source/{isoimage-isohybrid.py => isoimage_isohybrid.py}       | 0
 5 files changed, 0 insertions(+), 0 deletions(-)
 rename scripts/lib/wic/plugins/source/{bootimg-biosplusefi.py =>

bootimg_biosplusefi.py} (100%)

Quoted 1 line
 rename scripts/lib/wic/plugins/source/{bootimg-efi.py =>

bootimg_efi.py} (100%)

Quoted 1 line
 rename scripts/lib/wic/plugins/source/{bootimg-partition.py =>

bootimg_partition.py} (100%)

Quoted 1 line
 rename scripts/lib/wic/plugins/source/{bootimg-pcbios.py =>

bootimg_pcbios.py} (100%)

Quoted 1 line
 rename scripts/lib/wic/plugins/source/{isoimage-isohybrid.py =>

isoimage_isohybrid.py} (100%)

Review

Quoted 2 lines
(quoted diff) +0 -0

b/scripts/lib/wic/plugins/source/bootimg_biosplusefi.py

Review

Quoted 4 lines

similarity index 100%
rename from scripts/lib/wic/plugins/source/bootimg-biosplusefi.py rename to scripts/lib/wic/plugins/source/bootimg_biosplusefi.py

(quoted diff) +0 -0

b/scripts/lib/wic/plugins/source/bootimg_efi.py

Review

Quoted 4 lines

similarity index 100%
rename from scripts/lib/wic/plugins/source/bootimg-efi.py rename to scripts/lib/wic/plugins/source/bootimg_efi.py

(quoted diff) +0 -0

b/scripts/lib/wic/plugins/source/bootimg_partition.py

Review

Quoted 4 lines

similarity index 100%
rename from scripts/lib/wic/plugins/source/bootimg-partition.py rename to scripts/lib/wic/plugins/source/bootimg_partition.py

(quoted diff) +0 -0

b/scripts/lib/wic/plugins/source/bootimg_pcbios.py

Review

Quoted 4 lines

similarity index 100%
rename from scripts/lib/wic/plugins/source/bootimg-pcbios.py rename to scripts/lib/wic/plugins/source/bootimg_pcbios.py

(quoted diff) +0 -0

b/scripts/lib/wic/plugins/source/isoimage_isohybrid.py

Quoted 10 lines

similarity index 100%
rename from scripts/lib/wic/plugins/source/isoimage-isohybrid.py rename to scripts/lib/wic/plugins/source/isoimage_isohybrid.py --
2.43.0

Quoted 5 lines

--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#197487):
https://lists.openembedded.org/g/openembedded-core/message/197487
Mute This Topic: https://lists.openembedded.org/mt/105108998/8181911
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ [email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

A message that is not in the archive (sent off-list or not yet received): [email protected]

#11 lore raw

Re: [OE-core] [PATCH 2/2] wic: plugins source bootimage/isoimage rename to allow be imported

Just a ping.

After apply this Bruce will apply the meta-virt one,

https://lists.yoctoproject.org/g/meta-virtualization/message/9252

Thanks!,
Anibal

Quoted 108 lines · Anibal Limon via lists.openembedded.org

Hi,

Finally sent a patch to meta-virtualization, to fix the problem when rename the wic source plugins to allow re-use.

https://lists.yoctoproject.org/g/meta-virtualization/message/9240

Cheers!,
Anibal

Quoted 84 lines · Anibal Limon via lists.openembedded.org

Hi,

Thanks for reporting, I will adapt the tests.

Regards,
Anibal

Quoted 70 lines · On Mon, Mar 25, 2024, 04:18 Alexandre Belloni < [email protected]>…

This breaks some selftests and meta-virtualization:

https://autobuilder.yoctoproject.org/typhoon/#/builders/87/builds/6573/steps/14/logs/stdio

https://autobuilder.yoctoproject.org/typhoon/#/builders/128/builds/3005/steps/12/logs/stdio

Quoted 11 lines · Anibal Limon

Python not support importing modules with - so change to _.

---
 .../source/{bootimg-biosplusefi.py => bootimg_biosplusefi.py}     | 0
 scripts/lib/wic/plugins/source/{bootimg-efi.py => bootimg_efi.py} | 0
 .../plugins/source/{bootimg-partition.py => bootimg_partition.py} | 0
 .../wic/plugins/source/{bootimg-pcbios.py => bootimg_pcbios.py}   | 0
 .../source/{isoimage-isohybrid.py => isoimage_isohybrid.py}       | 0
 5 files changed, 0 insertions(+), 0 deletions(-)
 rename scripts/lib/wic/plugins/source/{bootimg-biosplusefi.py =>

bootimg_biosplusefi.py} (100%)

Quoted 1 line
 rename scripts/lib/wic/plugins/source/{bootimg-efi.py =>

bootimg_efi.py} (100%)

Quoted 1 line
 rename scripts/lib/wic/plugins/source/{bootimg-partition.py =>

bootimg_partition.py} (100%)

Quoted 1 line
 rename scripts/lib/wic/plugins/source/{bootimg-pcbios.py =>

bootimg_pcbios.py} (100%)

Quoted 1 line
 rename scripts/lib/wic/plugins/source/{isoimage-isohybrid.py =>

isoimage_isohybrid.py} (100%)

Review

Quoted 2 lines
(quoted diff) +0 -0

b/scripts/lib/wic/plugins/source/bootimg_biosplusefi.py

Review

Quoted 4 lines

similarity index 100%
rename from scripts/lib/wic/plugins/source/bootimg-biosplusefi.py rename to scripts/lib/wic/plugins/source/bootimg_biosplusefi.py

(quoted diff) +0 -0

b/scripts/lib/wic/plugins/source/bootimg_efi.py

Review

Quoted 4 lines

similarity index 100%
rename from scripts/lib/wic/plugins/source/bootimg-efi.py rename to scripts/lib/wic/plugins/source/bootimg_efi.py

(quoted diff) +0 -0

b/scripts/lib/wic/plugins/source/bootimg_partition.py

Review

Quoted 4 lines

similarity index 100%
rename from scripts/lib/wic/plugins/source/bootimg-partition.py rename to scripts/lib/wic/plugins/source/bootimg_partition.py

(quoted diff) +0 -0

b/scripts/lib/wic/plugins/source/bootimg_pcbios.py

Review

Quoted 4 lines

similarity index 100%
rename from scripts/lib/wic/plugins/source/bootimg-pcbios.py rename to scripts/lib/wic/plugins/source/bootimg_pcbios.py

(quoted diff) +0 -0

b/scripts/lib/wic/plugins/source/isoimage_isohybrid.py

Quoted 10 lines

similarity index 100%
rename from scripts/lib/wic/plugins/source/isoimage-isohybrid.py rename to scripts/lib/wic/plugins/source/isoimage_isohybrid.py --
2.43.0

--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#215972):
https://lists.openembedded.org/g/openembedded-core/message/215972
Mute This Topic: https://lists.openembedded.org/mt/105108998/8181911
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ [email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#12 lore raw

Re: [OE-core] [PATCH 2/2] wic: plugins source bootimage/isoimage rename to allow be imported

Quoted 5 lines · Anibal Limon

Just a ping.

After apply this Bruce will apply the meta-virt one,

https://lists.yoctoproject.org/g/meta-virtualization/message/9252

I put this in for testing and there are multiple references in OE-Core which also need renaming as without that we see a ton of failures. I've gone ahead and put a potential patch in master-next but I'm a bit worried the needed thought/planning for a major change like this hasn't happened.

I understand the need to make it, we do need to support existing users somehow though.

Cheers,

Richard

#13 lore raw

Re: [OE-core] [PATCH 2/2] wic: plugins source bootimage/isoimage rename to allow be imported

Hi Richard,

Yeah, I understand, let me know any further breakage I can fix.

Cheers!,
Anibal

Quoted 20 lines · Richard Purdie
Quoted 5 lines · Anibal Limon

Just a ping.

After apply this Bruce will apply the meta-virt one,

https://lists.yoctoproject.org/g/meta-virtualization/message/9252

I put this in for testing and there are multiple references in OE-Core which also need renaming as without that we see a ton of failures. I've gone ahead and put a potential patch in master-next but I'm a bit worried the needed thought/planning for a major change like this hasn't happened.

I understand the need to make it, we do need to support existing users somehow though.

Cheers,

Richard

#14 lore raw

Re: [OE-core] [PATCH 2/2] wic: plugins source bootimage/isoimage rename to allow be imported

Hi Anibal,

Quoted 1 line · Anibal Limon

Yeah, I understand, let me know any further breakage I can fix.

I have patches for oe-core and meta-yocto to fix the issues there. meta-virtualization fails, I believe you have fixes for that. meta-arm and meta-intel also showed issues:

https://autobuilder.yoctoproject.org/valkyrie/#/builders/75/builds/1599

https://autobuilder.yoctoproject.org/valkyrie/#/builders/41/builds/1561
https://autobuilder.yoctoproject.org/valkyrie/#/builders/89/builds/1574

I think the missing pieces to get this merged are:

* A note for the migration guide explaining what changed and how to fix it

* A tweak to wic to warn about "-" characters in the plugin name. This might be able to translate "-" to "_" with a warning to allow some kind of slightly easier migration? At the very least we should give users a better error with a hint about how to fix it.

Cheers,

Richard

#15 lore raw

Re: [OE-core] [PATCH 2/2] wic: plugins source bootimage/isoimage rename to allow be imported

I will fix the failures and add the proper migration doc to the patch.

Thanks!,
Anibal

Quoted 28 lines · Richard Purdie

Hi Anibal,

Quoted 1 line · Anibal Limon

Yeah, I understand, let me know any further breakage I can fix.

I have patches for oe-core and meta-yocto to fix the issues there. meta-virtualization fails, I believe you have fixes for that. meta-arm and meta-intel also showed issues:

https://autobuilder.yoctoproject.org/valkyrie/#/builders/75/builds/1599

https://autobuilder.yoctoproject.org/valkyrie/#/builders/41/builds/1561
https://autobuilder.yoctoproject.org/valkyrie/#/builders/89/builds/1574

I think the missing pieces to get this merged are:

* A note for the migration guide explaining what changed and how to fix it

* A tweak to wic to warn about "-" characters in the plugin name. This might be able to translate "-" to "_" with a warning to allow some kind of slightly easier migration? At the very least we should give users a better error with a hint about how to fix it.

Cheers,

Richard

A message that is not in the archive (sent off-list or not yet received): [email protected]

#17 lore raw

Re: [OE-core] [PATCH 2/2] wic: plugins source bootimage/isoimage rename to allow be imported

Update, I cannot reproduce meta-intel and meta-arm, I will look at autobuilder full config to see if I found something I missed.

Quoted 48 lines · Anibal Limon via lists.openembedded.org

I will fix the failures and add the proper migration doc to the patch.

Thanks!,
Anibal

Quoted 19 lines · Richard Purdie

Hi Anibal,

Quoted 1 line · Anibal Limon

Yeah, I understand, let me know any further breakage I can fix.

I have patches for oe-core and meta-yocto to fix the issues there. meta-virtualization fails, I believe you have fixes for that. meta-arm and meta-intel also showed issues:

https://autobuilder.yoctoproject.org/valkyrie/#/builders/75/builds/1599

https://autobuilder.yoctoproject.org/valkyrie/#/builders/41/builds/1561
https://autobuilder.yoctoproject.org/valkyrie/#/builders/89/builds/1574

I think the missing pieces to get this merged are:

* A note for the migration guide explaining what changed and how to fix it

Quoted 9 lines

* A tweak to wic to warn about "-" characters in the plugin name. This might be able to translate "-" to "_" with a warning to allow some kind of slightly easier migration? At the very least we should give users a better error with a hint about how to fix it.

Cheers,

Richard

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#217313):
https://lists.openembedded.org/g/openembedded-core/message/217313
Mute This Topic: https://lists.openembedded.org/mt/105108998/8181911
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [ [email protected]]
-=-=-=-=-=-=-=-=-=-=-=-