Skip to contentSkip to conversation

common/rc: fix unknown _xfs_repair_test_fs function name

PATCH In review Zorro Lang 2 participants 2 messages Mar 24, 2024

lore
Share & tools
lore

Zorro Lang

author
#0 lore raw

PATCH 1/1 common/rc: fix unknown _xfs_repair_test_fs function name

Sometimes I hit below errors:
./common/rc: line 1293: _xfs_repair_test_fs: command not found ./common/rc: line 1298: _xfs_repair_test_fs: command not found

The _repair_test_fs trys to call _xfs_repair_test_fs(), but there's not that function in fstests. According to commit c7d81cdecbef, it brought in _test_xfs_repair, but called wrong name. So fix it.

Fixes c7d81cdecbef ("check: try to fix the test device if it gets corrupted")
---
 common/rc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
common/rc +2 -2
index 37d26bf2..47736dc3 100644
@@ -1290,12 +1290,12 @@ _repair_test_fs()
 			res=$?
 			if [ $res -gt 0 ]; then
 				echo "mount returns $res; zap log?" >>$tmp.repair
-				_xfs_repair_test_fs -L >>$tmp.repair 2>&1
+				_test_xfs_repair -L >>$tmp.repair 2>&1
 				echo "log zap returns $?" >> $tmp.repair
 			else
 				umount "$TEST_DEV"
 			fi
-			_xfs_repair_test_fs "$@" >>$tmp.repair 2>&1
+			_test_xfs_repair "$@" >>$tmp.repair 2>&1
 			res=$?
 		fi
 		;;
Signature · 1 line
2.44.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Zorro Lang

Sometimes I hit below errors:
./common/rc: line 1293: _xfs_repair_test_fs: command not found ./common/rc: line 1298: _xfs_repair_test_fs: command not found

The _repair_test_fs trys to call _xfs_repair_test_fs(), but there's not that function in fstests. According to commit c7d81cdecbef, it brought in _test_xfs_repair, but called wrong name. So fix it.

Fixes c7d81cdecbef ("check: try to fix the test device if it gets corrupted")

--D

Quoted 27 lines
---
 common/rc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
common/rc +2 -2
index 37d26bf2..47736dc3 100644
@@ -1290,12 +1290,12 @@ _repair_test_fs()
 			res=$?
 			if [ $res -gt 0 ]; then
 				echo "mount returns $res; zap log?" >>$tmp.repair
-				_xfs_repair_test_fs -L >>$tmp.repair 2>&1
+				_test_xfs_repair -L >>$tmp.repair 2>&1
 				echo "log zap returns $?" >> $tmp.repair
 			else
 				umount "$TEST_DEV"
 			fi
-			_xfs_repair_test_fs "$@" >>$tmp.repair 2>&1
+			_test_xfs_repair "$@" >>$tmp.repair 2>&1
 			res=$?
 		fi
 		;;
Signature · 1 line
2.44.0