include libgen.h for basename API prototype
PATCH 1/1 include libgen.h for basename API prototype
basename prototype has been removed from string.h from latest musl [1] compilers e.g. clang-18 flags the absense of prototype as error. therefore include libgen.h for providing it.
[1] https://git.musl-libc.org/cgit/musl/commit/?id=725e17ed6dff4d0cd22487bb64470881e86a92e7
--- common/main.c | 1 + invutil/invidx.c | 1 + 2 files changed, 2 insertions(+)
common/main.c +1 -0
@@ -16,6 +16,7 @@* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ +#include <libgen.h> #include <stdio.h> #include <unistd.h> #include <stdlib.h>
invutil/invidx.c +1 -0
@@ -19,6 +19,7 @@#include <xfs/xfs.h> #include <xfs/jdm.h> +#include <libgen.h> #include <stdio.h> #include <fcntl.h> #include <unistd.h>
Signature · 1 line
2.44.0
Quoted 5 lines · Khem Raj
basename prototype has been removed from
string.hfrom latest musl [1] compilers e.g. clang-18 flags the absense of prototype as error. therefore includelibgen.hfor providing it.[1] https://git.musl-libc.org/cgit/musl/commit/?id=725e17ed6dff4d0cd22487bb64470881e86a92e7
The basename(3) manpage makes reference to glibc's POSIX implementation modifying the string argument passed in. Is that going to cause problems with the existing callsites in xfsdump?
--D
Quoted 34 lines
Signed-off-by Khem Raj <[email protected]>--- common/main.c | 1 + invutil/invidx.c | 1 + 2 files changed, 2 insertions(+)common/main.c +1
-0@@ -16,6 +16,7 @@* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ +#include <libgen.h> #include <stdio.h> #include <unistd.h> #include <stdlib.h> invutil/invidx.c +1
-0@@ -19,6 +19,7 @@#include <xfs/xfs.h> #include <xfs/jdm.h> +#include <libgen.h> #include <stdio.h> #include <fcntl.h> #include <unistd.h> Signature · 1 line
2.44.0