staging: wlan-ng: Remove broken driver prism2_usb
PATCH v2 1/1 staging: wlan-ng: Remove broken driver prism2_usb
Driver has a throughput of 200 to 800kByte/s in non encrypted transmission. All encrypted modes are not working. WLAN without WPA2 is useless these days. Driver is unused since April 2021 as a bug broke the function. Find fix for bug in link below. Remove driver because of its low performance and unusability.
---
v2: rebase and improved description
Checked for artifacts of wlan-ng and prism2_usb in MAINTAINERS. Removed artifacts in Makefile.
Used the following hardware for tests: D-Link DWL-122 and Sinus 111 Tested with build and make clean to ensure that all is OK.
--- drivers/staging/Kconfig | 2 - drivers/staging/Makefile | 1 - drivers/staging/wlan-ng/Kconfig | 13 - drivers/staging/wlan-ng/Makefile | 8 - drivers/staging/wlan-ng/README | 8 - drivers/staging/wlan-ng/TODO | 16 - drivers/staging/wlan-ng/cfg80211.c | 718 ---- drivers/staging/wlan-ng/hfa384x.h | 1236 ------- drivers/staging/wlan-ng/hfa384x_usb.c | 3880 -------------------- drivers/staging/wlan-ng/p80211conv.c | 643 ---- drivers/staging/wlan-ng/p80211conv.h | 141 - drivers/staging/wlan-ng/p80211hdr.h | 189 - drivers/staging/wlan-ng/p80211ioctl.h | 69 - drivers/staging/wlan-ng/p80211metadef.h | 227 -- drivers/staging/wlan-ng/p80211metastruct.h | 236 -- drivers/staging/wlan-ng/p80211mgmt.h | 199 - drivers/staging/wlan-ng/p80211msg.h | 39 - drivers/staging/wlan-ng/p80211netdev.c | 988 ----- drivers/staging/wlan-ng/p80211netdev.h | 212 -- drivers/staging/wlan-ng/p80211req.c | 223 -- drivers/staging/wlan-ng/p80211req.h | 33 - drivers/staging/wlan-ng/p80211types.h | 292 -- drivers/staging/wlan-ng/p80211wep.c | 207 -- drivers/staging/wlan-ng/prism2fw.c | 1213 ------ drivers/staging/wlan-ng/prism2mgmt.c | 1315 ------- drivers/staging/wlan-ng/prism2mgmt.h | 89 - drivers/staging/wlan-ng/prism2mib.c | 742 ---- drivers/staging/wlan-ng/prism2sta.c | 1945 ---------- drivers/staging/wlan-ng/prism2usb.c | 299 -- 29 files changed, 15183 deletions(-) delete mode 100644 drivers/staging/wlan-ng/Kconfig delete mode 100644 drivers/staging/wlan-ng/Makefile delete mode 100644 drivers/staging/wlan-ng/README delete mode 100644 drivers/staging/wlan-ng/TODO delete mode 100644 drivers/staging/wlan-ng/cfg80211.c delete mode 100644 drivers/staging/wlan-ng/hfa384x.h delete mode 100644 drivers/staging/wlan-ng/hfa384x_usb.c delete mode 100644 drivers/staging/wlan-ng/p80211conv.c delete mode 100644 drivers/staging/wlan-ng/p80211conv.h delete mode 100644 drivers/staging/wlan-ng/p80211hdr.h delete mode 100644 drivers/staging/wlan-ng/p80211ioctl.h delete mode 100644 drivers/staging/wlan-ng/p80211metadef.h delete mode 100644 drivers/staging/wlan-ng/p80211metastruct.h delete mode 100644 drivers/staging/wlan-ng/p80211mgmt.h delete mode 100644 drivers/staging/wlan-ng/p80211msg.h delete mode 100644 drivers/staging/wlan-ng/p80211netdev.c delete mode 100644 drivers/staging/wlan-ng/p80211netdev.h delete mode 100644 drivers/staging/wlan-ng/p80211req.c delete mode 100644 drivers/staging/wlan-ng/p80211req.h delete mode 100644 drivers/staging/wlan-ng/p80211types.h delete mode 100644 drivers/staging/wlan-ng/p80211wep.c delete mode 100644 drivers/staging/wlan-ng/prism2fw.c delete mode 100644 drivers/staging/wlan-ng/prism2mgmt.c delete mode 100644 drivers/staging/wlan-ng/prism2mgmt.h delete mode 100644 drivers/staging/wlan-ng/prism2mib.c delete mode 100644 drivers/staging/wlan-ng/prism2sta.c delete mode 100644 drivers/staging/wlan-ng/prism2usb.c
drivers/staging/Kconfig +0 -2
@@ -24,8 +24,6 @@ menuconfig STAGING if STAGING -source "drivers/staging/wlan-ng/Kconfig" - source "drivers/staging/olpc_dcon/Kconfig" source "drivers/staging/rtl8192e/Kconfig"
drivers/staging/Makefile +0 -1
@@ -2,7 +2,6 @@ # Makefile for staging directory obj-y += media/ -obj-$(CONFIG_PRISM2_USB) += wlan-ng/ obj-$(CONFIG_FB_OLPC_DCON) += olpc_dcon/ obj-$(CONFIG_RTL8192E) += rtl8192e/ obj-$(CONFIG_RTL8723BS) += rtl8723bs/
drivers/staging/wlan-ng/Kconfig deleted +0 -13
@@ -1,13 +0,0 @@ -# SPDX-License-Identifier: GPL-2.0 -config PRISM2_USB - tristate "Prism2.5/3 USB driver" - depends on WLAN && USB && CFG80211 - select WIRELESS_EXT - select WEXT_PRIV - select CRC32 - help - This is the wlan-ng prism 2.5/3 USB driver for a wide range of - old USB wireless devices. - - To compile this driver as a module, choose M here: the module - will be called prism2_usb.
drivers/staging/wlan-ng/Makefile deleted +0 -8
@@ -1,8 +0,0 @@ -# SPDX-License-Identifier: GPL-2.0 -obj-$(CONFIG_PRISM2_USB) += prism2_usb.o - -prism2_usb-y := prism2usb.o \ - p80211conv.o \ - p80211req.o \ - p80211wep.o \ - p80211netdev.o
drivers/staging/wlan-ng/README deleted +0 -8
@@ -1,8 +0,0 @@ -TODO: - - checkpatch.pl cleanups - - sparse warnings - - move to use the in-kernel wireless stack - -Please send any patches or complaints about this driver to Greg -Kroah-Hartman <[email protected]> and don't bother the upstream wireless -kernel developers about it, they want nothing to do with it.
drivers/staging/wlan-ng/TODO deleted +0 -16
@@ -1,16 +0,0 @@ -To-do list: - -* Correct the coding style according to Linux guidelines; please read the document - at https://www.kernel.org/doc/html/latest/process/coding-style.html. -* Remove unnecessary debugging/printing macros; for those that are still needed - use the proper kernel API (pr_debug(), dev_dbg(), netdev_dbg()). -* Remove dead code such as unusued functions, variables, fields, etc.. -* Use in-kernel API and remove unnecessary wrappers where possible. -* Fix bugs due to code that sleeps in atomic context. -* Remove the HAL layer and migrate its functionality into the relevant parts of - the driver. -* Switch to use LIB80211. -* Switch to use MAC80211. -* Switch to use CFG80211. -* Improve the error handling of various functions, particularly those that use - existing kernel APIs.
drivers/staging/wlan-ng/cfg80211.c deleted +0 -718
718 lines not on this page · raw message
drivers/staging/wlan-ng/hfa384x.h deleted +0 -1236
1,236 lines not on this page · raw message
drivers/staging/wlan-ng/hfa384x_usb.c deleted +0 -3880
986 lines not on this page · raw message
drivers/staging/wlan-ng/p80211conv.c deleted +0 -643
643 lines not on this page · raw message
drivers/staging/wlan-ng/p80211conv.h deleted +0 -141
141 lines not on this page · raw message
drivers/staging/wlan-ng/p80211hdr.h deleted +0 -189
189 lines not on this page · raw message
drivers/staging/wlan-ng/p80211ioctl.h deleted +0 -69
69 lines not on this page · raw message
drivers/staging/wlan-ng/p80211metadef.h deleted +0 -227
227 lines not on this page · raw message
drivers/staging/wlan-ng/p80211metastruct.h deleted +0 -236
236 lines not on this page · raw message
drivers/staging/wlan-ng/p80211mgmt.h deleted +0 -199
199 lines not on this page · raw message
drivers/staging/wlan-ng/p80211msg.h deleted +0 -39
Lines of this file are not shown. View the raw message.
drivers/staging/wlan-ng/p80211netdev.c deleted +0 -988
988 lines not on this page · raw message
drivers/staging/wlan-ng/p80211netdev.h deleted +0 -212
212 lines not on this page · raw message
drivers/staging/wlan-ng/p80211req.c deleted +0 -223
223 lines not on this page · raw message
drivers/staging/wlan-ng/p80211req.h deleted +0 -33
Lines of this file are not shown. View the raw message.
drivers/staging/wlan-ng/p80211types.h deleted +0 -292
292 lines not on this page · raw message
drivers/staging/wlan-ng/p80211wep.c deleted +0 -207
207 lines not on this page · raw message
drivers/staging/wlan-ng/prism2fw.c deleted +0 -1213
1,213 lines not on this page · raw message
drivers/staging/wlan-ng/prism2mgmt.c deleted +0 -1315
1,315 lines not on this page · raw message
drivers/staging/wlan-ng/prism2mgmt.h deleted +0 -89
89 lines not on this page · raw message
drivers/staging/wlan-ng/prism2mib.c deleted +0 -742
742 lines not on this page · raw message
drivers/staging/wlan-ng/prism2sta.c deleted +0 -1945
1,945 lines not on this page · raw message
drivers/staging/wlan-ng/prism2usb.c deleted +0 -299
299 lines not on this page · raw message
The rest of this diff is not shown. View the raw message.
Signature · 1 line
2.43.2
Part of the diff is not shown here. View the raw message.
Greg Kroah-Hartman
maintainerQuoted 8 lines · Philipp Hortmann
Driver has a throughput of 200 to 800kByte/s in non encrypted transmission. All encrypted modes are not working. WLAN without WPA2 is useless these days. Driver is unused since April 2021 as a bug broke the function. Find fix for bug in link below. Remove driver because of its low performance and unusability.
Quoted 7 lines
---
v2: rebase and improved descriptionChecked for artifacts of wlan-ng and
prism2_usbinMAINTAINERS. Removed artifacts inMakefile.
Used the following hardware for tests: D-Link DWL-122 and Sinus 111 Tested with build and make clean to ensure that all is OK.
Nice, always glad to remove code, now queued up!
greg k-h