selftests-mm-fix-build-with-_fortify_source.patch removed from -mm tree
The quilt patch titled
Subject: selftests/mm: Fix build with _FORTIFY_SOURCE
has been removed from the -mm tree. Its filename was
selftests-mm-fix-build-with-_fortify_source.patch
This patch was dropped because it was merged into the mm-hotfixes-stable branch of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
------------------------------------------------------
From: Vitaly Chikunov <[email protected]>
Subject: selftests/mm: Fix build with _FORTIFY_SOURCE
Date: Mon, 18 Mar 2024 05:34:44 +0300
Add missing flags argument to open(2) call with O_CREAT.
Some tests fail to compile if _FORTIFY_SOURCE is defined (to any valid value) (together with -O), resulting in similar error messages such as:
In file included from /usr/include/fcntl.h:342,
from gup_test.c:1:
In function 'open',
inlined from 'main' at gup_test.c:206:10:
/usr/include/bits/fcntl2.h:50:11: error: call to '__open_missing_mode' declared with attribute error: open with O_CREAT or O_TMPFILE in second argument needs 3 arguments
50 | __open_missing_mode ();
| ^~~~~~~~~~~~~~~~~~~~~~_FORTIFY_SOURCE is enabled by default in some distributions, so the tests are not built by default and are skipped.
open(2) man-page warns about missing flags argument: "if it is not supplied, some arbitrary bytes from the stack will be applied as the file mode."
---
tools/testing/selftests/mm/gup_test.c | 2 +- tools/testing/selftests/mm/soft-dirty.c | 2 +- tools/testing/selftests/mm/split_huge_page_test.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
tools/testing/selftests/mm/gup_test.c renamed from tools/testing/selftests/mm/gup_test.c~selftests-mm-fix-build-with-_fortify_source +1 -1
@@ -203,7 +203,7 @@ int main(int argc, char **argv)ksft_print_header ();ksft_set_plan (nthreads); - filed =open (file,O_RDWR |O_CREAT ); + filed =open (file,O_RDWR |O_CREAT ,0664 );if (filed <0 )ksft_exit_fail_msg ("Unable to open %s: %s\n" , file,strerror (errno));
tools/testing/selftests/mm/soft-dirty.c renamed from tools/testing/selftests/mm/soft-dirty.c~selftests-mm-fix-build-with-_fortify_source +1 -1
@@ -137,7 +137,7 @@ static void test_mprotect(int pagemap_fdif (!map)ksft_exit_fail_msg ("anon mmap failed\n" ); }else { - test_fd =open (fname,O_RDWR |O_CREAT ); + test_fd =open (fname,O_RDWR |O_CREAT ,0664 );if (test_fd <0 ) {ksft_test_result_skip ("Test %s open() file failed\n" , __func__);return ;
tools/testing/selftests/mm/split_huge_page_test.c renamed from tools/testing/selftests/mm/split_huge_page_test.c~selftests-mm-fix-build-with-_fortify_source +1 -1
@@ -223,7 +223,7 @@ void split_file_backed_thp(void)ksft_exit_fail_msg ("Fail to create file-backed THP split testing file\n" ); } - fd =open (testfile,O_CREAT |O_WRONLY ); + fd =open (testfile,O_CREAT |O_WRONLY ,0664 );if (fd ==-1 ) {ksft_perror ("Cannot open testing file" ); goto cleanup;
_
Patches currently in -mm which might be from [email protected] are