Skip to contentSkip to conversation

linux-next: build warning after merge of the mm tree

DISCUSSION Stephen Rothwell 2 participants 3 messages Mar 27, 2024 – Mar 28, 2024

Subsystems (3)
Memory management Linux-next tree Page allocator
lore
Share & tools
lore

Stephen Rothwell

author
#0 lore raw

Hi all,

After merging the mm tree, today's linux-next build (arm multi_v7_defconfig) produced this warning:

mm/page_alloc.c: In function 'build_zonelists':
mm/page_alloc.c:5324:13: warning: unused variable 'node' [-Wunused-variable]

 5324 |         int node, local_node;
      |             ^~~~

Introduced by commit

95d0185255a3 ("mm/page_alloc.c: remove unneeded codes in !NUMA version of build_zonelists()")

from the mm-unstable branch of the mm tree.

Signature · 2 lines
Cheers,
Stephen Rothwell
#1 lore raw
Quoted 7 lines · Stephen Rothwell

Hi all,

After merging the mm tree, today's linux-next build (arm multi_v7_defconfig) produced this warning:

mm/page_alloc.c: In function 'build_zonelists':
mm/page_alloc.c:5324:13: warning: unused variable 'node' [-Wunused-variable]

Quoted 8 lines
 5324 |         int node, local_node;
      |             ^~~~

Introduced by commit

95d0185255a3 ("mm/page_alloc.c: remove unneeded codes in !NUMA version of build_zonelists()")

from the mm-unstable branch of the mm tree.

Thanks. Below code change has been queued on mm-unstable branch to fix it.

From 6bb5aa700a6221248df150cba3d9c54cd95bed97 Mon Sep 17 00:00:00 2001
From: Baoquan He <[email protected]>
Date: Wed, 27 Mar 2024 20:06:45 +0800
Subject: [PATCH]
mm-page_allocc-remove-unneeded-codes-in-numa-version-of-build_zonelists-v2
Content-type: text/plain

remove unused locals

Link https://lkml.kernel.org/r/ZgQL1WOf9K88nLpQ@MiWiFi-R3L-srv open here
Signed-off-by Baoquan He <[email protected]>
Signed-off-by Andrew Morton <[email protected]>
---
 mm/page_alloc.c | 3 ---
 1 file changed, 3 deletions(-)
mm/page_alloc.c +0 -3
index a4f6b5f308ea..9c591413ca04 100644
@@ -5285,12 +5285,9 @@ static void setup_min_slab_ratio(void);
 
 static void build_zonelists(pg_data_t *pgdat)
 {
-	int node, local_node;
 	struct zoneref *zonerefs;
 	int nr_zones;
 
-	local_node = pgdat->node_id;
-
 	zonerefs = pgdat->node_zonelists[ZONELIST_FALLBACK]._zonerefs;
 	nr_zones = build_zonerefs_node(pgdat, zonerefs);
 	zonerefs += nr_zones;
Signature · 1 line
2.41.0
author
#2 lore raw

Hi all,

Quoted 11 lines · On Thu, 28 Mar 2024 09:59:52 +0800 Baoquan He <[email protected]> wrote:
Quoted 9 lines · Stephen Rothwell

After merging the mm tree, today's linux-next build (arm multi_v7_defconfig) produced this warning:

mm/page_alloc.c: In function 'build_zonelists':
mm/page_alloc.c:5324:13: warning: unused variable 'node' [-Wunused-variable]

 5324 |         int node, local_node;
      |             ^~~~
Quoted 7 lines
Quoted 5 lines

Introduced by commit

95d0185255a3 ("mm/page_alloc.c: remove unneeded codes in !NUMA version of build_zonelists()")

from the mm-unstable branch of the mm tree.

Thanks. Below code change has been queued on mm-unstable branch to fix it.

In my i386 defconfig build, this became an error, so I applied your fix patch.

Signature · 2 lines
Cheers,
Stephen Rothwell