objtool/x86: objtool can confuse memory and stack access
PATCH 1/1 objtool/x86: objtool can confuse memory and stack access
The encoding of an x86 instruction can include a ModR/M and a SIB (Scale-Index-Base) byte to describe the addressing mode of the instruction.
objtool processes all addressing mode with a SIB base of 5 as having %rbp as the base register. However, a SIB base of 5 means that the effective address has either no base (if ModR/M mod is zero) or %rbp as the base (if ModR/M mod is 1 or 2). This can cause objtool to confuse an absolute address access with a stack operation.
For example, objtool will see the following instruction:
4c 8b 24 25 e0 ff ff mov 0xffffffffffffffe0,%r12
as a stack operation (i.e. similar to: mov -0x20(%rbp), %r12).
[Note that this kind of weird absolute address access is added by the
compiler when using KASAN.]
If this perceived stack operation happens to reference the location where %r12 was pushed on the stack then the objtool validation will think that %r12 is being restored and this can cause a stack state mismatch.
This kind behavior was seen on xfs code, after a minor change (convert kmem_alloc() to kmalloc()):
Quoted 1 line
Quoted 1 line
fs/xfs/xfs.o: warning: objtool:xfs_da_grow_inode_int+0x6c1: stack state mismatch: reg1[12]=-2-48 reg2[12]=-1+0
--- tools/objtool/arch/x86/decode.c | 8 ++++++++ 1 file changed, 8 insertions(+)
tools/objtool/arch/x86/decode.c +8 -0
@@ -412,6 +412,14 @@ int arch_decode_instruction(struct objtool_file *file, const struct section *secif (!rex_w)break ; +/* +* If the SIB base is 5, and ModRM mod is 0 then there +* is no base. But SIB decoding will set sib_base to +* CFI_BP (register 5). +*/ +if (have_SIB () && sib_base ==CFI_BP && modrm_mod ==0 ) +break ; +if (rm_is_mem (CFI_BP )) {/* mov disp(%rbp), reg */
Signature · 1 line
2.39.3
Josh Poimboeuf
maintainerQuoted 24 lines · Alexandre Chartre
The encoding of an x86 instruction can include a ModR/M and a SIB (Scale-Index-Base) byte to describe the addressing mode of the instruction.
objtool processes all addressing mode with a SIB base of 5 as having %rbp as the base register. However, a SIB base of 5 means that the effective address has either no base (if ModR/M mod is zero) or %rbp as the base (if ModR/M mod is 1 or 2). This can cause objtool to confuse an absolute address access with a stack operation.
For example, objtool will see the following instruction:
4c 8b 24 25 e0 ff ff mov 0xffffffffffffffe0,%r12
as a stack operation (i.e. similar to: mov -0x20(%rbp), %r12).
[Note that this kind of weird absolute address access is added by the
compiler when using KASAN.]If this perceived stack operation happens to reference the location where %r12 was pushed on the stack then the objtool validation will think that %r12 is being restored and this can cause a stack state mismatch.
Quoted 8 lines
This kind behavior was seen on xfs code, after a minor change (convert
kmem_alloc()tokmalloc()):Quoted 1 line
Quoted 1 line
fs/xfs/xfs.o: warning: objtool:xfs_da_grow_inode_int+0x6c1: stack state mismatch: reg1[12]=-2-48 reg2[12]=-1+0
Nice, thanks for finding and debugging this.
Would it make sense to make the check more generic by putting it into rm_is()?
Signature · 1 line
Josh
Quoted 30 lines · Josh Poimboeuf
Quoted 29 lines · Alexandre Chartre
The encoding of an x86 instruction can include a ModR/M and a SIB (Scale-Index-Base) byte to describe the addressing mode of the instruction.
objtool processes all addressing mode with a SIB base of 5 as having %rbp as the base register. However, a SIB base of 5 means that the effective address has either no base (if ModR/M mod is zero) or %rbp as the base (if ModR/M mod is 1 or 2). This can cause objtool to confuse an absolute address access with a stack operation.
For example, objtool will see the following instruction:
4c 8b 24 25 e0 ff ff mov 0xffffffffffffffe0,%r12
as a stack operation (i.e. similar to: mov -0x20(%rbp), %r12).
[Note that this kind of weird absolute address access is added by the
compiler when using KASAN.]If this perceived stack operation happens to reference the location where %r12 was pushed on the stack then the objtool validation will think that %r12 is being restored and this can cause a stack state mismatch.
This kind behavior was seen on xfs code, after a minor change (convert
kmem_alloc()tokmalloc()):Quoted 1 line
Quoted 1 line
fs/xfs/xfs.o: warning: objtool:xfs_da_grow_inode_int+0x6c1: stack state mismatch: reg1[12]=-2-48 reg2[12]=-1+0
Quoted 9 lines
Quoted 3 lines
Nice, thanks for finding and debugging this.
Would it make sense to make the check more generic by putting it into
rm_is()?
Yes. Making the change.
Thanks,
alex.