Skip to contentSkip to conversation

arm64: dts: rockchip: Enable device-tree overlay support for select devices

PATCH In review Chris Morgan 2 participants 2 messages Mar 28, 2024

Subsystems (2)
Device tree bindings Arm Rockchip
lore
Share & tools
lore

Chris Morgan

author
#0 lore raw

PATCH 1/1 arm64: dts: rockchip: Enable device-tree overlay support for select devices

From: Chris Morgan <[email protected]>

Add the '-@' DTC option for the Rock 5B and Indiedroid Nova devices. These two devices are relatively new both with external GPIO headers for expansion. This does impact the filesize of the DTB substantially.

rk3588-rock-5b.dtb 75352 -> 150094 bytes
rk3588s-indiedroid-nova.dtb 69507 -> 136739 bytes

Signed-off-by Chris Morgan <[email protected]>
---
 arch/arm64/boot/dts/rockchip/Makefile | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm64/boot/dts/rockchip/Makefile +5 -0
index f906a868b71a..26f306db0aea 100644
@@ -1,4 +1,9 @@
 # SPDX-License-Identifier: GPL-2.0
+
+# Enable support for external device-tree overlays
+DTC_FLAGS_rk3588-rock-5b			:= -@
+DTC_FLAGS_rk3588s-indiedroid-nova		:= -@
+
 dtb-$(CONFIG_ARCH_ROCKCHIP) += px30-evb.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += px30-engicam-px30-core-ctouch2.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += px30-engicam-px30-core-ctouch2-of10.dtb
Signature · 1 line
2.34.1
#1 lore raw

Hello Chris,

Quoted 5 lines · Chris Morgan

From: Chris Morgan <[email protected]>

Add the '-@' DTC option for the Rock 5B and Indiedroid Nova devices. These two devices are relatively new both with external GPIO headers for expansion. This does impact the filesize of the DTB substantially.

I think that enabling this should be either left to Linux distributions, to be enabled for all the dtbs they ship, which they already do, or be enabled by us for all Rockchip DTs, instead of for enabling it just for some boards. However, I think that leaving it to Linux distributions is the preferred way.

Quoted 23 lines

rk3588-rock-5b.dtb 75352 -> 150094 bytes
rk3588s-indiedroid-nova.dtb 69507 -> 136739 bytes

Signed-off-by Chris Morgan <[email protected]>
---
 arch/arm64/boot/dts/rockchip/Makefile | 5 +++++
 1 file changed, 5 insertions(+)
arch/arm64/boot/dts/rockchip/Makefile +5 -0
index f906a868b71a..26f306db0aea 100644
@@ -1,4 +1,9 @@
 # SPDX-License-Identifier: GPL-2.0
+
+# Enable support for external device-tree overlays
+DTC_FLAGS_rk3588-rock-5b			:= -@
+DTC_FLAGS_rk3588s-indiedroid-nova		:= -@
+
 dtb-$(CONFIG_ARCH_ROCKCHIP) += px30-evb.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += px30-engicam-px30-core-ctouch2.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += px30-engicam-px30-core-ctouch2-of10.dtb