Skip to contentSkip to conversation

staging: rtl8192e: remove unnecessary wrapper

PATCH In review Michael Straube 2 participants 2 messages Mar 29, 2024 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8192e: remove unnecessary wrapper

_rtl92e_dm_ctrl_initgain_byrssi() is just a wrapper around _rtl92e_dm_ctrl_initgain_byrssi_driver(). Using a wrapper here adds no value, remove it. Keep the name _rtl92e_dm_ctrl_initgain_byrssi().

---
Compile-tested only.

 drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)
drivers/staging/rtl8192e/rtl8192e/rtl_dm.c +1 -7
index 4c67bfe0e8ec..aebe67f1a46d 100644
@@ -163,7 +163,6 @@ static	void	_rtl92e_dm_check_tx_power_tracking(struct net_device *dev);
 
 static void _rtl92e_dm_dig_init(struct net_device *dev);
 static void _rtl92e_dm_ctrl_initgain_byrssi(struct net_device *dev);
-static void _rtl92e_dm_ctrl_initgain_byrssi_driver(struct net_device *dev);
 static void _rtl92e_dm_initial_gain(struct net_device *dev);
 static void _rtl92e_dm_pd_th(struct net_device *dev);
 static void _rtl92e_dm_cs_ratio(struct net_device *dev);
@@ -929,11 +928,6 @@ static void _rtl92e_dm_dig_init(struct net_device *dev)
 		dm_digtable.rx_gain_range_min = DM_DIG_MIN;
 }
 
-static void _rtl92e_dm_ctrl_initgain_byrssi(struct net_device *dev)
-{
-	_rtl92e_dm_ctrl_initgain_byrssi_driver(dev);
-}
-
 /*-----------------------------------------------------------------------------
  * Function:	dm_CtrlInitGainBeforeConnectByRssiAndFalseAlarm()
  *
@@ -952,7 +946,7 @@ static void _rtl92e_dm_ctrl_initgain_byrssi(struct net_device *dev)
  *
  ******************************************************************************/
 
-static void _rtl92e_dm_ctrl_initgain_byrssi_driver(struct net_device *dev)
+static void _rtl92e_dm_ctrl_initgain_byrssi(struct net_device *dev)
 {
 	struct r8192_priv *priv = rtllib_priv(dev);
 	u8 i;
Signature · 1 line
2.44.0
Tested-by on v1 1/1
#1 lore raw
Quoted 36 lines · Michael Straube

_rtl92e_dm_ctrl_initgain_byrssi() is just a wrapper around _rtl92e_dm_ctrl_initgain_byrssi_driver(). Using a wrapper here adds no value, remove it. Keep the name _rtl92e_dm_ctrl_initgain_byrssi().

---
Compile-tested only.

  drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 8 +-------
  1 file changed, 1 insertion(+), 7 deletions(-)
drivers/staging/rtl8192e/rtl8192e/rtl_dm.c +0 -6
index 4c67bfe0e8ec..aebe67f1a46d 100644
@@ -163,7 +163,6 @@ static	void	_rtl92e_dm_check_tx_power_tracking(struct net_device *dev);
 
  static void _rtl92e_dm_dig_init(struct net_device *dev);
  static void _rtl92e_dm_ctrl_initgain_byrssi(struct net_device *dev);
-static void _rtl92e_dm_ctrl_initgain_byrssi_driver(struct net_device *dev);
  static void _rtl92e_dm_initial_gain(struct net_device *dev);
  static void _rtl92e_dm_pd_th(struct net_device *dev);
  static void _rtl92e_dm_cs_ratio(struct net_device *dev);
@@ -929,11 +928,6 @@ static void _rtl92e_dm_dig_init(struct net_device *dev)
  		dm_digtable.rx_gain_range_min = DM_DIG_MIN;
  }
 
-static void _rtl92e_dm_ctrl_initgain_byrssi(struct net_device *dev)
-{
-	_rtl92e_dm_ctrl_initgain_byrssi_driver(dev);
-}
-
  /*-----------------------------------------------------------------------------
   * Function:	dm_CtrlInitGainBeforeConnectByRssiAndFalseAlarm()
   *

drivers/staging/rtl8192e/rtl8192e/rtl_dm.c static void _rtl92e_dm_ctrl_initgain_byrssi(struct net_device *dev) · line 952

Quoted 8 lines
drivers/staging/rtl8192e/rtl8192e/rtl_dm.c +1 -1
@@ -952,7 +946,7 @@ static void _rtl92e_dm_ctrl_initgain_byrssi(struct net_device *dev)
   *
   ******************************************************************************/
 
-static void _rtl92e_dm_ctrl_initgain_byrssi_driver(struct net_device *dev)
+static void _rtl92e_dm_ctrl_initgain_byrssi(struct net_device *dev)
  {
  	struct r8192_priv *priv = rtllib_priv(dev);
  	u8 i;