Skip to contentSkip to conversation

dt-bindings: serial: actions,owl-uart: convert to dtschema

PATCH Superseded Kanak Shilledar 2 participants 2 messages Mar 31, 2024

Subsystems (3)

v4 of 5 Superseded Latest is v5 →

lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 dt-bindings: serial: actions,owl-uart: convert to dtschema

From: Kanak Shilledar <[email protected]>

Convert the Actions Semi Owl UART to newer DT schema. Created DT schema based on the .txt file which had compatible, reg and interrupts as the
required properties. This binding is used by Actions S500, S700 and S900 SoC. S700 and S900 use the same UART compatible string.

---
Changes in v4
- added clocks property to fix warning of 'clocks' was unexpected while running make dtbs_check. clocks property was not defined in the original .txt file. clocks property is removed from the required section.
- added clocks property in example
- extended the devicetree with clocks node

---
 .../bindings/serial/actions,owl-uart.txt      | 16 -------
 .../bindings/serial/actions,owl-uart.yaml     | 48 +++++++++++++++++++
 2 files changed, 48 insertions(+), 16 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/serial/actions,owl-uart.txt
 create mode 100644 Documentation/devicetree/bindings/serial/actions,owl-uart.yaml
Documentation/devicetree/bindings/serial/actions,owl-uart.txt deleted +0 -16
deleted file mode 100644
index aa873eada02d..000000000000
@@ -1,16 +0,0 @@
-Actions Semi Owl UART
-
-Required properties:
-- compatible :  "actions,s500-uart", "actions,owl-uart" for S500
-                "actions,s900-uart", "actions,owl-uart" for S900
-- reg        :  Offset and length of the register set for the device.
-- interrupts :  Should contain UART interrupt.
-
-
-Example:
-
-		uart3: serial@b0126000 {
-			compatible = "actions,s500-uart", "actions,owl-uart";
-			reg = <0xb0126000 0x1000>;
-			interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>;
-		};
Documentation/devicetree/bindings/serial/actions,owl-uart.yaml new file +48 -0

48 lines not on this page · raw message

Signature · 1 line
2.34.1
Reviewed-by on v4 1/1
#1 lore raw
Quoted 9 lines · Kanak Shilledar

From: Kanak Shilledar <[email protected]>

Convert the Actions Semi Owl UART to newer DT schema. Created DT schema based on the .txt file which had compatible, reg and interrupts as the
required properties. This binding is used by Actions S500, S700 and S900 SoC. S700 and S900 use the same UART compatible string.

I explicitly asked you to drop my tag. Last time I raised the problem that you implement some other changes and do not implement what reviewer is asking for. It seems this continues the pattern.

Quoted 9 lines

---
Changes in v4
- added clocks property to fix warning of 'clocks' was unexpected while running make dtbs_check. clocks property was not defined in the original .txt file. clocks property is removed from the required section.
- added clocks property in example
- extended the devicetree with clocks node

Please keep the reset of the changelog.

You had two other versions, what was changing? Why this is not even correct? Your v4 did not add clocks to the example. It was already in v3.

How can we know what you changed here if this changelog is totally mixing everything from all changes?

Please read this carefully and read the feedback carefully. Then create changelogs which represent REAL CHANGES, like:
https://lore.kernel.org/all/[email protected]/

If someone asks you to drop the tag, you MUST drop the tag.

The patch is fine though, so I would give Review tag now. Keep above for future and no need to resend just to fix it. If you send or resend, then fix the changelog.

FWIW

BUT, your patch won't be applied... because you decided not to CC maintainers. I have no clue how or why did you come up with such Cc list. There is a guideline in your project, whether this is GSoC or mentorship or whatever, how to send patches. Please read carefully this guideline.

Standard form letter:

Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC (and consider --no-git-fallback argument). It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of people, so fix your workflow. Tools might also fail if you work on some ancient tree (don't, instead use mainline), work on fork of kernel (don't, instead use mainline) or you ignore some maintainers (really don't). Just use b4 and everything should be fine, although remember about b4 prep --auto-to-cc if you added new patches to the patchset.

Best regards,
Krzysztof