Skip to contentSkip to conversation

scsi: aic79xx: add scb NULL check in ahd_handle_ign_wide_residue()

PATCH Superseded Aleksandr Aprelkov 1 participant 1 message Apr 1, 2024

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: aic79xx: add scb NULL check in ahd_handle_ign_wide_residue()

If ahd_lookup_scb() returns NULL and (ahd_inb() & DPHASE) != 0 NULL pointer dereference happens inside ahd_get_transfer_dir()

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes 1da177e4c3f4 ("Linux-2.6.12-rc2")
---
 drivers/scsi/aic7xxx/aic79xx_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/aic7xxx/aic79xx_core.c +1 -1
index 3e3100dbfda3..bac23ee11c62 100644
@@ -5664,7 +5664,7 @@ ahd_handle_ign_wide_residue(struct ahd_softc *ahd, struct ahd_devinfo *devinfo)
 	 * Perhaps add datadir to some spare bits in the hscb?
 	 */
 	if ((ahd_inb(ahd, SEQ_FLAGS) & DPHASE) == 0
-	 || ahd_get_transfer_dir(scb) != CAM_DIR_IN) {
+	 || (scb && ahd_get_transfer_dir(scb) != CAM_DIR_IN)) {
 		/*
 		 * Ignore the message if we haven't
 		 * seen an appropriate data phase yet.
Signature · 1 line
2.34.1