ext4/01{2,9}: fix invalid filesystem option 'journal'
PATCH v2 1/1 ext4/01{2,9}: fix invalid filesystem option 'journal'
Creating an ext4 filesystem using '-O journal' will fail with:
Invalid filesystem option set: journal
Fix it by replacing it by '-O has_journal', which ensures the filesystem (ext3 or ext4) is created with a journal. While there, also redirect stderr and stdout to the full log.
---
changes since v1 (after tytso's review):
- instead of dropping '-O journal', replace it by '-O has_journal'
- redirect std{out,err} to log
- use _scratch_mkfs instead of _scratch_mkfs_ext4
tests/ext4/012 | 2 +- tests/ext4/019 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
tests/ext4/012 +1 -1
@@ -32,7 +32,7 @@ TESTDIR="${SCRATCH_MNT}/scratchdir" TESTFILE="${TESTDIR}/testfile" echo "+ create scratch fs" -_scratch_mkfs_ext4 -O journal > /dev/null 2>&1 +_scratch_mkfs -O has_journal >> $seqres.full 2>&1 echo "+ mount fs image" _scratch_mount
tests/ext4/019 +1 -1
@@ -32,7 +32,7 @@ TESTDIR="${SCRATCH_MNT}/scratchdir" TESTFILE="${TESTDIR}/testfile" echo "+ create scratch fs" -_scratch_mkfs_ext4 -O journal > /dev/null 2>&1 +_scratch_mkfs -O has_journal >> $seqres.full 2>&1 echo "+ mount fs image" _scratch_mount
Quoted 9 lines · Luis Henriques (SUSE)
Creating an ext4 filesystem using '-O journal' will fail with:
Invalid filesystem option set: journal
Fix it by replacing it by '-O
has_journal', which ensures the filesystem (ext3 or ext4) is created with a journal. While there, also redirect stderr and stdout to the full log.Signed-off-by Luis Henriques (SUSE) <[email protected]>
Looks ok,
--D
Quoted 37 lines
---
changes since v1 (after tytso's review):
- instead of dropping '-O journal', replace it by '-Ohas_journal'
- redirect std{out,err} to log
- use_scratch_mkfsinstead of_scratch_mkfs_ext4tests/ext4/012 | 2 +- tests/ext4/019 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)tests/ext4/012 +1
-1@@ -32,7 +32,7 @@ TESTDIR="${SCRATCH_MNT}/scratchdir" TESTFILE="${TESTDIR}/testfile" echo "+ create scratch fs" -_scratch_mkfs_ext4 -O journal > /dev/null 2>&1 +_scratch_mkfs -O has_journal >> $seqres.full 2>&1 echo "+ mount fs image" _scratch_mounttests/ext4/019 +1
-1@@ -32,7 +32,7 @@ TESTDIR="${SCRATCH_MNT}/scratchdir" TESTFILE="${TESTDIR}/testfile" echo "+ create scratch fs" -_scratch_mkfs_ext4 -O journal > /dev/null 2>&1 +_scratch_mkfs -O has_journal >> $seqres.full 2>&1 echo "+ mount fs image" _scratch_mount
Quoted 9 lines · Luis Henriques (SUSE)
Creating an ext4 filesystem using '-O journal' will fail with:
Invalid filesystem option set: journal
Fix it by replacing it by '-O
has_journal', which ensures the filesystem (ext3 or ext4) is created with a journal. While there, also redirect stderr and stdout to the full log.Signed-off-by Luis Henriques (SUSE) <[email protected]>