Skip to contentSkip to conversation

iio: imu: inv_icm42600: add support of ICM-42688-P

PATCH Superseded [email protected] 4 participants 8 messages Apr 2, 2024 – Apr 4, 2024

Subsystems (3)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

v2 cover iio: imu: inv_icm42600: add support of ICM-42688-P

From: Jean-Baptiste Maneyrol <[email protected]>

This series is for adding support of high-end specs ICM-42688-P chip.

Changelog:
* v2: change order of chip definitions and order of patches

Jean-Baptiste Maneyrol (2):
dt-bindings: iio: imu: add icm42688 inside inv_icm42600
iio: imu: inv_icm42600: add support of ICM-42688-P

 .../devicetree/bindings/iio/imu/invensense,icm42600.yaml     | 1 +
 drivers/iio/imu/inv_icm42600/inv_icm42600.h                  | 2 ++
 drivers/iio/imu/inv_icm42600/inv_icm42600_core.c             | 5 +++++
 drivers/iio/imu/inv_icm42600/inv_icm42600_i2c.c              | 3 +++
 drivers/iio/imu/inv_icm42600/inv_icm42600_spi.c              | 3 +++
 5 files changed, 14 insertions(+)

--
2.34.1

TDK-Micronas GmbH
Company Headquarters / Sitz der Gesellschaft: Freiburg i. Br. - Municipal Court of / Amtsgericht: Freiburg i. Br. HRB 6108. VAT ID / USt-IdNr.: DE 812878184 Management / Gesch�ftsf�hrung: Sam Maddalena

This e-mail and any files transmitted with it are confidential information of TDK-Micronas and intended solely for the use of the individual or entity to whom they are addressed. If you have received this e-mail in error please notify the sender by return e-mail and delete all copies of this e-mail message along with all attachments. If you are not the named addressee you should not disseminate, distribute or copy this e-mail.

Bitte vermeiden Sie den Ausdruck dieser E-Mail.
Please consider your environmental responsibility before printing this e-mail.

[X]

[https://www.micronas.tdk.com/sites/default/files/header/2024_04_TDK_Tradeshow_Banner_250x135px_96dpi_embeddedworld.png]<https://www.tdk.com/en/news_center/press/20240312_01.html>

#1 lore raw

PATCH v2 1/2 dt-bindings: iio: imu: add icm42688 inside inv_icm42600

From: Jean-Baptiste Maneyrol <[email protected]>

Add bindings for ICM-42688-P chip.

---
 .../devicetree/bindings/iio/imu/invensense,icm42600.yaml         | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml +1 -0
index 7cd05bcbee31..5e0bed2c45de 100644
@@ -32,6 +32,7 @@ properties:
       - invensense,icm42605
       - invensense,icm42622
       - invensense,icm42631
+      - invensense,icm42688
 
   reg:
     maxItems: 1

--
2.34.1

TDK-Micronas GmbH
Company Headquarters / Sitz der Gesellschaft: Freiburg i. Br. - Municipal Court of / Amtsgericht: Freiburg i. Br. HRB 6108. VAT ID / USt-IdNr.: DE 812878184 Management / Gesch�ftsf�hrung: Sam Maddalena

This e-mail and any files transmitted with it are confidential information of TDK-Micronas and intended solely for the use of the individual or entity to whom they are addressed. If you have received this e-mail in error please notify the sender by return e-mail and delete all copies of this e-mail message along with all attachments. If you are not the named addressee you should not disseminate, distribute or copy this e-mail.

Bitte vermeiden Sie den Ausdruck dieser E-Mail.
Please consider your environmental responsibility before printing this e-mail.

[X]

[https://www.micronas.tdk.com/sites/default/files/header/2024_04_TDK_Tradeshow_Banner_250x135px_96dpi_embeddedworld.png]<https://www.tdk.com/en/news_center/press/20240312_01.html>

Acked-by on v2 1/2
#2 lore raw

Re: [PATCH v2 1/2] dt-bindings: iio: imu: add icm42688 inside inv_icm42600

On Tue, Apr 02, 2024 at 09:00:45AM +0000, [email protected] wrote:

Quoted 5 lines

TDK-Micronas GmbH
Company Headquarters / Sitz der Gesellschaft: Freiburg i. Br. - Municipal Court of / Amtsgericht: Freiburg i. Br. HRB 6108. VAT ID / USt-IdNr.: DE 812878184 Management / Gesch?ftsf?hrung: Sam Maddalena

This e-mail and any files transmitted with it are confidential information of TDK-Micronas and intended solely for the use of the individual or entity to whom they are addressed. If you have received this e-mail in error please notify the sender by return e-mail and delete all copies of this e-mail message along with all attachments. If you are not the named addressee you should not disseminate, distribute or copy this e-mail.

Well, I didn't get it in error since I am an explicit CC, but you sent this to a mailing list...

#3 lore raw

Re: [PATCH v2 1/2] dt-bindings: iio: imu: add icm42688 inside inv_icm42600

In reply to [email protected]
Quoted 24 lines · On 02/04/2024 11:00, [email protected] wrote:

From: Jean-Baptiste Maneyrol <[email protected]>

Add bindings for ICM-42688-P chip.

---
 .../devicetree/bindings/iio/imu/invensense,icm42600.yaml         | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml +1 -1
index 7cd05bcbee31..5e0bed2c45de 100644
@@ -32,6 +32,7 @@ properties:
       - invensense,icm42605
       - invensense,icm42622
       - invensense,icm42631
+      - invensense,icm42688
 
   reg:
     maxItems: 1
--

2.34.1

Quoted 5 lines

TDK-Micronas GmbH
Company Headquarters / Sitz der Gesellschaft: Freiburg i. Br. - Municipal Court of / Amtsgericht: Freiburg i. Br. HRB 6108. VAT ID / USt-IdNr.: DE 812878184 Management / Geschäftsführung: Sam Maddalena

This e-mail and any files transmitted with it are confidential information of TDK-Micronas and intended solely for the use of the individual or entity to whom they are addressed. If you have received this e-mail in error please notify the sender by return e-mail and delete all copies of this e-mail message along with all attachments. If you are not the named addressee you should not disseminate, distribute or copy this e-mail.

Don't send patches which are confidential. Community cannot take them.

Best regards,
Krzysztof

#4 lore raw

Re: [PATCH v2 1/2] dt-bindings: iio: imu: add icm42688 inside inv_icm42600

Hello,

sorry about this mess, this is due to a problem in mail system configuration.

These patches are obviously not confidential. And IP from TDK-Micronas obviously is not applying to TDK-InvenSense products.

I will resend the patches when the issue is fixed.

Sorry for the inconvenience.

Best regards,
JB

From: Krzysztof Kozlowski <[email protected]>
Sent: Thursday, April 4, 2024 09:03
To: INV Git Commit <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]> Cc: [email protected] <[email protected]>; [email protected] <[email protected]>; [email protected] <[email protected]>; Jean-Baptiste Maneyrol <[email protected]> Subject: Re: [PATCH v2 1/2] dt-bindings: iio: imu: add icm42688 inside inv_icm42600

This Message Is From an External Sender
This message came from outside your organization.

Quoted 24 lines · On 02/04/2024 11:00, [email protected] wrote:

From: Jean-Baptiste Maneyrol <[email protected]>

Add bindings for ICM-42688-P chip.

---
 .../devicetree/bindings/iio/imu/invensense,icm42600.yaml         | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/iio/imu/invensense,icm42600.yaml +1 -1
index 7cd05bcbee31..5e0bed2c45de 100644
@@ -32,6 +32,7 @@ properties:
       - invensense,icm42605
       - invensense,icm42622
       - invensense,icm42631
+      - invensense,icm42688
 
   reg:
     maxItems: 1
--

2.34.1

Quoted 5 lines

TDK-Micronas GmbH
Company Headquarters / Sitz der Gesellschaft: Freiburg i. Br. - Municipal Court of / Amtsgericht: Freiburg i. Br. HRB 6108. VAT ID / USt-IdNr.: DE 812878184 Management / Geschäftsführung: Sam Maddalena

This e-mail and any files transmitted with it are confidential information of TDK-Micronas and intended solely for the use of the individual or entity to whom they are addressed. If you have received this e-mail in error please notify the sender by return e-mail and delete all copies of this e-mail message along with all attachments. If you are not the named addressee you should not disseminate, distribute or copy this e-mail.

Don't send patches which are confidential. Community cannot take them.

Best regards,
Krzysztof

#5 lore raw

Re: [PATCH v2 1/2] dt-bindings: iio: imu: add icm42688 inside inv_icm42600

Quoted 9 lines · Jean-Baptiste Maneyrol

Hello,

sorry about this mess, this is due to a problem in mail system configuration.

These patches are obviously not confidential. And IP from TDK-Micronas obviously is not applying to TDK-InvenSense products.

I will resend the patches when the issue is fixed.

Sorry for the inconvenience.

Consider b4 web relay for this:
https://b4.docs.kernel.org/en/latest/contributor/send.html

Best regards,
Krzysztof

#6 lore raw

PATCH v2 2/2 iio: imu: inv_icm42600: add support of ICM-42688-P

In reply to [email protected]

From: Jean-Baptiste Maneyrol <[email protected]>

---
 drivers/iio/imu/inv_icm42600/inv_icm42600.h      | 2 ++
 drivers/iio/imu/inv_icm42600/inv_icm42600_core.c | 5 +++++
 drivers/iio/imu/inv_icm42600/inv_icm42600_i2c.c  | 3 +++
 drivers/iio/imu/inv_icm42600/inv_icm42600_spi.c  | 3 +++
 4 files changed, 13 insertions(+)
drivers/iio/imu/inv_icm42600/inv_icm42600.h +2 -0
index 0e290c807b0f..0566340b2660 100644
@@ -22,6 +22,7 @@ enum inv_icm42600_chip {
        INV_CHIP_ICM42602,
        INV_CHIP_ICM42605,
        INV_CHIP_ICM42622,
+       INV_CHIP_ICM42688,
        INV_CHIP_ICM42631,
        INV_CHIP_NB,
 };
@@ -304,6 +305,7 @@ struct inv_icm42600_state {
 #define INV_ICM42600_WHOAMI_ICM42602                   0x41
 #define INV_ICM42600_WHOAMI_ICM42605                   0x42
 #define INV_ICM42600_WHOAMI_ICM42622                   0x46
+#define INV_ICM42600_WHOAMI_ICM42688                   0x47
 #define INV_ICM42600_WHOAMI_ICM42631                   0x5C
 
 /* User bank 1 (MSB 0x10) */
drivers/iio/imu/inv_icm42600/inv_icm42600_core.c +5 -0
index a5e81906e37e..82e0a2e2ad70 100644
@@ -87,6 +87,11 @@ static const struct inv_icm42600_hw inv_icm42600_hw[INV_CHIP_NB] = {
                .name = "icm42622",
                .conf = &inv_icm42600_default_conf,
        },
+       [INV_CHIP_ICM42688] = {
+               .whoami = INV_ICM42600_WHOAMI_ICM42688,
+               .name = "icm42688",
+               .conf = &inv_icm42600_default_conf,
+       },
        [INV_CHIP_ICM42631] = {
                .whoami = INV_ICM42600_WHOAMI_ICM42631,
                .name = "icm42631",
drivers/iio/imu/inv_icm42600/inv_icm42600_i2c.c +3 -0
index 1af559403ba6..ebb28f84ba98 100644
@@ -84,6 +84,9 @@ static const struct of_device_id inv_icm42600_of_matches[] = {
        }, {
                .compatible = "invensense,icm42622",
                .data = (void *)INV_CHIP_ICM42622,
+       }, {
+               .compatible = "invensense,icm42688",
+               .data = (void *)INV_CHIP_ICM42688,
        }, {
                .compatible = "invensense,icm42631",
                .data = (void *)INV_CHIP_ICM42631,
drivers/iio/imu/inv_icm42600/inv_icm42600_spi.c +3 -0
index 6be4ac794937..50217a10e0bb 100644
@@ -80,6 +80,9 @@ static const struct of_device_id inv_icm42600_of_matches[] = {
        }, {
                .compatible = "invensense,icm42622",
                .data = (void *)INV_CHIP_ICM42622,
+       }, {
+               .compatible = "invensense,icm42688",
+               .data = (void *)INV_CHIP_ICM42688,
        }, {
                .compatible = "invensense,icm42631",
                .data = (void *)INV_CHIP_ICM42631,

--
2.34.1

TDK-Micronas GmbH
Company Headquarters / Sitz der Gesellschaft: Freiburg i. Br. - Municipal Court of / Amtsgericht: Freiburg i. Br. HRB 6108. VAT ID / USt-IdNr.: DE 812878184 Management / Gesch�ftsf�hrung: Sam Maddalena

This e-mail and any files transmitted with it are confidential information of TDK-Micronas and intended solely for the use of the individual or entity to whom they are addressed. If you have received this e-mail in error please notify the sender by return e-mail and delete all copies of this e-mail message along with all attachments. If you are not the named addressee you should not disseminate, distribute or copy this e-mail.

Bitte vermeiden Sie den Ausdruck dieser E-Mail.
Please consider your environmental responsibility before printing this e-mail.

[X]

[https://www.micronas.tdk.com/sites/default/files/header/2024_04_TDK_Tradeshow_Banner_250x135px_96dpi_embeddedworld.png]<https://www.tdk.com/en/news_center/press/20240312_01.html>

#7 lore raw
Quoted 2 lines · On 02/04/2024 11:00, [email protected] wrote:

From: Jean-Baptiste Maneyrol <[email protected]>

Missing commit msg explaining why/what is happening.

Quoted 9 lines
---
 drivers/iio/imu/inv_icm42600/inv_icm42600.h      | 2 ++
 drivers/iio/imu/inv_icm42600/inv_icm42600_core.c | 5 +++++
 drivers/iio/imu/inv_icm42600/inv_icm42600_i2c.c  | 3 +++
 drivers/iio/imu/inv_icm42600/inv_icm42600_spi.c  | 3 +++
 4 files changed, 13 insertions(+)
Quoted 7 lines

2.34.1

TDK-Micronas GmbH
Company Headquarters / Sitz der Gesellschaft: Freiburg i. Br. - Municipal Court of / Amtsgericht: Freiburg i. Br. HRB 6108. VAT ID / USt-IdNr.: DE 812878184 Management / Geschäftsführung: Sam Maddalena

This e-mail and any files transmitted with it are confidential information of TDK-Micronas and intended solely for the use of the individual or entity to whom they are addressed. If you have received this e-mail in error please notify the sender by return e-mail and delete all copies of this e-mail message along with all attachments. If you are not the named addressee you should not disseminate, distribute or copy this e-mail.

Sorry, we cannot work with confidential IP. You also made public your company confidential data, so it looks bad. Please double check it with your company legal department.

Best regards,
Krzysztof