Skip to contentSkip to conversation

arm64: dts: cavium: move non-MMIO node out of soc

PATCH Applied Krzysztof Kozlowski 2 participants 3 messages Apr 2, 2024 – Apr 24, 2024 Device tree bindings

lore
Share & tools
lore

Krzysztof Kozlowski

author
#0 lore raw

PATCH 1/2 arm64: dts: cavium: move non-MMIO node out of soc

Non-MMIO devices, which are BTW not really part of the SoC, should not be within simple-bus, as reported by dtc W=1 warning:

thunder-88xx.dtsi:374.28-379.5: Warning (simple_bus_reg): /soc/refclk50mhz: missing or empty reg/ranges property

Signed-off-by Krzysztof Kozlowski <[email protected]>
---
 arch/arm64/boot/dts/cavium/thunder-88xx.dtsi | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
arch/arm64/boot/dts/cavium/thunder-88xx.dtsi +7 -7
index 8ad31dee11a3..e29e878ee120 100644
@@ -365,19 +365,19 @@ pmu {
 		interrupts = <1 7 4>;
 	};
 
+	refclk50mhz: refclk50mhz {
+		compatible = "fixed-clock";
+		#clock-cells = <0>;
+		clock-frequency = <50000000>;
+		clock-output-names = "refclk50mhz";
+	};
+
 	soc {
 		compatible = "simple-bus";
 		#address-cells = <2>;
 		#size-cells = <2>;
 		ranges;
 
-		refclk50mhz: refclk50mhz {
-			compatible = "fixed-clock";
-			#clock-cells = <0>;
-			clock-frequency = <50000000>;
-			clock-output-names = "refclk50mhz";
-		};
-
 		gic0: interrupt-controller@8010,00000000 {
 			compatible = "arm,gic-v3";
 			#interrupt-cells = <3>;
Signature · 1 line
2.34.1
author
#1 lore raw

PATCH 2/2 arm64: dts: cavium: correct unit addresses

Correct several nodes' unit addresses to fix dtc W=1 warnings:

thunder-88xx.dtsi:381.44-398.5: Warning (simple_bus_reg): /soc/interrupt-controller@8010,00000000: simple-bus unit address format error, expected "801000000000" thunder-88xx.dtsi:400.30-406.5: Warning (simple_bus_reg): /soc/serial@87e0,24000000: simple-bus unit address format error, expected "87e024000000" thunder-88xx.dtsi:408.30-414.5: Warning (simple_bus_reg): /soc/serial@87e0,25000000: simple-bus unit address format error, expected "87e025000000"

Signed-off-by Krzysztof Kozlowski <[email protected]>
---
 arch/arm64/boot/dts/cavium/thunder-88xx.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm64/boot/dts/cavium/thunder-88xx.dtsi +3 -3
index e29e878ee120..2e65ea715800 100644
@@ -378,7 +378,7 @@ soc {
 		#size-cells = <2>;
 		ranges;
 
-		gic0: interrupt-controller@8010,00000000 {
+		gic0: interrupt-controller@801000000000 {
 			compatible = "arm,gic-v3";
 			#interrupt-cells = <3>;
 			#address-cells = <2>;

@@ -397,7 +397,7 @@ its: msi-controller@801000020000 {
 			};
 		};
 
-		uaa0: serial@87e0,24000000 {
+		uaa0: serial@87e024000000 {
 			compatible = "arm,pl011", "arm,primecell";
 			reg = <0x87e0 0x24000000 0x0 0x1000>;
 			interrupts = <1 21 4>;

@@ -405,7 +405,7 @@ uaa0: serial@87e0,24000000 {
 			clock-names = "apb_pclk";
 		};
 
-		uaa1: serial@87e0,25000000 {
+		uaa1: serial@87e025000000 {
 			compatible = "arm,pl011", "arm,primecell";
 			reg = <0x87e0 0x25000000 0x0 0x1000>;
 			interrupts = <1 22 4>;
Signature · 1 line
2.34.1
Applied
#2 lore raw
In reply to Krzysztof Kozlowski
Quoted 6 lines · Krzysztof Kozlowski

Non-MMIO devices, which are BTW not really part of the SoC, should not be within simple-bus, as reported by dtc W=1 warning:

thunder-88xx.dtsi:374.28-379.5: Warning (simple_bus_reg): /soc/refclk50mhz: missing or empty reg/ranges property

Almost a month passed, no replies from maintainers about picking it up. Dunno, looks abandoned, so let me grab this. If anyone else wants to pick it up, let me know.

Applied, thanks!

[1/2] arm64: dts: cavium: move non-MMIO node out of soc

      https://git.kernel.org/krzk/linux-dt/c/e0806688f15cc448e6d8ab0f2fa5e8040a7ab6d5
[2/2] arm64: dts: cavium: correct unit addresses
      https://git.kernel.org/krzk/linux-dt/c/02e361a6f6c72c16f89ca2e07b731025292b5662

Best regards,

Signature · 1 line
Krzysztof Kozlowski <[email protected]>