Skip to contentSkip to conversation

arm64: dts: apm: storm: move non-MMIO node out of soc

PATCH Applied Krzysztof Kozlowski 2 participants 3 messages Apr 2, 2024 – Apr 24, 2024

Subsystems (2)
Device tree bindings Applied micro (apm) x-gene device tree support
lore
Share & tools
lore

Krzysztof Kozlowski

author
#0 lore raw

PATCH 1/2 arm64: dts: apm: storm: move non-MMIO node out of soc

Non-MMIO devices, like fixed-clocks, should not be within simple-bus.

Signed-off-by Krzysztof Kozlowski <[email protected]>
---
 arch/arm64/boot/dts/apm/apm-storm.dtsi | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)
arch/arm64/boot/dts/apm/apm-storm.dtsi +7 -6
index 988928c60f15..633d8418f7cc 100644
@@ -112,6 +112,13 @@ gic: interrupt-controller@78010000 {
 		interrupts = <1 9 0xf04>;	/* GIC Maintenence IRQ */
 	};
 
+	refclk: refclk {
+		compatible = "fixed-clock";
+		#clock-cells = <1>;
+		clock-frequency = <100000000>;
+		clock-output-names = "refclk";
+	};
+
 	timer {
 		compatible = "arm,armv8-timer";
 		interrupts = <1 0 0xff08>,	/* Secure Phys IRQ */

@@ -137,12 +144,6 @@ clocks {
 			#address-cells = <2>;
 			#size-cells = <2>;
 			ranges;
-			refclk: refclk {
-				compatible = "fixed-clock";
-				#clock-cells = <1>;
-				clock-frequency = <100000000>;
-				clock-output-names = "refclk";
-			};
 
 			pcppll: pcppll@17000100 {
 				compatible = "apm,xgene-pcppll-clock";
Signature · 1 line
2.34.1
author
#1 lore raw

PATCH 2/2 arm64: dts: apm: shadowcat: move non-MMIO node out of soc

Non-MMIO devices, like fixed-clocks, should not be within simple-bus.

Signed-off-by Krzysztof Kozlowski <[email protected]>
---
 arch/arm64/boot/dts/apm/apm-shadowcat.dtsi | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
arch/arm64/boot/dts/apm/apm-shadowcat.dtsi +7 -7
index 65ebac3082e2..ea5721ea02f0 100644
@@ -211,6 +211,13 @@ v2m15: v2m@f0000 {
 		};
 	};
 
+	refclk: refclk {
+		compatible = "fixed-clock";
+		#clock-cells = <1>;
+		clock-frequency = <100000000>;
+		clock-output-names = "refclk";
+	};
+
 	pmu {
 		compatible = "arm,armv8-pmuv3";
 		interrupts = <1 12 0xff04>;

@@ -236,13 +243,6 @@ clocks {
 			#size-cells = <2>;
 			ranges;
 
-			refclk: refclk {
-				compatible = "fixed-clock";
-				#clock-cells = <1>;
-				clock-frequency = <100000000>;
-				clock-output-names = "refclk";
-			};
-
 			pmdpll: pmdpll@170000f0 {
 				compatible = "apm,xgene-pcppll-v2-clock";
 				#clock-cells = <1>;
Signature · 1 line
2.34.1
Applied
#2 lore raw
In reply to Krzysztof Kozlowski
Quoted 2 lines · Krzysztof Kozlowski

Non-MMIO devices, like fixed-clocks, should not be within simple-bus.

Almost a month passed, no replies from maintainers about picking it up. Dunno, looks abandoned, so let me grab this. If anyone else wants to pick it up, let me know.

Applied, thanks!

[1/2] arm64: dts: apm: storm: move non-MMIO node out of soc

      https://git.kernel.org/krzk/linux-dt/c/0fbadd0568e4dab360d4d3092d236ce5fafb24ed
[2/2] arm64: dts: apm: shadowcat: move non-MMIO node out of soc
      https://git.kernel.org/krzk/linux-dt/c/4a3e011b7b9955f030df1423c7a54f7e4bd874bd

Best regards,

Signature · 1 line
Krzysztof Kozlowski <[email protected]>