ppdev: Add an error check in register_device
Subsystems (2)
PATCH 1/1 ppdev: Add an error check in register_device
In register_device, the return value of ida_simple_get is unchecked, in witch ida_simple_get will use an invalid index value.
To address this issue, index should be checked after ida_simple_get. When the index value is abnormal, a warning message should be printed and the value should be recorded, then jump to 'err'.
Fixes 9a69645dde11 ("ppdev: fix registering same device name")
Signed-off-by Huai-Yuan Liu <[email protected]>
--- drivers/char/ppdev.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/char/ppdev.c +6 -0
@@ -300,6 +300,12 @@ static int register_device(int minor, struct pp_struct *pp) } index =ida_simple_get (&ida_index,0 ,0 ,GFP_KERNEL ); +if (index <0 ) { +pr_warn ("%s: failed to get index!\n" , name); + rc = index; + goto err; + } +memset (&ppdev_cb,0 ,sizeof (ppdev_cb)); ppdev_cb.irq_func = pp_irq; ppdev_cb.flags = (pp->flags &PP_EXCL ) ?PARPORT_FLAG_EXCL :0 ;
Signature · 1 line
2.34.1