Skip to contentSkip to conversation

ppdev: Add an error check in register_device

PATCH Superseded Huai-Yuan Liu 1 participant 1 message Apr 3, 2024

Subsystems (2)

v1 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ppdev: Add an error check in register_device

In register_device, the return value of ida_simple_get is unchecked, in witch ida_simple_get will use an invalid index value.

To address this issue, index should be checked after ida_simple_get. When the index value is abnormal, a warning message should be printed and the value should be recorded, then jump to 'err'.

Fixes 9a69645dde11 ("ppdev: fix registering same device name")
---
 drivers/char/ppdev.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/char/ppdev.c +6 -0
index 4c188e9e477c..5d688059884d 100644
@@ -300,6 +300,12 @@ static int register_device(int minor, struct pp_struct *pp)
 	}
 
 	index = ida_simple_get(&ida_index, 0, 0, GFP_KERNEL);
+	if (index < 0) {
+		pr_warn("%s: failed to get index!\n", name);
+		rc = index;
+		goto err;
+	}
+
 	memset(&ppdev_cb, 0, sizeof(ppdev_cb));
 	ppdev_cb.irq_func = pp_irq;
 	ppdev_cb.flags = (pp->flags & PP_EXCL) ? PARPORT_FLAG_EXCL : 0;
Signature · 1 line
2.34.1