Skip to contentSkip to conversation

drm/amdgpu: fix incorrect number of active RBs for gfx11

PATCH In review Tim Huang 2 participants 2 messages Apr 3, 2024

Subsystems (2)
lore
Share & tools
lore

Tim Huang

author
#0 lore raw

PATCH 1/1 drm/amdgpu: fix incorrect number of active RBs for gfx11

From: Tim Huang <[email protected]>

The RB bitmap should be global active RB bitmap &
active RB bitmap based on active SA.

---
 drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c +1 -1
index 7a906318e451..07cdeef9d44a 100644
@@ -1635,7 +1635,7 @@ static void gfx_v11_0_setup_rb(struct amdgpu_device *adev)
 			active_rb_bitmap |= (0x3 << (i * rb_bitmap_width_per_sa));
 	}
 
-	active_rb_bitmap |= global_active_rb_bitmap;
+	active_rb_bitmap &= global_active_rb_bitmap;
 	adev->gfx.config.backend_enable_mask = active_rb_bitmap;
 	adev->gfx.config.num_rbs = hweight32(active_rb_bitmap);
 }
Signature · 1 line
2.39.2
Reviewed-by on v1 1/1
#1 lore raw

[AMD Official Use Only - General]

Nice catch.

-----Original Message-----
From: Huang, Tim <[email protected]>
Sent: Wednesday, April 3, 2024 6:18 PM
To: [email protected]
Cc: Deucher, Alexander <[email protected]>; Zhang, Yifan <[email protected]>; Zhang, Hawking <[email protected]>; Huang, Tim <[email protected]>
Subject: [PATCH] drm/amdgpu: fix incorrect number of active RBs for gfx11

From: Tim Huang <[email protected]>

The RB bitmap should be global active RB bitmap & active RB bitmap based on active SA.

---
 drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/gfx_v11_0.c +1 -2
index 7a906318e451..07cdeef9d44a 100644
@@ -1635,7 +1635,7 @@ static void gfx_v11_0_setup_rb(struct amdgpu_device *adev)
                        active_rb_bitmap |= (0x3 << (i * rb_bitmap_width_per_sa));
        }
 
-       active_rb_bitmap |= global_active_rb_bitmap;
+       active_rb_bitmap &= global_active_rb_bitmap;
        adev->gfx.config.backend_enable_mask = active_rb_bitmap;
        adev->gfx.config.num_rbs = hweight32(active_rb_bitmap);  }
--

2.39.2