Skip to contentSkip to conversation

platform/chrome: cros_hps_i2c: Replace deprecated UNIVERSAL_DEV_PM_OPS()

PATCH Applied Andy Shevchenko 2 participants 3 messages Apr 3, 2024 – Apr 8, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 platform/chrome: cros_hps_i2c: Replace deprecated UNIVERSAL_DEV_PM_OPS()

The UNIVERSAL_DEV_PM_OPS() macro is deprecated. Replace it.

---
 drivers/platform/chrome/cros_hps_i2c.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/platform/chrome/cros_hps_i2c.c +2 -2
index b31313080332..dd14957ec39f 100644
@@ -126,7 +126,7 @@ static int hps_resume(struct device *dev)
 	hps_set_power(hps, true);
 	return 0;
 }
-static UNIVERSAL_DEV_PM_OPS(hps_pm_ops, hps_suspend, hps_resume, NULL);
+static DEFINE_RUNTIME_DEV_PM_OPS(hps_pm_ops, hps_suspend, hps_resume, NULL);
 
 static const struct i2c_device_id hps_i2c_id[] = {
 	{ "cros-hps", 0 },
@@ -148,7 +148,7 @@ static struct i2c_driver hps_i2c_driver = {
 	.id_table = hps_i2c_id,
 	.driver = {
 		.name = "cros-hps",
-		.pm = &hps_pm_ops,
+		.pm = pm_ptr(&hps_pm_ops),
 		.acpi_match_table = ACPI_PTR(hps_acpi_id),
 	},
 };
Signature · 1 line
2.43.0.rc1.1.gbec44491f096
#1 lore raw
This patch was applied to chrome-platform/linux.git (for-kernelci) by Tzung-Bi Shih <[email protected]>:

Hello:

This patch was applied to chrome-platform/linux.git (for-kernelci) by Tzung-Bi Shih <[email protected]>:

Quoted 6 lines · On Wed, 3 Apr 2024 13:55:02 +0300 you wrote:

The UNIVERSAL_DEV_PM_OPS() macro is deprecated. Replace it.

---
 drivers/platform/chrome/cros_hps_i2c.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Here is the summary with links:
- [v1,1/1] platform/chrome: cros_hps_i2c: Replace deprecated UNIVERSAL_DEV_PM_OPS()

    https://git.kernel.org/chrome-platform/c/1af853cb6e4d

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
#2 lore raw
In reply to Andy Shevchenko
This patch was applied to chrome-platform/linux.git (for-next) by Tzung-Bi Shih <[email protected]>:

Hello:

This patch was applied to chrome-platform/linux.git (for-next) by Tzung-Bi Shih <[email protected]>:

Quoted 6 lines · On Wed, 3 Apr 2024 13:55:02 +0300 you wrote:

The UNIVERSAL_DEV_PM_OPS() macro is deprecated. Replace it.

---
 drivers/platform/chrome/cros_hps_i2c.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Here is the summary with links:
- [v1,1/1] platform/chrome: cros_hps_i2c: Replace deprecated UNIVERSAL_DEV_PM_OPS()

    https://git.kernel.org/chrome-platform/c/1af853cb6e4d

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html